qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c578ff: tcg/optimize: Fix folding of vector o


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] c578ff: tcg/optimize: Fix folding of vector ops
Date: Tue, 04 Jan 2022 16:45:27 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: c578ff18584666499c3141b2d770b9e36b5e9d7e
      
https://github.com/qemu/qemu/commit/c578ff18584666499c3141b2d770b9e36b5e9d7e
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M tcg/optimize.c

  Log Message:
  -----------
  tcg/optimize: Fix folding of vector ops

Bitwise operations are easy to fold, because the operation is
identical regardless of element size.  But add and sub need
extra element size info that is not currently propagated.

Fixes: 2f9f08ba43d
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/799
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: f341b9aabd0e1bc6b5d3f51d43d09e64b33a5857
      
https://github.com/qemu/qemu/commit/f341b9aabd0e1bc6b5d3f51d43d09e64b33a5857
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M linux-user/host/loongarch64/host-signal.h

  Log Message:
  -----------
  linux-user: Fix trivial build error on loongarch64 hosts

When building using GCC 8.3.0 on loongarch64 (Loongnix) we get:

  In file included from ../linux-user/signal.c:33:
  ../linux-user/host/loongarch64/host-signal.h: In function ‘host_signal_write’:
  ../linux-user/host/loongarch64/host-signal.h:57:9: error: a label can only be 
part of a statement and a declaration is not a statement
         uint32_t sel = (insn >> 15) & 0b11111111111;
         ^~~~~~~~

We don't use the 'sel' variable more than once, so drop it.

Meson output for the record:

  Host machine cpu family: loongarch64
  Host machine cpu: loongarch64
  C compiler for the host machine: cc (gcc 8.3.0 "cc (Loongnix 
8.3.0-6.lnd.vec.27) 8.3.0")
  C linker for the host machine: cc ld.bfd 2.31.1-system

Fixes: ad812c3bd65 ("linux-user: Implement CPU-specific signal handler for 
loongarch64 hosts")
Reported-by: Song Gao <gaosong@loongson.cn>
Suggested-by: Song Gao <gaosong@loongson.cn>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: WANG Xuerui <git@xen0n.name>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220104215027.2180972-1-f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 9de225a1c27500c2d80a916d1c2a41d8e2a5f6e8
      
https://github.com/qemu/qemu/commit/9de225a1c27500c2d80a916d1c2a41d8e2a5f6e8
  Author: Xiaoyao Li <xiaoyao.li@intel.com>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M include/sysemu/sysemu.h

  Log Message:
  -----------
  sysemu: Cleanup qemu_run_machine_init_done_notifiers()

Remove qemu_run_machine_init_done_notifiers() since no implementation
and user.

Fixes: f66dc8737c9 ("vl: move all generic initialization out of vl.c")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220104024136.1433545-1-xiaoyao.li@intel.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: d7478d4229f0a2b2817a55487e6b17081099fae4
      
https://github.com/qemu/qemu/commit/d7478d4229f0a2b2817a55487e6b17081099fae4
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M common-user/host/i386/safe-syscall.inc.S
    M common-user/host/mips/safe-syscall.inc.S
    M common-user/host/x86_64/safe-syscall.inc.S

  Log Message:
  -----------
  common-user: Fix tail calls to safe_syscall_set_errno_tail

For the ABIs in which the syscall return register is not
also the first function argument register, move the errno
value into the correct place.

Fixes: a3310c0397e2 ("linux-user: Move syscall error detection into 
safe_syscall_base")
Reported-by: Laurent Vivier <laurent@vivier.eu>
Tested-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220104190454.542225-1-richard.henderson@linaro.org>


  Commit: 58140d3964c7c545f0880d978f279ed7b4cb41b8
      
https://github.com/qemu/qemu/commit/58140d3964c7c545f0880d978f279ed7b4cb41b8
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-01-04 (Tue, 04 Jan 2022)

  Changed paths:
    M common-user/host/i386/safe-syscall.inc.S
    M common-user/host/mips/safe-syscall.inc.S
    M common-user/host/x86_64/safe-syscall.inc.S
    M include/sysemu/sysemu.h
    M linux-user/host/loongarch64/host-signal.h
    M tcg/optimize.c

  Log Message:
  -----------
  Merge tag 'pull-tcg-20220104' of https://gitlab.com/rth7680/qemu into staging

Fix for safe_syscall_base.
Fix for folding of vector add/sub.
Fix build on loongarch64 with gcc 8.
Remove decl for qemu_run_machine_init_done_notifiers.

# gpg: Signature made Tue 04 Jan 2022 04:39:35 PM PST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[ultimate]

* tag 'pull-tcg-20220104' of https://gitlab.com/rth7680/qemu:
  common-user: Fix tail calls to safe_syscall_set_errno_tail
  sysemu: Cleanup qemu_run_machine_init_done_notifiers()
  linux-user: Fix trivial build error on loongarch64 hosts
  tcg/optimize: Fix folding of vector ops

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/8446c8e3f2eb...58140d3964c7



reply via email to

[Prev in Thread] Current Thread [Next in Thread]