qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 05bfd4: target/hppa: Fix deposit assert from


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 05bfd4: target/hppa: Fix deposit assert from trans_shrpw_imm
Date: Thu, 23 Dec 2021 17:55:15 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 05bfd4db08608bc4c22de729780c1f74612fbc0e
      
https://github.com/qemu/qemu/commit/05bfd4db08608bc4c22de729780c1f74612fbc0e
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-12-23 (Thu, 23 Dec 2021)

  Changed paths:
    M target/hppa/translate.c

  Log Message:
  -----------
  target/hppa: Fix deposit assert from trans_shrpw_imm

Because sa may be 0,

    tcg_gen_deposit_reg(dest, t0, cpu_gr[a->r1], 32 - sa, sa);

may attempt a zero-width deposit at bit 32, which will assert
for TARGET_REGISTER_BITS == 32.

Use the newer extract2 when possible, which itself includes the
rotri special case; otherwise mirror the code from trans_shrpw_sar,
using concat and shri.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/635
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 89f3bfa3265554d1d591ee4d7f1197b6e3397e84
      
https://github.com/qemu/qemu/commit/89f3bfa3265554d1d591ee4d7f1197b6e3397e84
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-12-23 (Thu, 23 Dec 2021)

  Changed paths:
    M target/hppa/translate.c

  Log Message:
  -----------
  Merge tag 'pull-pa-20211223' of https://gitlab.com/rth7680/qemu into staging

Fix target/hppa #635

# gpg: Signature made Thu 23 Dec 2021 05:47:41 PM PST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* tag 'pull-pa-20211223' of https://gitlab.com/rth7680/qemu:
  target/hppa: Fix deposit assert from trans_shrpw_imm

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/f18155a207db...89f3bfa32655



reply via email to

[Prev in Thread] Current Thread [Next in Thread]