[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] be16b8: nbd: allow reconnect on open, with co
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] be16b8: nbd: allow reconnect on open, with corresponding n... |
|
Date: |
Thu, 23 Dec 2021 11:32:40 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: be16b8bf9f231d19c172961d3327f9f72a7cd45f
https://github.com/qemu/qemu/commit/be16b8bf9f231d19c172961d3327f9f72a7cd45f
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-21 (Tue, 21 Dec 2021)
Changed paths:
M block/nbd.c
M qapi/block-core.json
Log Message:
-----------
nbd: allow reconnect on open, with corresponding new options
It is useful when start of vm and start of nbd server are not
simple to sync.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Commit: 169b9a94ed24a40b2bfc8664ecd2e75cd33d0978
https://github.com/qemu/qemu/commit/169b9a94ed24a40b2bfc8664ecd2e75cd33d0978
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-21 (Tue, 21 Dec 2021)
Changed paths:
M nbd/client-connection.c
Log Message:
-----------
nbd/client-connection: nbd_co_establish_connection(): return real error
The only caller of nbd_do_establish_connection() that uses errp is
nbd_open(). The only way to cancel this call is through open_timer
timeout. And for this case, user will be more interested in description
of last failed connect rather than in
"Connection attempt cancelled by other operation".
So, let's change behavior on cancel to return previous failure error if
available.
Do the same for non-blocking failure case. In this case we still don't
have a caller that is interested in errp. But let's be consistent.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Commit: 9e14491af473e94ea836c70c8a57da68d02e62b8
https://github.com/qemu/qemu/commit/9e14491af473e94ea836c70c8a57da68d02e62b8
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-21 (Tue, 21 Dec 2021)
Changed paths:
M nbd/client-connection.c
Log Message:
-----------
nbd/client-connection: improve error message of cancelled attempt
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Commit: c34ec5137d67bab194d5c20e1c85e0e5d392af8c
https://github.com/qemu/qemu/commit/c34ec5137d67bab194d5c20e1c85e0e5d392af8c
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-23 (Thu, 23 Dec 2021)
Changed paths:
M tests/qemu-iotests/iotests.py
Log Message:
-----------
iotests.py: add qemu_tool_popen()
Split qemu_tool_popen() from qemu_tool_pipe_and_status() to be used
separately.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Commit: 94a781f220141ad9f91a1c1583368cd5f24c4d7e
https://github.com/qemu/qemu/commit/94a781f220141ad9f91a1c1583368cd5f24c4d7e
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-23 (Thu, 23 Dec 2021)
Changed paths:
M tests/qemu-iotests/iotests.py
Log Message:
-----------
iotests.py: add and use qemu_io_wrap_args()
For qemu_io* functions support --image-opts argument, which conflicts
with -f argument from qemu_io_args.
For QemuIoInteractive use new wrapper as well, which allows relying on
default format.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Commit: 75c90eeeaf142f70c85ee6b5839abdd7cb1486f5
https://github.com/qemu/qemu/commit/75c90eeeaf142f70c85ee6b5839abdd7cb1486f5
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-23 (Thu, 23 Dec 2021)
Changed paths:
M tests/qemu-iotests/iotests.py
Log Message:
-----------
iotests.py: add qemu_io_popen()
Add qemu-io Popen constructor wrapper. To be used in the following new
test commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Commit: ab7f7e67a7e7b49964109501dfcde4ec29bae60e
https://github.com/qemu/qemu/commit/ab7f7e67a7e7b49964109501dfcde4ec29bae60e
Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Date: 2021-12-23 (Thu, 23 Dec 2021)
Changed paths:
A tests/qemu-iotests/tests/nbd-reconnect-on-open
A tests/qemu-iotests/tests/nbd-reconnect-on-open.out
Log Message:
-----------
iotests: add nbd-reconnect-on-open test
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Nikita Lapshin <nikita.lapshin@virtuozzo.com>
Commit: 1bd88c4542e97f49955c142f8dc04dd32df9e91f
https://github.com/qemu/qemu/commit/1bd88c4542e97f49955c142f8dc04dd32df9e91f
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2021-12-23 (Thu, 23 Dec 2021)
Changed paths:
M block/nbd.c
M nbd/client-connection.c
M qapi/block-core.json
M tests/qemu-iotests/iotests.py
A tests/qemu-iotests/tests/nbd-reconnect-on-open
A tests/qemu-iotests/tests/nbd-reconnect-on-open.out
Log Message:
-----------
Merge tag 'pull-nbd-2021-12-22-v2' of
https://src.openvz.org/scm/~vsementsov/qemu into staging
nbd: reconnect-on-open feature
v2: simple fix for mypy and pylint complains on patch 04
# gpg: Signature made Thu 23 Dec 2021 12:45:20 AM PST
# gpg: using RSA key 8B9C26CDB2FD147C880E86A1561F24C1F19F79FB
# gpg: Good signature from "Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 8B9C 26CD B2FD 147C 880E 86A1 561F 24C1 F19F 79FB
* tag 'pull-nbd-2021-12-22-v2' of https://src.openvz.org/scm/~vsementsov/qemu:
iotests: add nbd-reconnect-on-open test
iotests.py: add qemu_io_popen()
iotests.py: add and use qemu_io_wrap_args()
iotests.py: add qemu_tool_popen()
nbd/client-connection: improve error message of cancelled attempt
nbd/client-connection: nbd_co_establish_connection(): return real error
nbd: allow reconnect on open, with corresponding new options
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/6f016a2f7909...1bd88c4542e9