qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 1b529d: failover: Silence warning messages du


From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] 1b529d: failover: Silence warning messages during qtest
Date: Wed, 22 Dec 2021 07:23:40 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 1b529d908d1e97ac154ab0e68573f8c211aac3f1
      
https://github.com/qemu/qemu/commit/1b529d908d1e97ac154ab0e68573f8c211aac3f1
  Author: Laurent Vivier <lvivier@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M hw/net/virtio-net.c
    M migration/migration.c

  Log Message:
  -----------
  failover: Silence warning messages during qtest

virtio-net-failover test tries several device combinations that produces
some expected warnings.
These warning can be confusing, so we disable them during the qtest
sequence.

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Message-Id: <20211220145314.390697-1-lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
[thuth: Fix memory leak by using error_free()]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 046da5ef5747b8ae8efa02bd1d068abd5d639a12
      
https://github.com/qemu/qemu/commit/046da5ef5747b8ae8efa02bd1d068abd5d639a12
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/boot-serial-test.c

  Log Message:
  -----------
  tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

When running the qtests, there are currently a bunch of warnings about
the deprecated sga device during the boot-serial-test. Switch to
"-M graphics=off" to silence these warnings.

Message-Id: <20211220164042.397028-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 31fb263c2963489055789385aa8b91663756edee
      
https://github.com/qemu/qemu/commit/31fb263c2963489055789385aa8b91663756edee
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/meson.build
    M tests/qtest/test-filter-mirror.c
    M tests/qtest/test-filter-redirector.c
    M tests/qtest/test-netfilter.c

  Log Message:
  -----------
  tests/qtest: Make the filter tests independent from a specific NIC

These filter tests need a NIC, no matter which one, so they use a common
NIC by default. However, these common NIC models might not always have
been compiled into the QEMU target binary, so assuming that a certain NIC
is available is a bad idea. Since the exact type of NIC does not really
matter for these tests, let's switch to "-nic" instead of "-netdev" so
that QEMU can simply pick a default NIC for us.
This way we can now run the tests on other targets that have a default
machine with an on-board/default NIC, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20211220103025.311759-1-thuth@redhat.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 487cf3f2b23e08dacdab0ebc7aaa12e03f65c822
      
https://github.com/qemu/qemu/commit/487cf3f2b23e08dacdab0ebc7aaa12e03f65c822
  Author: Zhang Chen <chen.zhang@intel.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Update COLO Proxy section

Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Message-Id: <20211221080400.1492980-1-chen.zhang@intel.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: ad9e129b0162a1342a407c8d8e2073e4562206f2
      
https://github.com/qemu/qemu/commit/ad9e129b0162a1342a407c8d8e2073e4562206f2
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/libqos/libqtest.h
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  tests/qtest: Add a function that checks whether a device is available

Devices might not always be compiled into the QEMU target binaries.
We already have the libqos framework that is good for handling such
situations, but some of the qtests are not a real good fit for the
libqos framework. Let's add a qtest_has_device() function for such
tests instead.

Message-Id: <20211220081054.151515-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 9cbd66028b82c57f3f24399c6851f21495ccc775
      
https://github.com/qemu/qemu/commit/9cbd66028b82c57f3f24399c6851f21495ccc775
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/endianness-test.c

  Log Message:
  -----------
  tests/qtest: Improve endianness-test to work with missing machines and devices

The users might have built QEMU with less machines or without the
i82378 superio device. Add some checks to the endianess-test so that
it is able to deal with such stripped down QEMU versions, too.

Message-Id: <20211220081054.151515-3-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 95c0b7701885a698a067f402fa430b7c1a562534
      
https://github.com/qemu/qemu/commit/95c0b7701885a698a067f402fa430b7c1a562534
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/cdrom-test.c

  Log Message:
  -----------
  tests/qtest/cdrom-test: Check whether devices are available before using them

Downstream users might want to disable legacy devices in their binaries,
so we should not blindly assume that they are available. Add some proper
checks before using them.

Message-Id: <20211220081054.151515-4-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d6a3dd741823033c9f103f19c8a81044b2cb8c0e
      
https://github.com/qemu/qemu/commit/d6a3dd741823033c9f103f19c8a81044b2cb8c0e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/boot-order-test.c

  Log Message:
  -----------
  tests/qtest/boot-order-test: Check whether machines are available

Machines might not always be compiled into the QEMU binary, so
we should skip the test instead of failing if it is not available.

Message-Id: <20211220081054.151515-5-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: e63ed64c6d10768b3a41c3337226372a9664ef6f
      
https://github.com/qemu/qemu/commit/e63ed64c6d10768b3a41c3337226372a9664ef6f
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M tests/qtest/virtio-net-failover.c

  Log Message:
  -----------
  tests/qtest/virtio-net-failover: Use g_file_open_tmp() to create temporary 
file

g_test_rand_int() must not be called before g_test_init(), otherwise
the glib will show a "g_rand_int: assertion 'rand != NULL' failed"
message in the log. So we could change the order here, but actually,
it's safer to use g_file_open_tmp() anyway, so let's use that function
now instead.

Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211222083652.776592-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8d29feca838bce06473616168b6d5c0b35b96c94
      
https://github.com/qemu/qemu/commit/8d29feca838bce06473616168b6d5c0b35b96c94
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-12-22 (Wed, 22 Dec 2021)

  Changed paths:
    M MAINTAINERS
    M hw/net/virtio-net.c
    M migration/migration.c
    M tests/qtest/boot-order-test.c
    M tests/qtest/boot-serial-test.c
    M tests/qtest/cdrom-test.c
    M tests/qtest/endianness-test.c
    M tests/qtest/libqos/libqtest.h
    M tests/qtest/libqtest.c
    M tests/qtest/meson.build
    M tests/qtest/test-filter-mirror.c
    M tests/qtest/test-filter-redirector.c
    M tests/qtest/test-netfilter.c
    M tests/qtest/virtio-net-failover.c

  Log Message:
  -----------
  Merge tag 'pull-request-2021-12-22' of https://gitlab.com/thuth/qemu into 
staging

* Fixes for the virtio-net-failover test
* Silence warnings in the boot-serial-test
* Make qtests more flexible wrt missing machines and devices

# gpg: Signature made Wed 22 Dec 2021 01:20:18 AM PST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [unknown]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [unknown]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* tag 'pull-request-2021-12-22' of https://gitlab.com/thuth/qemu:
  tests/qtest/virtio-net-failover: Use g_file_open_tmp() to create temporary 
file
  tests/qtest/boot-order-test: Check whether machines are available
  tests/qtest/cdrom-test: Check whether devices are available before using them
  tests/qtest: Improve endianness-test to work with missing machines and devices
  tests/qtest: Add a function that checks whether a device is available
  MAINTAINERS: Update COLO Proxy section
  tests/qtest: Make the filter tests independent from a specific NIC
  tests/qtest/boot-serial-test: Silence the warning about deprecated sga device
  failover: Silence warning messages during qtest

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/8c5f94cd4182...8d29feca838b



reply via email to

[Prev in Thread] Current Thread [Next in Thread]