[Qemu-commits] [qemu/qemu] 52012b: configure: don't override the selected host test c...

[Richard Henderson]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 52012b0809cfb5e7be7ed8434b519c3a2e85c25f
      
https://github.com/qemu/qemu/commit/52012b0809cfb5e7be7ed8434b519c3a2e85c25f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: don't override the selected host test compiler if defined

There are not many cases you would want to do this but one is if you
want to use a test friendly compiler like gcc instead of a system
compiler like clang. Either way we should honour the users choice if
they have made it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Warner Losh <imp@bsdimp.com>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20210917162332.3511179-2-alex.bennee@linaro.org>


  Commit: 4e5a2fc0b2d5e6b31035e41edac7467716874a57
      
https://github.com/qemu/qemu/commit/4e5a2fc0b2d5e6b31035e41edac7467716874a57
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M tests/tcg/multiarch/sha1.c

  Log Message:
  -----------
  tests/tcg/sha1: remove endian include

This doesn't exist in BSD world and doesn't seem to be needed by
either.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20210917162332.3511179-3-alex.bennee@linaro.org>


  Commit: 99bc9f19b3ccfc7ca74a503c679fca629a115d41
      
https://github.com/qemu/qemu/commit/99bc9f19b3ccfc7ca74a503c679fca629a115d41
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M tests/tcg/multiarch/Makefile.target
    R tests/tcg/multiarch/float_helpers.c
    A tests/tcg/multiarch/libs/float_helpers.c
    R tests/tcg/multiarch/linux-test.c
    A tests/tcg/multiarch/linux/linux-test.c
    M tests/tcg/x86_64/Makefile.target

  Log Message:
  -----------
  tests/tcg: move some multiarch files and make conditional

We had some messy code to filter out stuff we can't build. Lets junk
that and simplify the logic by pushing some stuff into subdirs. In
particular we move:

  float_helpers into libs - not a standalone test
  linux-test into linux - so we only build on Linux hosts

This allows for at least some of the tests to be nominally usable
by *BSD user builds.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Warner Losh <imp@bsdimp.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20210917162332.3511179-4-alex.bennee@linaro.org>


  Commit: ffa3dd5159b4e878218b28af59976e91740e6a5f
      
https://github.com/qemu/qemu/commit/ffa3dd5159b4e878218b28af59976e91740e6a5f
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M .gitlab-ci.d/container-cross.yml
    M tests/docker/Makefile.include
    M tests/docker/dockerfiles/debian-riscv64-cross.docker

  Log Message:
  -----------
  tests/docker: promote debian-riscv64-cross to a full image

To be able to cross build QEMU itself we need to include a few more
libraries. These are only available in Debian's unstable ports repo
for now so we need to base the riscv64 image on sid with the the
minimal libs needed to build QEMU (glib/pixman).

The result works but is not as clean as using build-dep to bring in
more dependencies. However sid is by definition a shifting pile of
sand and by keeping the list of libs minimal we reduce the chance of
having an image we can't build. It's good enough for a basic cross
build testing of TCG.

Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210914185830.1378771-2-richard.henderson@linaro.org>
[AJB: tweak allow_failure]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210917162332.3511179-5-alex.bennee@linaro.org>


  Commit: cb64ff0bb63cd2812e37ef49c2831ca1b70107bc
      
https://github.com/qemu/qemu/commit/cb64ff0bb63cd2812e37ef49c2831ca1b70107bc
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab: Add cross-riscv64-system, cross-riscv64-user

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210914185830.1378771-3-richard.henderson@linaro.org>
[AJB: add allow_failure]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210917162332.3511179-6-alex.bennee@linaro.org>


  Commit: 2c8d6e5c6aea0ef993c93aa929aee0b19f569d33
      
https://github.com/qemu/qemu/commit/2c8d6e5c6aea0ef993c93aa929aee0b19f569d33
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Remove the "Release tarball" job

This is a leftover from the days when we were using Travis excessively,
but since x86 jobs are not really usable there anymore, this job has
likely never been used since many months. Let's simply remove it now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210917094826.466047-1-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210917162332.3511179-8-alex.bennee@linaro.org>


  Commit: cbd7a203a9e2fb35b80984b798a681cda2af8310
      
https://github.com/qemu/qemu/commit/cbd7a203a9e2fb35b80984b798a681cda2af8310
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M .gitlab-ci.d/static_checks.yml

  Log Message:
  -----------
  gitlab: skip the check-patch job on the upstream repo

The check-patch job is intended to be used by contributors or
subsystem maintainers to see if there are style mistakes. The
false positive rate is too high to be used in a gating scenario
so should not run it on the upstream repo ever.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210915125452.1704899-2-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210917162332.3511179-9-alex.bennee@linaro.org>


  Commit: 74372eadeb41d1ffb7616260ba3bd5371dc80114
      
https://github.com/qemu/qemu/commit/74372eadeb41d1ffb7616260ba3bd5371dc80114
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M .gitlab-ci.d/cirrus.yml
    M .gitlab-ci.d/cirrus/build.yml

  Log Message:
  -----------
  gitlab: fix passing of TEST_TARGETS env to cirrus

A typo meant the substitution would not work, and the placeholder in the
target file didn't even exist.

The result was that tests were never run on the FreeBSD and macOS jobs,
only a basic build.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20210915125452.1704899-3-berrange@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210917162332.3511179-10-alex.bennee@linaro.org>


  Commit: 8fb6dbd927c82b57fee5ddf38108cfa58246fdcb
      
https://github.com/qemu/qemu/commit/8fb6dbd927c82b57fee5ddf38108cfa58246fdcb
  Author: Lukas Jünger <lukas.junger@greensocs.com>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M plugins/qemu-plugins.symbols

  Log Message:
  -----------
  plugins/: Add missing functions to symbol list

Some functions of the plugin API were missing in
the symbol list. However, they are all used by
the contributed example plugins. QEMU fails to
load the plugin if the function symbol is not
exported.

Signed-off-by: Lukas Jünger <lukas.junger@greensocs.com>
Message-Id: <20210905140939.638928-2-lukas.junger@greensocs.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210917162332.3511179-11-alex.bennee@linaro.org>


  Commit: 1d43009f88e8c9f88b6e58e66e091610543f65fc
      
https://github.com/qemu/qemu/commit/1d43009f88e8c9f88b6e58e66e091610543f65fc
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M accel/tcg/plugin-gen.c
    M include/tcg/tcg.h

  Log Message:
  -----------
  accel/tcg: re-factor plugin_inject_cb so we can assert insn_idx is valid

Coverity doesn't know enough about how we have arranged our plugin TCG
ops to know we will always have incremented insn_idx before injecting
the callback. Let us assert it for the benefit of Coverity and protect
ourselves from accidentally breaking the assumption and triggering
harder to grok errors deeper in the code if we attempt a negative
indexed array lookup.

However to get to this point we re-factor the code and remove the
second hand instruction boundary detection in favour of scanning the
full set of ops and using the existing INDEX_op_insn_start to cleanly
detect when the instruction has started. As we no longer need the
plugin specific list of ops we delete that.

My initial benchmarks shows no discernible impact of dropping the
plugin specific ops list.

Fixes: Coverity 1459509
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210917162332.3511179-12-alex.bennee@linaro.org>


  Commit: 2859c323deacff8d667860ab97c0f6456a2b9192
      
https://github.com/qemu/qemu/commit/2859c323deacff8d667860ab97c0f6456a2b9192
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    R .github/lockdown.yml
    A .github/workflows/lockdown.yml

  Log Message:
  -----------
  .github: move repo lockdown to the v2 configuration

I was getting prompted by GitHub for new permissions but it turns out
per https://github.com/dessant/repo-lockdown/issues/6:

  Repo Lockdown has been rewritten for GitHub Actions, offering new
  features and better control over your automation presets. The legacy
  GitHub App has been deprecated, and the public instance of the app
  has been shut down.

So this is what I've done. As the issues tab is disabled I've removed
the handling for issues from the new version.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20211004154308.2114870-1-alex.bennee@linaro.org>


  Commit: 755c4aefd86f8b8eda1eb37f20024765c70ebbcb
      
https://github.com/qemu/qemu/commit/755c4aefd86f8b8eda1eb37f20024765c70ebbcb
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    M tests/docker/Makefile.include
    M tests/docker/common.rc
    A tests/docker/dockerfiles/debian-native.docker

  Log Message:
  -----------
  tests/docker: add a debian-native image and make available

This image is intended for building whatever the native versions of
QEMU are for the host architecture. This will hopefully be an aid for
3rd parties who want to be able to build QEMU themselves without
redoing all the dependencies themselves.

We disable the registry because we currently don't have multi-arch
support there.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Acked-by: Willian Rampazzo <willianr@redhat.com>
Message-Id: <20210922151528.2192966-1-alex.bennee@linaro.org>


  Commit: 3a76e8a42d86830e7d771a323b0c7a4a5734fedb
      
https://github.com/qemu/qemu/commit/3a76e8a42d86830e7d771a323b0c7a4a5734fedb
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2021-10-08 (Fri, 08 Oct 2021)

  Changed paths:
    R .github/lockdown.yml
    A .github/workflows/lockdown.yml
    M .gitlab-ci.d/cirrus.yml
    M .gitlab-ci.d/cirrus/build.yml
    M .gitlab-ci.d/container-cross.yml
    M .gitlab-ci.d/crossbuilds.yml
    M .gitlab-ci.d/static_checks.yml
    M .travis.yml
    M accel/tcg/plugin-gen.c
    M configure
    M include/tcg/tcg.h
    M plugins/qemu-plugins.symbols
    M tests/docker/Makefile.include
    M tests/docker/common.rc
    A tests/docker/dockerfiles/debian-native.docker
    M tests/docker/dockerfiles/debian-riscv64-cross.docker
    M tests/tcg/multiarch/Makefile.target
    R tests/tcg/multiarch/float_helpers.c
    A tests/tcg/multiarch/libs/float_helpers.c
    R tests/tcg/multiarch/linux-test.c
    A tests/tcg/multiarch/linux/linux-test.c
    M tests/tcg/multiarch/sha1.c
    M tests/tcg/x86_64/Makefile.target

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-for-6.2-081021-1' 
into staging

Some testing and plugin updates:

  - don't override the test compiler when specified
  - split some multiarch tests by guest OS
  - add riscv64 docker image and cross-compile tests
  - drop release tarball test from Travis
  - skip check-patch on master repo
  - fix passing of TEST_TARGETS to cirrus
  - fix missing symbols in plugins
  - refactor plugin instruction boundary detection
  - update github repo lockdown
  - add a debian-native test image for multi-arch builds

# gpg: Signature made Fri 08 Oct 2021 05:00:58 AM PDT
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]

* remotes/stsquad/tags/pull-for-6.2-081021-1:
  tests/docker: add a debian-native image and make available
  .github: move repo lockdown to the v2 configuration
  accel/tcg: re-factor plugin_inject_cb so we can assert insn_idx is valid
  plugins/: Add missing functions to symbol list
  gitlab: fix passing of TEST_TARGETS env to cirrus
  gitlab: skip the check-patch job on the upstream repo
  travis.yml: Remove the "Release tarball" job
  gitlab: Add cross-riscv64-system, cross-riscv64-user
  tests/docker: promote debian-riscv64-cross to a full image
  tests/tcg: move some multiarch files and make conditional
  tests/tcg/sha1: remove endian include
  configure: don't override the selected host test compiler if defined

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


Compare: https://github.com/qemu/qemu/compare/15a0578903dc...3a76e8a42d86