qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ca577a: docs/nvdimm: Update nvdimm option val


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ca577a: docs/nvdimm: Update nvdimm option value in machine...
Date: Mon, 27 Sep 2021 07:02:44 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ca577afc683d0380b5366bdba4c7f0fe5423d809
      
https://github.com/qemu/qemu/commit/ca577afc683d0380b5366bdba4c7f0fe5423d809
  Author: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M docs/nvdimm.txt

  Log Message:
  -----------
  docs/nvdimm: Update nvdimm option value in machine example

Update nvdimm option value in example command from "-machine pc,nvdimm"
to "-machine pc,nvdimm=on" as former complains with the below error:

"qemu-system-x86_64: -machine pc,nvdimm: Expected '=' after parameter 'nvdimm'"

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Message-Id: <20210923103015.135262-1-pankaj.gupta.linux@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 72686c586dd655ef7b946a1295ab8cfbbbcae0ff
      
https://github.com/qemu/qemu/commit/72686c586dd655ef7b946a1295ab8cfbbbcae0ff
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M hw/i386/pc.c
    M include/hw/loader.h

  Log Message:
  -----------
  hw/loader: Restrict PC_ROM_* definitions to hw/i386/pc

The PC_ROM_* definitions are only used by the PC machine,
and are irrelevant to the other architectures / machines.
Reduce their scope by moving them to hw/i386/pc.c.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210917185949.2244956-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 6193344f9337f8b76cd44ce94a32c9900d907d35
      
https://github.com/qemu/qemu/commit/6193344f9337f8b76cd44ce94a32c9900d907d35
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M monitor/hmp-cmds.c

  Log Message:
  -----------
  hmp: Unbreak "change vnc"

HMP command "change vnc" can take the password as argument, or prompt
for it:

    (qemu) change vnc password 123
    (qemu) change vnc password
    Password: ***
    (qemu)

This regressed in commit cfb5387a1d "hmp: remove "change vnc TARGET"
command", v6.0.0.

    (qemu) change vnc passwd 123
    Password: ***
    (qemu) change vnc passwd
    (qemu)

The latter passes NULL to qmp_change_vnc_password(), which is a no-no.
Looks like it puts the display into "password required, but none set"
state.

The logic error is easy to miss in review, but testing should've
caught it.

Fix the obvious way.

Fixes: cfb5387a1de2acda23fb5c97d2378b9e7ddf8025
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210909081219.308065-2-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 8982552e6ad611ff75789e77fe23a891a3e2a5f0
      
https://github.com/qemu/qemu/commit/8982552e6ad611ff75789e77fe23a891a3e2a5f0
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  hmp: Drop a bogus sentence from set_password's documentation

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210909081219.308065-3-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 45b09cb12f5440971b321fc255e3930f38366ace
      
https://github.com/qemu/qemu/commit/45b09cb12f5440971b321fc255e3930f38366ace
  Author: Dongli Zhang <dongli.zhang@oracle.com>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M docs/system/multi-process.rst

  Log Message:
  -----------
  multi-process: fix usage information

>From source code, the 'devid' of x-remote-object should be one of devices
in remote QEMU process.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210713004718.20381-1-dongli.zhang@oracle.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 9b03a1178204598055f23f24e438fdddb5935df9
      
https://github.com/qemu/qemu/commit/9b03a1178204598055f23f24e438fdddb5935df9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-27 (Mon, 27 Sep 2021)

  Changed paths:
    M docs/nvdimm.txt
    M docs/system/multi-process.rst
    M hmp-commands.hx
    M hw/i386/pc.c
    M include/hw/loader.h
    M monitor/hmp-cmds.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-for-6.2-pull-request' into staging

Trivial patches pull request 20210927

# gpg: Signature made Mon 27 Sep 2021 10:52:10 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-for-6.2-pull-request:
  multi-process: fix usage information
  hmp: Drop a bogus sentence from set_password's documentation
  hmp: Unbreak "change vnc"
  hw/loader: Restrict PC_ROM_* definitions to hw/i386/pc
  docs/nvdimm: Update nvdimm option value in machine example

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/11a11998460e...9b03a1178204



reply via email to

[Prev in Thread] Current Thread [Next in Thread]