qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] fae0b0: util: Remove redundant checks in the

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] fae0b0: util: Remove redundant checks in the openpty()
Date: Thu, 16 Sep 2021 08:02:58 -0700 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: fae0b0de71eb823dbe89f5784f3c3971485525cd
      
https://github.com/qemu/qemu/commit/fae0b0de71eb823dbe89f5784f3c3971485525cd
  Author: AlexChen <alex.chen@huawei.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M util/qemu-openpty.c

  Log Message:
  -----------
  util: Remove redundant checks in the openpty()

As we can see from the following function call stack, amaster and aslave
can not be NULL: char_pty_open() -> qemu_openpty_raw() -> openpty().
In addition, according to the API specification for openpty():
https://www.gnu.org/software/libc/manual/html_node/Pseudo_002dTerminal-Pairs.html,
the arguments name, termp and winp can all be NULL, but arguments amaster or 
aslave
can not be NULL.
Finally, amaster and aslave has been dereferenced at the beginning of the 
openpty().
So the checks on amaster and aslave in the openpty() are redundant. Remove them.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <5F9FE5B8.1030803@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 4be8bfcb4d61d7a03e04c942258c6e3e12a2394d
      
https://github.com/qemu/qemu/commit/4be8bfcb4d61d7a03e04c942258c6e3e12a2394d
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  hw/i386/acpi-build: Fix a typo

Fix 'hotplugabble' -> 'hotpluggable' typo.

Reviewed-by: Ani Sinha <ani@anisinha.ca>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210911082036.436139-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 526dc8405dd8cc8b1c9bc9d1ec2d950cb16bef1f
      
https://github.com/qemu/qemu/commit/526dc8405dd8cc8b1c9bc9d1ec2d950cb16bef1f
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Complete qdev_init_gpio_out() documentation

qdev_init_gpio_out() states it "creates an array of anonymous
output GPIO lines" but doesn't document how this array is
released. Add a note that it is automatically free'd in qdev
instance_finalize().

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210819142731.2827912-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 68857f13aa0d74e6ad93dc0224fb070fcba2b936
      
https://github.com/qemu/qemu/commit/68857f13aa0d74e6ad93dc0224fb070fcba2b936
  Author: Michael Tokarev <mjt@tls.msk.ru>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M block/file-posix.c
    M tools/virtiofsd/fuse_lowlevel.h

  Log Message:
  -----------
  spelling: sytem => system

Signed-off-By: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <fefb5f5c-82bc-05e2-b4c1-665e9d6896ff@msgid.tls.msk.ru>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: cd946e5c68fd033455c91ea6b16881022886efbb
      
https://github.com/qemu/qemu/commit/cd946e5c68fd033455c91ea6b16881022886efbb
  Author: John Arbuckle <programmingkidx@gmail.com>
  Date:   2021-09-15 (Wed, 15 Sep 2021)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree

Ensure that a link to pc-bios/qemu_vga.ndrv is added to the build tree,
otherwise the optional MacOS client driver will not be loaded by OpenBIOS
when launching QEMU directly from the build directory.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210831165020.84855-1-programmingkidx@gmail.com>
[lv: commit message rewording as suggested by Mark]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 7916b5fc8cd100c00d7a62e73cc26faf7a487cd9
      
https://github.com/qemu/qemu/commit/7916b5fc8cd100c00d7a62e73cc26faf7a487cd9
  Author: Michael Tokarev <mjt@tls.msk.ru>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M accel/kvm/kvm-all.c
    M target/i386/cpu-sysemu.c

  Log Message:
  -----------
  target/i386: spelling: occured=>occurred, mininum=>minimum

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Message-Id: <20210818141352.417716-1-mjt@msgid.tls.msk.ru>
[lv: add mininum=>minimum in subject]
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 37557b09a6ee1dc93328b1dd53bb26c2b5897cc3
      
https://github.com/qemu/qemu/commit/37557b09a6ee1dc93328b1dd53bb26c2b5897cc3
  Author: Cai Huoqing <caihuoqing@baidu.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M hw/i386/intel_iommu.c

  Log Message:
  -----------
  intel_iommu: Fix typo in comments

Fix typo:
*Unknwon  ==> Unknown
*futher  ==> further
*configed  ==> configured

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: Peter Xu <peterx@redhat.com>
Message-Id: <20210730014942.2311-1-caihuoqing@baidu.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 631ba5a12861f3aeadda11f5a6875f13847d1453
      
https://github.com/qemu/qemu/commit/631ba5a12861f3aeadda11f5a6875f13847d1453
  Author: Cai Huoqing <caihuoqing@baidu.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M hw/vfio/igd.c
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c

  Log Message:
  -----------
  hw/vfio: Fix typo in comments

Fix typo in comments:
*programatically  ==> programmatically
*disconecting  ==> disconnecting
*mulitple  ==> multiple
*timout  ==> timeout
*regsiter  ==> register
*forumula  ==> formula

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210730012613.2198-1-caihuoqing@baidu.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: eba6814a0a85a6e307221af64bf6ad28befaf1f9
      
https://github.com/qemu/qemu/commit/eba6814a0a85a6e307221af64bf6ad28befaf1f9
  Author: Stefan Weil <sw@weilnetz.de>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M target/avr/translate.c

  Log Message:
  -----------
  target/avr: Fix compiler errors (-Werror=enum-conversion)

../target/avr/translate.c: In function ‘gen_jmp_ez’:
../target/avr/translate.c:1012:22: error: implicit conversion from ‘enum 
<anonymous>’ to ‘DisasJumpType’ [-Werror=enum-conversion]
 1012 |     ctx->base.is_jmp = DISAS_LOOKUP;
      |                      ^

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Message-Id: <20210706180936.249912-1-sw@weilnetz.de>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 9ac200acce8c27ef44da31246f337a2454e54e0d
      
https://github.com/qemu/qemu/commit/9ac200acce8c27ef44da31246f337a2454e54e0d
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M target/sparc/cpu.c
    M target/sparc/cpu.h

  Log Message:
  -----------
  target/sparc: Make sparc_cpu_dump_state() static

The sparc_cpu_dump_state() function is only called within
the same file. Make it static.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20210916084002.1918445-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: d1fe59377bbbf91dfded1f08ffe3c636e9db8dc0
      
https://github.com/qemu/qemu/commit/d1fe59377bbbf91dfded1f08ffe3c636e9db8dc0
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M accel/kvm/kvm-all.c
    M block/file-posix.c
    M configure
    M hw/i386/acpi-build.c
    M hw/i386/intel_iommu.c
    M hw/vfio/igd.c
    M hw/vfio/pci-quirks.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c
    M include/hw/qdev-core.h
    M target/avr/translate.c
    M target/i386/cpu-sysemu.c
    M target/sparc/cpu.c
    M target/sparc/cpu.h
    M tools/virtiofsd/fuse_lowlevel.h
    M util/qemu-openpty.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-for-6.2-pull-request' into staging

Trivial patches pull request 20210916

# gpg: Signature made Thu 16 Sep 2021 15:09:39 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-for-6.2-pull-request:
  target/sparc: Make sparc_cpu_dump_state() static
  target/avr: Fix compiler errors (-Werror=enum-conversion)
  hw/vfio: Fix typo in comments
  intel_iommu: Fix typo in comments
  target/i386: spelling: occured=>occurred, mininum=>minimum
  configure: add missing pc-bios/qemu_vga.ndrv symlink in build tree
  spelling: sytem => system
  qdev: Complete qdev_init_gpio_out() documentation
  hw/i386/acpi-build: Fix a typo
  util: Remove redundant checks in the openpty()

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/63cf61256aea...d1fe59377bbb
reply via email to
[Prev in Thread] Current Thread [Next in Thread]