[Qemu-commits] [qemu/qemu] 49dff0: multifd: Implement yank for multifd send side

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 49dff0be8ce535549307b12e53e96fe0f0957bf5
      
https://github.com/qemu/qemu/commit/49dff0be8ce535549307b12e53e96fe0f0957bf5
  Author: Lukas Straub <lukasstraub2@web.de>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/multifd.c
    M migration/multifd.h

  Log Message:
  -----------
  multifd: Implement yank for multifd send side

To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela
 <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras Soares
 Passos <lsoaresp@redhat.com>
Date: Wed, 1 Sep 2021 17:58:57 +0200 (1 week, 15 hours, 17 minutes ago)

[[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 
2021-09-01T17:58:57+0200 using RSA]]
When introducing yank functionality in the migration code I forgot
to cover the multifd send side.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Tested-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 49bffdcfc07991159a2fe63e66ee5b4f5899be69
      
https://github.com/qemu/qemu/commit/49bffdcfc07991159a2fe63e66ee5b4f5899be69
  Author: Lukas Straub <lukasstraub2@web.de>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/multifd.c

  Log Message:
  -----------
  multifd: Unconditionally unregister yank function

To: qemu-devel <qemu-devel@nongnu.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela
 <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras Soares
 Passos <lsoaresp@redhat.com>
Date: Wed, 4 Aug 2021 21:26:32 +0200 (5 weeks, 11 hours, 52 minutes ago)

[[PGP Signed Part:No public key for 35AB0B289C5DB258 created at 
2021-08-04T21:26:32+0200 using RSA]]
Unconditionally unregister yank function in multifd_load_cleanup().
If it is not unregistered here, it will leak and cause a crash
in yank_unregister_instance(). Now if the ioc is still in use
afterwards, it will only lead to qemu not being able to recover
from a hang related to that ioc.

After checking the code, i am pretty sure that ref is always 1
when arriving here. So all this currently does is remove the
unneeded check.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 2d7327b0a90a7e8e6910212cb183dbc9b3c8619a
      
https://github.com/qemu/qemu/commit/2d7327b0a90a7e8e6910212cb183dbc9b3c8619a
  Author: Li Zhijian <lizhijian@cn.fujitsu.com>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/rdma.c
    M migration/trace-events

  Log Message:
  -----------
  migration/rdma: Try to register On-Demand Paging memory region

Previously, for the fsdax mem-backend-file, it will register failed with
Operation not supported. In this case, we can try to register it with
On-Demand Paging[1] like what rpma_mr_reg() does on rpma[2].

[1]: 
https://community.mellanox.com/s/article/understanding-on-demand-paging--odp-x
[2]: http://pmem.io/rpma/manpages/v0.9.0/rpma_mr_reg.3

CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: 69dce57d132897c3cf1412d56567751a1bea19de
      
https://github.com/qemu/qemu/commit/69dce57d132897c3cf1412d56567751a1bea19de
  Author: Li Zhijian <lizhijian@cn.fujitsu.com>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/rdma.c
    M migration/trace-events

  Log Message:
  -----------
  migration/rdma: advise prefetch write for ODP region

To: <quintela@redhat.com>, <dgilbert@redhat.com>
CC: <qemu-devel@nongnu.org>, Li Zhijian <lizhijian@cn.fujitsu.com>, "Marcel 
Apfelbaum" <marcel.apfelbaum@gmail.com>
Date: Mon, 23 Aug 2021 11:33:58 +0800 (2 weeks, 3 days, 3 hours ago)

The responder mr registering with ODP will sent RNR NAK back to
the requester in the face of the page fault.
---------
ibv_poll_cq wc.status=13 RNR retry counter exceeded!
ibv_poll_cq wrid=WRITE RDMA!
---------
ibv_advise_mr(3) helps to make pages present before the actual IO is
conducted so that the responder does page fault as little as possible.

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: d634d0e7b0225f97f45cecb72ca90bd0e7bdb211
      
https://github.com/qemu/qemu/commit/d634d0e7b0225f97f45cecb72ca90bd0e7bdb211
  Author: David Hildenbrand <david@redhat.com>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  migration/ram: Don't passs RAMState to 
migration_clear_memory_region_dirty_bitmap_*()

The parameter is unused, let's drop it.

Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>


  Commit: cd86f9a8b821fec5886355184705c3792b4b7212
      
https://github.com/qemu/qemu/commit/cd86f9a8b821fec5886355184705c3792b4b7212
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M migration/multifd.c
    M migration/multifd.h
    M migration/ram.c
    M migration/rdma.c
    M migration/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/juanquintela/tags/migration.next-pull-request' into staging

Migration Pull request (take 2)

This pull request includes:
- Remove RAMState unused parameter for several prototypes (dropped)
- RDMA fix
- give an error when using RDMA and multifd
- Implement yank for multifd send side

Please, Apply.

# gpg: Signature made Tue 14 Sep 2021 12:50:45 BST
# gpg:                using RSA key 1899FF8EDEBF58CCEE034B82F487EF185872D723
# gpg: Good signature from "Juan Quintela <quintela@redhat.com>" [full]
# gpg:                 aka "Juan Quintela <quintela@trasno.org>" [full]
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/migration.next-pull-request:
  migration/ram: Don't passs RAMState to 
migration_clear_memory_region_dirty_bitmap_*()
  migration/rdma: advise prefetch write for ODP region
  migration/rdma: Try to register On-Demand Paging memory region
  multifd: Unconditionally unregister yank function
  multifd: Implement yank for multifd send side

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/8db7d88dd445...cd86f9a8b821