[Qemu-commits] [qemu/qemu] 1ea47e: docs: add definitions of terms for CI/testing

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 1ea47ede63330c44292424df70dfb0ee44d2110f
      
https://github.com/qemu/qemu/commit/1ea47ede63330c44292424df70dfb0ee44d2110f
  Author: Willian Rampazzo <willianr@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    A docs/devel/ci-definitions.rst
    M docs/devel/ci.rst

  Log Message:
  -----------
  docs: add definitions of terms for CI/testing

To understand the current state of QEMU CI/testing and have a base to
discuss the plans for the future, it is important to define some usual
terms. This patch defines the terms for "Automated tests", "Unit
testing", "Functional testing", "System testing", "Flaky tests",
"Gating", and "Continuous Integration".

Signed-off-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210831152939.97570-2-willianr@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: aca68d95c51513ace81394dc0974a67b99abb234
      
https://github.com/qemu/qemu/commit/aca68d95c51513ace81394dc0974a67b99abb234
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  libqtest: check for g_setenv() failure

g_setenv() can fail; check for it when starting a QEMU process
when we set the QEMU_AUDIO_DRV environment variable.

Because this happens after fork() reporting an exact message
via printf() is a bad idea; just exit(1), as we already do
for the case of execlp() failure.

Fixes: Coverity CID 1460117
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210820163750.9106-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 2ffd4d815e705bdf75563821762da958f49a2b8d
      
https://github.com/qemu/qemu/commit/2ffd4d815e705bdf75563821762da958f49a2b8d
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml

  Log Message:
  -----------
  gitlab-ci: Don't try to use the system libfdt in the debian job

libfdt in Debian is too old to be usable for QEMU. So far we were
silently falling back to the internal dtc submodule, but since
this is wrong, let's remove the --enable-fdt=system switch here now.

Message-Id: <20210827151718.178988-1-thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 87daf898c7bd67ea205516b53302927a0da70902
      
https://github.com/qemu/qemu/commit/87daf898c7bd67ea205516b53302927a0da70902
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: Fix the check for a usable libfdt

The check for libfdt currently has a flaw: If there is a system libfdt, the
meson.build code initialized the fdt variable with fdt = cc.find_library(...).
However, if this libfdt is too old and there is no internal dtc module
available, it continues with "fdt" pointing to the old and unusable version.
The check later in the file that tries to detect whether libfdt is necessary
then fails to trigger:

 if not fdt.found() and fdt_required.length() > 0
  error('fdt not available but required by targets ' + ', '.join(fdt_required))
 endif

The build fails then during compilation instead, which is of course bad
since this is quite confusing and already wasted quite some time of the user.
Thus if libfdt is not usable, we should unset the "fdt" variable immediately
again, so that the build already fails during the configuration phase.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/255
Message-Id: <20210827120901.150276-2-thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6c22853c733efd0a3d243bab48f8af66588f4a7a
      
https://github.com/qemu/qemu/commit/6c22853c733efd0a3d243bab48f8af66588f4a7a
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: Don't use internal libfdt if the user requested the system libfdt

If the users ran configure with --enable-libfdt=system, they likely did
that on purpose. We should not silently fall back to the internal libfdt
if the system libfdt is not usable, but report the problem with a proper
message instead.

Message-Id: <20210827120901.150276-3-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8bc5184d23c2f95727021844895a24c0579928b2
      
https://github.com/qemu/qemu/commit/8bc5184d23c2f95727021844895a24c0579928b2
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M configure
    M contrib/vhost-user-gpu/meson.build
    M meson.build

  Log Message:
  -----------
  configure / meson: Move the GBM handling to meson.build

The GBM library detection does not need to be in the configure script,
since it does not have any user-facing options (there are no
--enable-gbm or --disable-gbm switches). Let's move it to meson.build
instead, so we don't have to clutter config-host.mak with the related
switches.

Additionally, only check for GBM if it is really required, i.e. if we
either compile with OpenGL or with virglrenderer support.

Message-Id: <20210714085045.797168-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: bf6a61855654a306d6256d9fd55813ae1ee914cc
      
https://github.com/qemu/qemu/commit/bf6a61855654a306d6256d9fd55813ae1ee914cc
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    R scripts/show-fixed-bugs.sh

  Log Message:
  -----------
  scripts: Remove the "show-fixed-bugs.sh" file

Since we are not using Launchpad anymore, there is no more need for
this script.

Message-Id: <20210825142143.142037-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8e8e844be48d6e367e523ac418a83a3046cdebfa
      
https://github.com/qemu/qemu/commit/8e8e844be48d6e367e523ac418a83a3046cdebfa
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M qemu-options.hx
    M softmmu/vl.c

  Log Message:
  -----------
  softmmu/vl: Add a "grab-mod" parameter to the -display sdl option

The -display sdl option is not using QAPI internally yet, and uses hand-
crafted parsing instead (see parse_display() in vl.c), which is quite
ugly, since most of the other code is using the QAPIfied DisplayOption
already. Unfortunately, the "alt_grab" and "ctrl_grab" use underscores in
their names which has recently been forbidden in new QAPI code, so
a straight conversion is not possible. While we could add some exceptions
to the QAPI schema parser for this, the way these parameters have been
designed was maybe a bad idea anyway: First, it's not possible to enable
both parameters at the same time, thus instead of two boolean parameters
it would be better to have only one multi-choice parameter instead.
Second, the naming is also somewhat unfortunate since the "alt_grab"
parameter is not about the ALT key, but rather about the left SHIFT key
that has to be used additionally when the parameter is enabled.

So instead of trying to QAPIfy "alt_grab" and "ctrl_grab", let's rather
introduce an alternative to these parameters instead, a new parameter
called "grab-mod" which can either be set to "lshift-lctrl-lalt" or to
"rctrl". In case we ever want to support additional modes later, we can
then also simply extend the list of supported strings here.

Message-Id: <20210825092023.81396-2-thuth@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d46156fdcc60e788dea3bba407d67c950e3de3b5
      
https://github.com/qemu/qemu/commit/d46156fdcc60e788dea3bba407d67c950e3de3b5
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M docs/about/deprecated.rst
    M qemu-options.hx
    M softmmu/vl.c

  Log Message:
  -----------
  softmmu/vl: Deprecate the old grab options

The alt_grab and ctrl_grab parameter of the -display sdl option prevent
the QAPIfication of the "sdl" part of the -display option, so we should
eventually remove them. And since this feature is also rather niche anyway,
we should not clutter the top-level option list with these, so let's
also deprecate the "-alt-grab" and the "-ctrl-grab" options while we're
at it.

Once the deprecation period of "alt_grab" and "ctrl_grab" is over, we
then can finally switch the -display sdl option to use QAPI internally,
too.

Message-Id: <20210825092023.81396-3-thuth@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6695e4c0fd9ef05bf6ab8e3402d5bc95b39c4cf3
      
https://github.com/qemu/qemu/commit/6695e4c0fd9ef05bf6ab8e3402d5bc95b39c4cf3
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M docs/about/deprecated.rst
    M softmmu/vl.c

  Log Message:
  -----------
  softmmu/vl: Deprecate the -sdl and -curses option

It's not that much complicated to type "-display sdl" or "-display curses",
so we should not clutter our main option name space with such simple
wrapper options and rather present the users with a concise interface
instead. Thus let's deprecate the "-sdl" and "-curses" wrapper options now.

Message-Id: <20210825092023.81396-4-thuth@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 935efca6c246c108253b0e4e51cc87648fc7ca10
      
https://github.com/qemu/qemu/commit/935efca6c246c108253b0e4e51cc87648fc7ca10
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-09-06 (Mon, 06 Sep 2021)

  Changed paths:
    M .gitlab-ci.d/buildtest.yml
    M configure
    M contrib/vhost-user-gpu/meson.build
    M docs/about/deprecated.rst
    A docs/devel/ci-definitions.rst
    M docs/devel/ci.rst
    M meson.build
    M qemu-options.hx
    R scripts/show-fixed-bugs.sh
    M softmmu/vl.c
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/thuth-gitlab/tags/pull-request-2021-09-06' into staging

* Add definitions of terms for CI/testing
* Fix g_setenv problem discovered by Coverity
* Gitlab CI improvements
* Build system improvements (configure script + meson.build)
* Removal of the show-fixed-bugs.sh script
* Clean up of the sdl and curses options

# gpg: Signature made Mon 06 Sep 2021 10:51:49 BST
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/thuth-gitlab/tags/pull-request-2021-09-06:
  softmmu/vl: Deprecate the -sdl and -curses option
  softmmu/vl: Deprecate the old grab options
  softmmu/vl: Add a "grab-mod" parameter to the -display sdl option
  scripts: Remove the "show-fixed-bugs.sh" file
  configure / meson: Move the GBM handling to meson.build
  meson.build: Don't use internal libfdt if the user requested the system libfdt
  meson.build: Fix the check for a usable libfdt
  gitlab-ci: Don't try to use the system libfdt in the debian job
  libqtest: check for g_setenv() failure
  docs: add definitions of terms for CI/testing

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/88afdc92b644...935efca6c246