[Qemu-commits] [qemu/qemu] 7bce33: ui/gtk: retry sending VTE console input

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 7bce330ae4040860ddb5ce66dc7999f16577855c
      
https://github.com/qemu/qemu/commit/7bce330ae4040860ddb5ce66dc7999f16577855c
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: retry sending VTE console input

Commit 584af1f1d9 ("ui/gtk: add a keyboard fifo to the VTE
consoles") changed the VTE chardev backend code to rely on the
chr_accept_input() callback function. The code expects a
chr_accept_input() call whenever qemu_chr_be_can_write() bytes
were written. It turns out this is wrong. Some chardev
frontends only call this callback after can_write was 0.

Change the code to send data until the keyboard fifo is empty
or qemu_chr_be_can_write() returns 0.

Fixes: 584af1f1d9 ("ui/gtk: add a keyboard fifo to the VTE consoles")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210810063257.17411-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: da77adbaf619c4d170cb42d769145ad1803fbad9
      
https://github.com/qemu/qemu/commit/da77adbaf619c4d170cb42d769145ad1803fbad9
  Author: Dr. David Alan Gilbert <dgilbert@redhat.com>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: Never send migration section

The audio migration vmstate is empty, and always has been; we can't
just remove it though because an old qemu might send it us.
Changes with -audiodev now mean it's sometimes created when it didn't
used to be, and can confuse migration to old qemu.

Change it so that vmstate_audio is never sent; if it's received it
should still be accepted, and old qemu's shouldn't be too upset if it's
missing.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20210809170956.78536-1-dgilbert@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6ff5b5d6d521001135d1bd5c609e8834099f01d8
      
https://github.com/qemu/qemu/commit/6ff5b5d6d521001135d1bd5c609e8834099f01d8
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl2: Check return value from g_setenv()

Setting environment variables can fail; check the return value
from g_setenv() and bail out if we couldn't set SDL_VIDEODRIVER.

Fixes: Coverity 1458798
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210809161424.32355-1-peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 02b8aeede2c61530b137bdb63cf7c998bae657f9
      
https://github.com/qemu/qemu/commit/02b8aeede2c61530b137bdb63cf7c998bae657f9
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M audio/audio.c
    M ui/gtk.c
    M ui/sdl2.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/fixes-20210810-pull-request' into staging

fixes for gtk, sdl and audio live migration.

# gpg: Signature made Tue 10 Aug 2021 13:18:30 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/fixes-20210810-pull-request:
  ui/sdl2: Check return value from g_setenv()
  audio: Never send migration section
  ui/gtk: retry sending VTE console input

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/1f3afa5da2be...02b8aeede2c6