qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5f4884: hw/nvme: fix missing variable initial


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 5f4884: hw/nvme: fix missing variable initializers
Date: Mon, 09 Aug 2021 09:05:42 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5f4884c4412318a1adc105dea9cc28f7625ce730
      
https://github.com/qemu/qemu/commit/5f4884c4412318a1adc105dea9cc28f7625ce730
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-08-09 (Mon, 09 Aug 2021)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: fix missing variable initializers

Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While
we set most of the fields, we do not explicitly set the rsvd2 field in
the NvmeIdNsDescr header.

Fix this by explicitly zero-initializing the variables.

Reported-by: Coverity (CID 1458835, 1459295 and 1459580)
Fixes: 6870cfb8140d ("hw/nvme: namespace parameter for EUI-64")
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


  Commit: 370ea52f725ab283e49b702b7bd5be73d0ff66bd
      
https://github.com/qemu/qemu/commit/370ea52f725ab283e49b702b7bd5be73d0ff66bd
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-08-09 (Mon, 09 Aug 2021)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into 
staging

hw/nvme fixes

* coverity fixes

# gpg: Signature made Mon 09 Aug 2021 11:53:42 BST
# gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
# gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [unknown]
# gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
#      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9

* remotes/nvme/tags/nvme-next-pull-request:
  hw/nvme: fix missing variable initializers

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/632eda54043d...370ea52f725a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]