[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3d98f9: qga-win: Increase VSS freeze timeout
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] 3d98f9: qga-win: Increase VSS freeze timeout to 60 secs in... |
|
Date: |
Tue, 03 Aug 2021 09:50:18 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3d98f9b68d2a8c10960d788027b8500ee947933f
https://github.com/qemu/qemu/commit/3d98f9b68d2a8c10960d788027b8500ee947933f
Author: Basil Salman <basil@daynix.com>
Date: 2021-08-02 (Mon, 02 Aug 2021)
Changed paths:
M qga/vss-win32/requester.cpp
Log Message:
-----------
qga-win: Increase VSS freeze timeout to 60 secs instead of 10
Currently Requester freeze times out after 10 seconds, while
the default timeout for Writer Freeze is 60 seconds. according to
VSS Documentation [1].
[1]:
https://docs.microsoft.com/en-us/windows/win32/vss/overview-of-processing-a-backup-under-vss
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1909073
Signed-off-by: Basil Salman <bsalman@daynix.com>
Signed-off-by: Basil Salman <basil@daynix.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: 02ac3f4b959546ad69287aae84e2d52e21aeb479
https://github.com/qemu/qemu/commit/02ac3f4b959546ad69287aae84e2d52e21aeb479
Author: Basil Salman <basil@daynix.com>
Date: 2021-08-02 (Mon, 02 Aug 2021)
Changed paths:
M qga/commands-win32.c
Log Message:
-----------
qga-win: Fix build_guest_fsinfo() close of nonexistent
On the current error path of build_guest_fsinfo(), a non existent handle
is passed to CloseHandle().
This patch adds initialization of hLocalDiskHandle to
INVALID_HANDLE_VALUE, and checks for handle validity before the handle
is closed.
Signed-off-by: Basil Salman <basil@daynix.com>
Signed-off-by: Basil Salman <basil@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: ce72f11274f6499b44aa7f2f214f6e7fc09bd9d2
https://github.com/qemu/qemu/commit/ce72f11274f6499b44aa7f2f214f6e7fc09bd9d2
Author: Basil Salman <basil@daynix.com>
Date: 2021-08-02 (Mon, 02 Aug 2021)
Changed paths:
M qga/commands-win32.c
Log Message:
-----------
qga-win: Fix handle leak in ga_get_win_product_name()
In ga_get_win_product_name() a handle to Registry key was open but not
closed.
In this patch the handle is closed as part of the free routine.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1929144
Signed-off-by: Basil Salman <basil@daynix.com>
Signed-off-by: Basil Salman <bsalman@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: 24328b7a83a43d65389eda0cbabbd67595f43b5b
https://github.com/qemu/qemu/commit/24328b7a83a43d65389eda0cbabbd67595f43b5b
Author: Kostiantyn Kostiuk <konstantin@daynix.com>
Date: 2021-08-02 (Mon, 02 Aug 2021)
Changed paths:
M qga/commands-win32.c
Log Message:
-----------
qga-win: Free GMatchInfo properly
The g_regex_match function creates match_info even if it
returns FALSE. So we should always call g_match_info_free.
A better solution is using g_autoptr for match_info variable.
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: 5f2a8b1fc1422a769e8b36f7b5e9b368f475f9c1
https://github.com/qemu/qemu/commit/5f2a8b1fc1422a769e8b36f7b5e9b368f475f9c1
Author: Gerd Hoffmann <kraxel@redhat.com>
Date: 2021-08-02 (Mon, 02 Aug 2021)
Changed paths:
M qga/installer/qemu-ga.wxs
Log Message:
-----------
qemu-ga/msi: fix w32 libgcc name
This is what I find on my Fedora 34 mingw install.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: e300858ed4a6d0cbd52b7fb5082d3c69cc371965
https://github.com/qemu/qemu/commit/e300858ed4a6d0cbd52b7fb5082d3c69cc371965
Author: Michael Roth <michael.roth@amd.com>
Date: 2021-08-03 (Tue, 03 Aug 2021)
Changed paths:
M qga/installer/qemu-ga.wxs
Log Message:
-----------
qga-win/msi: fix missing libstdc++-6 DLL in MSI installer
libstdc++ is required for the qga-vss.dll that provides fsfreeze
functionality. Currently it is not provided by the MSI installer,
resulting in fsfreeze being disabled in guest environments where it has
not been installed by other means.
In the future this would be better handled via gcc-cpp ComponentGroup
provided by msitools, but that would be better handled with a general
rework of DLL dependency handling in the installer build. Keep it
simple for now to fix this regression.
Tested with Fedora 34 mingw build environment.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kostiantyn Kostiuk <konstantin@daynix.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Commit: acf8200722251a0a995cfa75fe5c15aea0886418
https://github.com/qemu/qemu/commit/acf8200722251a0a995cfa75fe5c15aea0886418
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2021-08-03 (Tue, 03 Aug 2021)
Changed paths:
M qga/commands-win32.c
M qga/installer/qemu-ga.wxs
M qga/vss-win32/requester.cpp
Log Message:
-----------
Merge remote-tracking branch
'remotes/mdroth/tags/qga-pull-2021-08-03-pull-tag' into staging
qemu-ga patch queue for hard-freeze
* w32: Fix missing/incorrect DLLs in MSI installer
* w32: Fix memory leaks in guest-get-osinfo/guest-get-fsinfo
* w32: Increase timeout for guest-fsfreeze-freeze
# gpg: Signature made Tue 03 Aug 2021 13:09:15 BST
# gpg: using RSA key CEACC9E15534EBABB82D3FA03353C9CEF108B584
# gpg: Good signature from "Michael Roth <flukshun@gmail.com>" [full]
# gpg: aka "Michael Roth <mdroth@utexas.edu>" [full]
# gpg: aka "Michael Roth <mdroth@linux.vnet.ibm.com>" [full]
# Primary key fingerprint: CEAC C9E1 5534 EBAB B82D 3FA0 3353 C9CE F108 B584
* remotes/mdroth/tags/qga-pull-2021-08-03-pull-tag:
qga-win/msi: fix missing libstdc++-6 DLL in MSI installer
qemu-ga/msi: fix w32 libgcc name
qga-win: Free GMatchInfo properly
qga-win: Fix handle leak in ga_get_win_product_name()
qga-win: Fix build_guest_fsinfo() close of nonexistent
qga-win: Increase VSS freeze timeout to 60 secs instead of 10
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/7f1cab9c628a...acf820072225