qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] cd6c76: ui/gtk: Fix relative mouse with multi


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] cd6c76: ui/gtk: Fix relative mouse with multiple monitors
Date: Tue, 27 Jul 2021 00:34:59 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cd6c768f6a4f65a65bd44bdec0638b7fd861ceb1
      
https://github.com/qemu/qemu/commit/cd6c768f6a4f65a65bd44bdec0638b7fd861ceb1
  Author: Dennis Wölfing <denniswoelfing@gmx.de>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Fix relative mouse with multiple monitors

To handle relative mouse input the event handler needs to move the mouse
away from the screen edges. Failing to do so results in the mouse
getting stuck at invisible walls. However the current implementation for
this is broken on hosts with multiple monitors.

With multiple monitors the mouse can be located outside of the current
monitor which is not handled by the current code. Also the monitor
itself might be located at coordinates different from (0, 0).

Signed-off-by: Dennis Wölfing <denniswoelfing@gmx.de>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210720143940.291413-1-denniswoelfing@gmx.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 9a6c69d389c0492a57c439dc3babbd0f9da2555e
      
https://github.com/qemu/qemu/commit/9a6c69d389c0492a57c439dc3babbd0f9da2555e
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M ui/spice-app.c
    M ui/spice-core.c

  Log Message:
  -----------
  ui/spice: Use HAVE_SPICE_GL for OpenGL checks

Some code in ui/spice used CONFIG_OPENGL for OpenGL conditionals, but
SPICE also depends on CONFIG_GBM and SPICE server whose version is
0.13.1 or later for OpenGL. Always use HAVE_SPICE_GL, which defines the
precise condition.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210714055735.86050-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 074c0653c25bbd2f3978699099051d2343f34c57
      
https://github.com/qemu/qemu/commit/074c0653c25bbd2f3978699099051d2343f34c57
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M ui/egl-headless.c

  Log Message:
  -----------
  ui/egl-headless: Remove a check for CONFIG_OPENGL

ui/egl-headless is only built when CONFIG_OPENGL is defined because it
depends on CONFIG_OPENGL without condition. Remove a redundant
conditonal in ui/egl-headless.c

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210714055646.85952-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 40a9aadbc9900f8b50fffe485df7cc0bfb9ec01c
      
https://github.com/qemu/qemu/commit/40a9aadbc9900f8b50fffe485df7cc0bfb9ec01c
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Fix the type of main's argv

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210708165619.29299-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: d4a121048095f276913dca977bb21bcbab02c44c
      
https://github.com/qemu/qemu/commit/d4a121048095f276913dca977bb21bcbab02c44c
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M ui/keycodemapdb

  Log Message:
  -----------
  ui: update keycodemapdb submodule commit

The change of ui/keycodemapdb effective on QEMU is only commit
d21009b1c9f94b740ea66be8e48a1d8ad8124023, which adds mappings for key
codes added in commit d7696ff884e35c6dacf83a7cbe3355e3b0a90125.

d21009b1c9f94b740ea66be8e48a1d8ad8124023 Add QEMU QKeyCode "lang1" and "lang2"
320f92c36a80bfafc5d57834592a7be5fd79f104 rust: fix cargo clippy
e62d42f0fd76f7bb8bf78385a83c060e66ff52b0 tests: add rust test
3e25e1ca1772fc3f2039f739f8f920450dc68e50 gen: add --lang rust
9133a0b8022d1fb063a81cc2ba3b627c14ccdfd1 tests: fix argument order

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210705075912.2280-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 584af1f1d955476aacba3350c4efb5865fc91c09
      
https://github.com/qemu/qemu/commit/584af1f1d955476aacba3350c4efb5865fc91c09
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: add a keyboard fifo to the VTE consoles

Since commit 8eb13bbbac ("ui/gtk: vte: fix sending multiple
characeters") it's very easy to lock up QEMU with the GTK ui.
If you configure a guest with a serial device and the guest
doesn't listen on this device, QEMU will lock up after
entering two characters in the serial console. That's because
current code uses a busy loop for the chardev write retries
and the busy loop doesn't terminate in this case.

To fix this problem add a fifo to the VTE consoles and use the
chr_accept_input() callback function to write the remaining
characters in the queue to the chardev.

The fifo has a size of 4096 bytes, so one can copy and paste
a fairly large URL or file path.

Fixes: 8eb13bbbac ("ui/gtk: vte: fix sending multiple characeters")
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-Id: <20210725165039.5242-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 1f3c9c762e2a4eada649393e9527b19e048f3ba7
      
https://github.com/qemu/qemu/commit/1f3c9c762e2a4eada649393e9527b19e048f3ba7
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-26 (Mon, 26 Jul 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/cocoa.m
    M ui/egl-headless.c
    M ui/gtk.c
    M ui/keycodemapdb
    M ui/spice-app.c
    M ui/spice-core.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/fixes-20210726-pull-request' into staging

ui: fixes for 6.1

# gpg: Signature made Mon 26 Jul 2021 12:05:33 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/fixes-20210726-pull-request:
  ui/gtk: add a keyboard fifo to the VTE consoles
  ui: update keycodemapdb submodule commit
  ui/cocoa: Fix the type of main's argv
  ui/egl-headless: Remove a check for CONFIG_OPENGL
  ui/spice: Use HAVE_SPICE_GL for OpenGL checks
  ui/gtk: Fix relative mouse with multiple monitors

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/76bf66b9136c...1f3c9c762e2a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]