[Qemu-commits] [qemu/qemu] 0c95aa: hw/nvme: remove NvmeCtrl parameter from ns setup/c...

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 0c95aac21fb321d9ece9aae6af278ad972eeb506
      
https://github.com/qemu/qemu/commit/0c95aac21fb321d9ece9aae6af278ad972eeb506
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/ns.c
    M hw/nvme/nvme.h

  Log Message:
  -----------
  hw/nvme: remove NvmeCtrl parameter from ns setup/check functions

The nvme_ns_setup and nvme_ns_check_constraints should not depend on the
controller state. Refactor and remove it.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 1893b7f1f654ae0c16981ff118f2e60dce278455
      
https://github.com/qemu/qemu/commit/1893b7f1f654ae0c16981ff118f2e60dce278455
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M hw/nvme/subsys.c

  Log Message:
  -----------
  hw/nvme: mark nvme-subsys non-hotpluggable

We currently lack the infrastructure to handle subsystem hotplugging, so
disable it.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 5a814cb1485ed807b1fb5ed613a7915363ded7cc
      
https://github.com/qemu/qemu/commit/5a814cb1485ed807b1fb5ed613a7915363ded7cc
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/nvme.h
    M hw/nvme/subsys.c

  Log Message:
  -----------
  hw/nvme: unregister controller with subsystem at exit

Make sure the controller is unregistered from the subsystem when device
is removed.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: fefcae6edba6a478f9666bbe53012a8f9d756e49
      
https://github.com/qemu/qemu/commit/fefcae6edba6a478f9666bbe53012a8f9d756e49
  Author: Padmakar Kalghatgi <p.kalghatgi@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/trace-events

  Log Message:
  -----------
  hw/nvme: error handling for too many mappings

If the number of PRP/SGL mappings exceed 1024, reads and writes will
fail because of an internal QEMU limitation of max 1024 vectors.

Signed-off-by: Padmakar Kalghatgi <p.kalghatgi@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[k.jensen: changed the error message to be more generic]
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: c74d08f9ba4baf9aa3d48305c0c05669eeba7721
      
https://github.com/qemu/qemu/commit/c74d08f9ba4baf9aa3d48305c0c05669eeba7721
  Author: Gollu Appalanaidu <anaidu.gollu@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M tests/qtest/nvme-test.c

  Log Message:
  -----------
  tests/qtest/nvme-test: add persistent memory region test

This will test the PMR functionality.

Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[k.jensen: replaced memory-backend-file with memory-backend-ram]
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 9cc1a34ec4fe7e89e44e460dcf50159e40962e59
      
https://github.com/qemu/qemu/commit/9cc1a34ec4fe7e89e44e460dcf50159e40962e59
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-07-11 (Sun, 11 Jul 2021)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/ns.c
    M hw/nvme/nvme.h
    M hw/nvme/subsys.c

  Log Message:
  -----------
  hw/nvme: fix controller hot unplugging

Prior to this patch the nvme-ns devices are always children of the
NvmeBus owned by the NvmeCtrl. This causes the namespaces to be
unrealized when the parent device is removed. However, when subsystems
are involved, this is not what we want since the namespaces may be
attached to other controllers as well.

This patch adds an additional NvmeBus on the subsystem device. When
nvme-ns devices are realized, if the parent controller device is linked
to a subsystem, the parent bus is set to the subsystem one instead. This
makes sure that namespaces are kept alive and not unrealized.

Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 52858437f4e52b7f5928f59638eb172c1c4a6431
      
https://github.com/qemu/qemu/commit/52858437f4e52b7f5928f59638eb172c1c4a6431
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-07-12 (Mon, 12 Jul 2021)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/ns.c
    M hw/nvme/nvme.h
    M hw/nvme/subsys.c
    M hw/nvme/trace-events
    M tests/qtest/nvme-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into 
staging

hw/nvme patches

* new PMR test (Gollu Appalanaidu)
* pmr/sgl mapping fix (Padmakar Kalghatgi)
* hotplug fixes (me)

# gpg: Signature made Sun 11 Jul 2021 21:10:33 BST
# gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
# gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [unknown]
# gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
#      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9

* remotes/nvme/tags/nvme-next-pull-request:
  hw/nvme: fix controller hot unplugging
  tests/qtest/nvme-test: add persistent memory region test
  hw/nvme: error handling for too many mappings
  hw/nvme: unregister controller with subsystem at exit
  hw/nvme: mark nvme-subsys non-hotpluggable
  hw/nvme: remove NvmeCtrl parameter from ns setup/check functions

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/67109e298fba...52858437f4e5