[Qemu-commits] [qemu/qemu] b7f14f: Hexagon (target/hexagon) fix bug in fLSBNEW*

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: b7f14fb9718561136a1e9692b4287d994657e363
      
https://github.com/qemu/qemu/commit/b7f14fb9718561136a1e9692b4287d994657e363
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M target/hexagon/macros.h
    M target/hexagon/op_helper.c
    M tests/tcg/hexagon/misc.c

  Log Message:
  -----------
  Hexagon (target/hexagon) fix bug in fLSBNEW*

Change fLSBNEW/fLSBNEW0/fLSBNEW1 from copy to "x & 1"
Remove gen_logical_not function
Clean up fLSBNEWNOT to use andi-1 followed by xori-1

Test cases added to tests/tcg/hexagon/misc.c

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-2-git-send-email-tsimpson@quicinc.com>


  Commit: 90284fa1ec78819e2abef27da9fb1b510db2f41d
      
https://github.com/qemu/qemu/commit/90284fa1ec78819e2abef27da9fb1b510db2f41d
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M target/hexagon/gen_tcg.h
    M target/hexagon/imported/encode_pp.def
    M tests/tcg/hexagon/misc.c

  Log Message:
  -----------
  Hexagon (target/hexagon) fix l2fetch instructions

Y4_l2fetch == l2fetch(Rs32, Rt32)
Y5_l2fetch == l2fetch(Rs32, Rtt32)

The semantics for these instructions are present, but the encodings
are missing.

Note that these are treated as nops in qemu, so we add overrides.

Test case added to tests/tcg/hexagon/misc.c

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-3-git-send-email-tsimpson@quicinc.com>


  Commit: c80876c2ddc4fafaa1e9d36cf60388dbd4bc8f3a
      
https://github.com/qemu/qemu/commit/c80876c2ddc4fafaa1e9d36cf60388dbd4bc8f3a
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M target/hexagon/gen_tcg.h
    M target/hexagon/genptr.c
    M target/hexagon/macros.h

  Log Message:
  -----------
  Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions

Previously the store-conditional code was writing to hex_pred[prednum].
Then, the fGEN_TCG override was reading from there to the destination
variable so that the packet commit logic would handle it properly.

The correct implementation is to write to the destination variable
and don't have the extra read in the override.

Remove the unused arguments from gen_store_conditional[48]

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-4-git-send-email-tsimpson@quicinc.com>


  Commit: 13ce2ae03000137e1de8d40ff7ceae46fcb34cd5
      
https://github.com/qemu/qemu/commit/13ce2ae03000137e1de8d40ff7ceae46fcb34cd5
  Author: Taylor Simpson <tsimpson@quicinc.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M target/hexagon/genptr.c
    M target/hexagon/translate.c

  Log Message:
  -----------
  Hexagon (target/hexagon) remove unused TCG variables

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1622589584-22571-5-git-send-email-tsimpson@quicinc.com>


  Commit: 9faef9450f9b762eefc4047016900b4670815090
      
https://github.com/qemu/qemu/commit/9faef9450f9b762eefc4047016900b4670815090
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-06-29 (Tue, 29 Jun 2021)

  Changed paths:
    M target/hexagon/gen_tcg.h
    M target/hexagon/genptr.c
    M target/hexagon/imported/encode_pp.def
    M target/hexagon/macros.h
    M target/hexagon/op_helper.c
    M target/hexagon/translate.c
    M tests/tcg/hexagon/misc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20210618' into 
staging

Fixes for bugs found by inspection and internal testing
Tests added to tests/tcg/hexagon/misc.c

# gpg: Signature made Fri 18 Jun 2021 19:29:28 BST
# gpg:                using RSA key 7B0244FB12DE4422
# gpg: Good signature from "Taylor Simpson (Rock on) <tsimpson@quicinc.com>" 
[undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 3635 C788 CE62 B91F D4C5  9AB4 7B02 44FB 12DE 4422

* remotes/quic/tags/pull-hex-20210618:
  Hexagon (target/hexagon) remove unused TCG variables
  Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions
  Hexagon (target/hexagon) fix l2fetch instructions
  Hexagon (target/hexagon) fix bug in fLSBNEW*

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/13d5f87cc3b9...9faef9450f9b