[Qemu-commits] [qemu/qemu] ddc3c1: target/i386: kvm: add support for TSC

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] ddc3c1: target/i386: kvm: add support for TSC

From:	Peter Maydell
Subject:	[Qemu-commits] [qemu/qemu] ddc3c1: target/i386: kvm: add support for TSC scaling
Date:	Thu, 24 Jun 2021 11:52:40 -0700
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ddc3c16654664d4d219a189494a12af622450dc5
      
https://github.com/qemu/qemu/commit/ddc3c16654664d4d219a189494a12af622450dc5
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M target/i386/cpu.c
    M target/i386/cpu.h
    M target/i386/kvm/kvm.c

  Log Message:
  -----------
  target/i386: kvm: add support for TSC scaling

Linux 5.14 will add support for nested TSC scaling.  Add the
corresponding feature in QEMU; to keep support for existing kernels,
do not add it to any processor yet.

The handling of the VMCS enumeration MSR is ugly; once we have more than
one case, we may want to add a table to check VMX features against.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 134d6fc7b2e0c348e09f9621971fea89957a7b70
      
https://github.com/qemu/qemu/commit/134d6fc7b2e0c348e09f9621971fea89957a7b70
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: drop unused CONFIG_GCRYPT_HMAC

CONFIG_GCRYPT_HMAC has been removed now that all supported distros have it.

Reviewed-by: Richard Henderson <richard.henderson@liaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: a8a833d8b0bc7eb6913ff3bc87fb85c7f830397d
      
https://github.com/qemu/qemu/commit/a8a833d8b0bc7eb6913ff3bc87fb85c7f830397d
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: drop unused variables for xts

All XTS configuration uses qemu_private_xts.  Drop other variables as
they have only ever been used to generate the summary (which has since
been moved to meson.build).

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@liaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 603c152b9957f6c242723ed31356ffecdac2b037
      
https://github.com/qemu/qemu/commit/603c152b9957f6c242723ed31356ffecdac2b037
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: remove preadv from summary

Meson is more verbose than the configure script; the outcome of the preadv test
can be found in its output and it is not worth including it again in the 
summary.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 95ca74d46b89b7750be0af81168b0363b36d3d67
      
https://github.com/qemu/qemu/commit/95ca74d46b89b7750be0af81168b0363b36d3d67
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M tests/unit/crypto-tls-psk-helpers.c
    M tests/unit/crypto-tls-psk-helpers.h
    M tests/unit/crypto-tls-x509-helpers.c
    M tests/unit/crypto-tls-x509-helpers.h
    M tests/unit/pkix_asn1_tab.c
    M tests/unit/test-crypto-tlscredsx509.c
    M tests/unit/test-crypto-tlssession.c
    M tests/unit/test-io-channel-tls.c

  Log Message:
  -----------
  tests: remove QCRYPTO_HAVE_TLS_TEST_SUPPORT

meson.build already decides whether it is possible to build the TLS
test suite.  There is no need to include that in the source as well.
The dummy tests in fact are broken because they do not produce valid
TAP output (empty output is rejected by scripts/tap-driver.pl).

Cc: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 866f480134c742edd741c9093b71ccea922d19f1
      
https://github.com/qemu/qemu/commit/866f480134c742edd741c9093b71ccea922d19f1
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure
    M crypto/meson.build
    M meson.build
    M meson_options.txt
    M tests/unit/meson.build

  Log Message:
  -----------
  configure, meson: convert crypto detection to meson

Reviewed-by: Richard Henderson <richard.henderson@liaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 79f6ae6ddd4ac058d65ff3bf3899a9601974952a
      
https://github.com/qemu/qemu/commit/79f6ae6ddd4ac058d65ff3bf3899a9601974952a
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure
    M meson.build
    M tests/unit/meson.build

  Log Message:
  -----------
  configure, meson: convert libtasn1 detection to meson

Make it depend on gnutls too, since it is only used as part of gnutls
tests.

Reviewed-by: Richard Henderson <richard.henderson@liaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 46a9e24711914150984530e690f027efa4f263c8
      
https://github.com/qemu/qemu/commit/46a9e24711914150984530e690f027efa4f263c8
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M authz/meson.build
    M configure
    M meson.build
    M meson_options.txt
    M tests/unit/meson.build

  Log Message:
  -----------
  configure, meson: convert pam detection to meson

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 5d5cd9e5fb86f6a5950481dd41a4ca3a23ab0b89
      
https://github.com/qemu/qemu/commit/5d5cd9e5fb86f6a5950481dd41a4ca3a23ab0b89
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure
    M hw/usb/meson.build
    M meson.build
    M meson_options.txt

  Log Message:
  -----------
  configure, meson: convert libusb detection to meson

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 0ad2bc00fa85e1c181641578bcb09385b7da813d
      
https://github.com/qemu/qemu/commit/0ad2bc00fa85e1c181641578bcb09385b7da813d
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure
    M hw/usb/meson.build
    M meson.build
    M meson_options.txt

  Log Message:
  -----------
  configure, meson: convert libcacard detection to meson

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 233dc8e620fd591d6cdc294ac9646b9d4ee645de
      
https://github.com/qemu/qemu/commit/233dc8e620fd591d6cdc294ac9646b9d4ee645de
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M configure
    M hw/usb/meson.build
    M meson.build
    M meson_options.txt

  Log Message:
  -----------
  configure, meson: convert libusbredir detection to meson

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 0f38448da7ab61a23fc35f57276a7272d6e4d984
      
https://github.com/qemu/qemu/commit/0f38448da7ab61a23fc35f57276a7272d6e4d984
  Author: Peter Xu <peterx@redhat.com>
  Date:   2021-06-23 (Wed, 23 Jun 2021)

  Changed paths:
    M accel/kvm/kvm-all.c

  Log Message:
  -----------
  KVM: Fix dirty ring mmap incorrect size due to renaming accident

Found this when I wanted to try the per-vcpu dirty rate series out, then I
found that it's not really working and it can quickly hang death a guest.  I
found strange errors (e.g. guest crash after migration) happens even without
the per-vcpu dirty rate series.

When merging dirty ring, probably no one notice that the trivial renaming diff
[1] missed two existing references of kvm_dirty_ring_sizes; they do matter
since otherwise we'll mmap() a shorter range of memory after the renaming.

I think it didn't SIGBUS for me easily simply because some other stuff within
qemu mmap()ed right after the dirty rings (e.g. when testing 4096 slots, it
aligned with one small page on x86), so when we access the rings we've been
reading/writting to random memory elsewhere of qemu.

Fix the two sizes when map/unmap the shared dirty gfn memory.

[1] 
https://lore.kernel.org/qemu-devel/dac5f0c6-1bca-3daf-e5d2-6451dbbaca93@redhat.com/

Cc: Hyman Huang <huangy81@chinatelecom.cn>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20210609014355.217110-1-peterx@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 91e6c53e641f5b99976baca2c8e99691be89614a
      
https://github.com/qemu/qemu/commit/91e6c53e641f5b99976baca2c8e99691be89614a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-06-24 (Thu, 24 Jun 2021)

  Changed paths:
    M accel/kvm/kvm-all.c
    M authz/meson.build
    M configure
    M crypto/meson.build
    M hw/usb/meson.build
    M meson.build
    M meson_options.txt
    M target/i386/cpu.c
    M target/i386/cpu.h
    M target/i386/kvm/kvm.c
    M tests/unit/crypto-tls-psk-helpers.c
    M tests/unit/crypto-tls-psk-helpers.h
    M tests/unit/crypto-tls-x509-helpers.c
    M tests/unit/crypto-tls-x509-helpers.h
    M tests/unit/meson.build
    M tests/unit/pkix_asn1_tab.c
    M tests/unit/test-crypto-tlscredsx509.c
    M tests/unit/test-crypto-tlssession.c
    M tests/unit/test-io-channel-tls.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into 
staging

* Some Meson test conversions
* KVM dirty page ring buffer fix
* KVM TSC scaling support

# gpg: Signature made Wed 23 Jun 2021 11:21:08 BST
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [full]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* remotes/bonzini-gitlab/tags/for-upstream:
  KVM: Fix dirty ring mmap incorrect size due to renaming accident
  configure, meson: convert libusbredir detection to meson
  configure, meson: convert libcacard detection to meson
  configure, meson: convert libusb detection to meson
  configure, meson: convert pam detection to meson
  configure, meson: convert libtasn1 detection to meson
  configure, meson: convert crypto detection to meson
  tests: remove QCRYPTO_HAVE_TLS_TEST_SUPPORT
  meson: remove preadv from summary
  configure: drop unused variables for xts
  meson: drop unused CONFIG_GCRYPT_HMAC
  target/i386: kvm: add support for TSC scaling

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/ecba223da621...91e6c53e641f
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] ddc3c1: target/i386: kvm: add support for TSC scaling, Peter Maydell <=
Prev by Date: [Qemu-commits] [qemu/qemu] 82faef: hw/acpi: Provide stub version of acpi_ghes_record_...
Next by Date: [Qemu-commits] [qemu/qemu] 15280e: ui/cocoa: Set UI information
Previous by thread: [Qemu-commits] [qemu/qemu] 385487: target/arm: Implement MVE VRMLALDAVH, VRMLSLDAVH
Next by thread: [Qemu-commits] [qemu/qemu] 15280e: ui/cocoa: Set UI information
Index(es):
- Date
- Thread