[Qemu-commits] [qemu/qemu] 2a5781: docs/devel: Add VFIO device migration documentation

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 2a5781331a08628fa5d5a0e9a5ea415ce462e707
      
https://github.com/qemu/qemu/commit/2a5781331a08628fa5d5a0e9a5ea415ce462e707
  Author: Tarun Gupta <targupta@nvidia.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M MAINTAINERS
    M docs/devel/index.rst
    A docs/devel/vfio-migration.rst

  Log Message:
  -----------
  docs/devel: Add VFIO device migration documentation

Document interfaces used for VFIO device migration. Added flow
of state changes during live migration with VFIO device.

Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Co-developed-by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Tarun Gupta <targupta@nvidia.com>
Message-Id: <20210418122251.88809-1-targupta@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>


  Commit: 22fca190e25b10761925bb1eeadeda07aabf3c26
      
https://github.com/qemu/qemu/commit/22fca190e25b10761925bb1eeadeda07aabf3c26
  Author: Kunkun Jiang <jiangkunkun@huawei.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M hw/vfio/migration.c

  Log Message:
  -----------
  vfio: Fix unregister SaveVMHandler in vfio_migration_finalize

In the vfio_migration_init(), the SaveVMHandler is registered for
VFIO device. But it lacks the operation of 'unregister'. It will
lead to 'Segmentation fault (core dumped)' in
qemu_savevm_state_setup(), if performing live migration after a
VFIO device is hot deleted.

Fixes: 7c2f5f75f94 (vfio: Register SaveVMHandlers for VFIO device)
Reported-by: Qixin Gan <ganqixin@huawei.com>
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
Message-Id: <20210527123101.289-1-jiangkunkun@huawei.com>
Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>


  Commit: d742d064c1f541ac8ad6541e248a97f2dc502721
      
https://github.com/qemu/qemu/commit/d742d064c1f541ac8ad6541e248a97f2dc502721
  Author: Kirti Wankhede <kwankhede@nvidia.com>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M hw/vfio/migration.c

  Log Message:
  -----------
  vfio/migration: Correct device state from vmstate change for savevm case

Set _SAVING flag for device state from vmstate change handler when it
gets called from savevm.

Currently State transition savevm/suspend is seen as:
    _RUNNING -> _STOP -> Stop-and-copy -> _STOP

State transition savevm/suspend should be:
    _RUNNING -> Stop-and-copy -> _STOP

State transition from _RUNNING to _STOP occurs from
vfio_vmstate_change() where when vmstate changes from running to
!running, _RUNNING flag is reset but at the same time when
vfio_vmstate_change() is called for RUN_STATE_SAVE_VM, _SAVING bit
should be set.

Reported by: Yishai Hadas <yishaih@nvidia.com>
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
Message-Id: <1623177441-27496-1-git-send-email-kwankhede@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>


  Commit: 8f521741e1280f0957ac1b873292c19219e1fb9a
      
https://github.com/qemu/qemu/commit/8f521741e1280f0957ac1b873292c19219e1fb9a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-06-18 (Fri, 18 Jun 2021)

  Changed paths:
    M MAINTAINERS
    M docs/devel/index.rst
    A docs/devel/vfio-migration.rst
    M hw/vfio/migration.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20210618.0' 
into staging

VFIO update 2021-06-18

 * VFIO migration documentation (Tarun Gupta)

 * Fix SaveVMHandler de-registration (Kunkun Jiang)

 * Fix vmstate change transition (Kirti Wankhede)

# gpg: Signature made Fri 18 Jun 2021 16:20:34 BST
# gpg:                using RSA key 42F6C04E540BD1A99E7B8A90239B9B6E3BB08B22
# gpg:                issuer "alex.williamson@redhat.com"
# gpg: Good signature from "Alex Williamson <alex.williamson@redhat.com>" [full]
# gpg:                 aka "Alex Williamson <alex@shazbot.org>" [full]
# gpg:                 aka "Alex Williamson <alwillia@redhat.com>" [full]
# gpg:                 aka "Alex Williamson <alex.l.williamson@gmail.com>" 
[full]
# Primary key fingerprint: 42F6 C04E 540B D1A9 9E7B  8A90 239B 9B6E 3BB0 8B22

* remotes/awilliam/tags/vfio-update-20210618.0:
  vfio/migration: Correct device state from vmstate change for savevm case
  vfio: Fix unregister SaveVMHandler in vfio_migration_finalize
  docs/devel: Add VFIO device migration documentation

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3ccf6cd0e3e1...8f521741e128