qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 05ece9: vga: Allow writing VBE_DISPI_ID5 to I


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 05ece9: vga: Allow writing VBE_DISPI_ID5 to ID register
Date: Wed, 16 Jun 2021 06:33:15 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 05ece98f965997649b8d922d224240459bcc1403
      
https://github.com/qemu/qemu/commit/05ece98f965997649b8d922d224240459bcc1403
  Author: Dennis Wölfing <denniswoelfing@gmx.de>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M hw/display/vga.c

  Log Message:
  -----------
  vga: Allow writing VBE_DISPI_ID5 to ID register

The highest VBE_DISPI_INDEX_ID version supported by QEMU is
VBE_DISPI_ID5. But currently QEMU only allows writing values up to
VBE_DISPI_ID4 to the VBE_DISPI_INDEX_ID register.

As a result of this when a lower version is written to this register and
later VBE_DISPI_ID5 is written back, reads from the register will
continue to report the lower version.

Indeed SeaBIOS is doing that during VGA initialization which causes
guests to always read VBE_DISPI_ID0 instead of the correct version.

Signed-off-by: Dennis Wölfing <denniswoelfing@gmx.de>
Message-Id: <20210607115303.228659-1-denniswoelfing@gmx.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd
      
https://github.com/qemu/qemu/commit/25b2ef2e8ee23109b0c3ce9ea71330bf8a7d12bd
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M contrib/vhost-user-gpu/vhost-user-gpu.c

  Log Message:
  -----------
  vhost-user-gpu: reorder free calls.

Free in correct order to avoid use-after-free.

Resolves: CID 1453812
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210604103714.1237414-1-kraxel@redhat.com>


  Commit: 4fa7b4cc500e1fbd8c11e65548b7713db81e75ff
      
https://github.com/qemu/qemu/commit/4fa7b4cc500e1fbd8c11e65548b7713db81e75ff
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-06-15 (Tue, 15 Jun 2021)

  Changed paths:
    M hw/display/virtio-gpu.c

  Log Message:
  -----------
  virtio-gpu: move scanout_id sanity check

Checking scanout_id in virtio_gpu_do_set_scanout() is too late, for the
"resource_id == 0" case (aka disable scanout) the scanout_id is used
unchecked.  Move the check into the callers to fix that.

Fixes: e64d4b6a9bc3 ("virtio-gpu: Refactor virtio_gpu_set_scanout")
Fixes: 32db3c63ae11 ("virtio-gpu: Add virtio_gpu_set_scanout_blob")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/383
Reported-by: Alexander Bulekov <alxndr@bu.edu>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Vivek Kasireddy <vivek.kasireddy@intel.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20210604075029.1201478-1-kraxel@redhat.com>


  Commit: e3897b75fd2ac8c4bfda95d60309cb6414da8000
      
https://github.com/qemu/qemu/commit/e3897b75fd2ac8c4bfda95d60309cb6414da8000
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-06-16 (Wed, 16 Jun 2021)

  Changed paths:
    M contrib/vhost-user-gpu/vhost-user-gpu.c
    M hw/display/vga.c
    M hw/display/virtio-gpu.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20210615-pull-request' 
into staging

vga: fixes for stdvga, vhost-user-gpu and virtio-gpu.

# gpg: Signature made Tue 15 Jun 2021 18:40:11 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20210615-pull-request:
  virtio-gpu: move scanout_id sanity check
  vhost-user-gpu: reorder free calls.
  vga: Allow writing VBE_DISPI_ID5 to ID register

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3363c3baed5b...e3897b75fd2a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]