qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] f9c481: hw/input/hid: Add support for keys of


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] f9c481: hw/input/hid: Add support for keys of jp106 keyboard.
Date: Sun, 30 May 2021 12:10:56 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: f9c481247f6a2c87439e0ebfa42cd56325db2ac0
      
https://github.com/qemu/qemu/commit/f9c481247f6a2c87439e0ebfa42cd56325db2ac0
  Author: Katsuhiro Ueno <uenobk@gmail.com>
  Date:   2021-05-28 (Fri, 28 May 2021)

  Changed paths:
    M hw/input/hid.c

  Log Message:
  -----------
  hw/input/hid: Add support for keys of jp106 keyboard.

Add support for the following keys: KATAKANAHIRAGANA, HENKAN, MUHENKAN,
RO, and YEN.  Before this commit, these keys did not work as expected
when a jp106 keyboard was connected to the guest as a usb-kbd device.

Signed-off-by: Katsuhiro Ueno <uenobk@gmail.com>
Message-Id: <CA+pCdY3iG+pKKQqEVknnWF-W0wK36S4U1jxPvxmGAPp6FFvz1Q@mail.gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 3c6151cd11ae7e4a7dae10f8c17ab1fe2f0a73bf
      
https://github.com/qemu/qemu/commit/3c6151cd11ae7e4a7dae10f8c17ab1fe2f0a73bf
  Author: Ruimei Yan <ruimei.yan@windriver.com>
  Date:   2021-05-28 (Fri, 28 May 2021)

  Changed paths:
    M hw/usb/hcd-xhci-pci.c

  Log Message:
  -----------
  hw/usb: hcd-xhci-pci: Raise MSI/MSI-X interrupts only when told to

At present MSI / MSI-X interrupts are triggered regardless of the
irq level. We should have checked the level to determine whether
the interrupt needs to be delivered.

The level check logic was present in early versions of the xhci
model, but got dropped later by a rework of interrupt handling
under commit 4c4abe7cc903 ("xhci: rework interrupt handling").

Fixes: 4c4abe7cc903 ("xhci: rework interrupt handling")
Signed-off-by: Ruimei Yan <ruimei.yan@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210521024224.2277634-1-bmeng.cn@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: fc967aad408eb4777b099d17ada1f39be5f6fd2e
      
https://github.com/qemu/qemu/commit/fc967aad408eb4777b099d17ada1f39be5f6fd2e
  Author: Ruimei Yan <ruimei.yan@windriver.com>
  Date:   2021-05-28 (Fri, 28 May 2021)

  Changed paths:
    M hw/usb/hcd-xhci-pci.c
    M hw/usb/hcd-xhci-sysbus.c
    M hw/usb/hcd-xhci.c
    M hw/usb/hcd-xhci.h

  Log Message:
  -----------
  hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X

Per xHCI spec v1.2 chapter 4.17.5 page 296:

  If MSI or MSI-X interrupts are enabled, Interrupt Pending (IP)
  shall be cleared automatically when the PCI dword write generated
  by the interrupt assertion is complete.

Currently QEMU does not clear the IP flag in the MSI / MSI-X mode.
This causes subsequent spurious interrupt to be delivered to guests.
To solve this, we change the xhci intr_raise() hook routine to have
a bool return value that is passed to its caller (the xhci core),
with true indicating that IP should be self-cleared.

Fixes: 62c6ae04cf43 ("xhci: Initial xHCI implementation")
Fixes: 4c47f800631a ("xhci: add msix support")
Signed-off-by: Ruimei Yan <ruimei.yan@windriver.com>
[bmeng: move IP clear codes from xhci pci to xhci core]
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Message-Id: <20210521024224.2277634-2-bmeng.cn@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 52848929b70dcf92a68aedcfd90207be81ba3274
      
https://github.com/qemu/qemu/commit/52848929b70dcf92a68aedcfd90207be81ba3274
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-05-30 (Sun, 30 May 2021)

  Changed paths:
    M hw/input/hid.c
    M hw/usb/hcd-xhci-pci.c
    M hw/usb/hcd-xhci-sysbus.c
    M hw/usb/hcd-xhci.c
    M hw/usb/hcd-xhci.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210528-pull-request' 
into staging

usb: bugfixes for hid and xhci.

# gpg: Signature made Fri 28 May 2021 15:21:51 BST
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20210528-pull-request:
  hw/usb: hcd-xhci-pci: Fix spec violation of IP flag for MSI/MSI-X
  hw/usb: hcd-xhci-pci: Raise MSI/MSI-X interrupts only when told to
  hw/input/hid: Add support for keys of jp106 keyboard.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/6da21b306246...52848929b70d



reply via email to

[Prev in Thread] Current Thread [Next in Thread]