[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] a67b99: monitor/qmp: fix race on CHR_EVENT_CL
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] a67b99: monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB |
|
Date: |
Fri, 14 May 2021 02:05:13 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: a67b996e7894edfafbcd3fd007c9f58f26d25908
https://github.com/qemu/qemu/commit/a67b996e7894edfafbcd3fd007c9f58f26d25908
Author: Stefan Reiter <s.reiter@proxmox.com>
Date: 2021-05-12 (Wed, 12 May 2021)
Changed paths:
M monitor/qmp.c
Log Message:
-----------
monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB
The QMP dispatcher coroutine holds the qmp_queue_lock over a yield
point, where it expects to be rescheduled from the main context. If a
CHR_EVENT_CLOSED event is received just then, it can race and block the
main thread on the mutex in monitor_qmp_cleanup_queue_and_resume.
monitor_resume does not need to be called from main context, so we can
call it immediately after popping a request from the queue, which allows
us to drop the qmp_queue_lock mutex before yielding.
Suggested-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Message-Id: <20210322154024.15011-1-s.reiter@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 875bb7e35b78c609252187dc7bd68d90bf742da9
https://github.com/qemu/qemu/commit/875bb7e35b78c609252187dc7bd68d90bf742da9
Author: Thomas Huth <thuth@redhat.com>
Date: 2021-05-12 (Wed, 12 May 2021)
Changed paths:
M .gitlab-ci.yml
M MAINTAINERS
R default-configs/devices/moxie-softmmu.mak
R default-configs/targets/moxie-softmmu.mak
M disas/meson.build
R disas/moxie.c
M docs/system/deprecated.rst
M docs/system/removed-features.rst
M fpu/softfloat-specialize.c.inc
M hw/Kconfig
M hw/meson.build
R hw/moxie/Kconfig
R hw/moxie/meson.build
R hw/moxie/moxiesim.c
M include/disas/dis-asm.h
M include/elf.h
M include/exec/poison.h
M include/hw/elf_ops.h
M include/sysemu/arch_init.h
M meson.build
M qapi/machine.json
M qapi/misc-target.json
M softmmu/arch_init.c
M target/meson.build
R target/moxie/cpu-param.h
R target/moxie/cpu.c
R target/moxie/cpu.h
R target/moxie/helper.c
R target/moxie/helper.h
R target/moxie/machine.c
R target/moxie/machine.h
R target/moxie/meson.build
R target/moxie/mmu.c
R target/moxie/mmu.h
R target/moxie/translate.c
M tests/qtest/boot-serial-test.c
M tests/qtest/machine-none-test.c
M tests/qtest/meson.build
Log Message:
-----------
Remove the deprecated moxie target
There are no known users of this CPU anymore, and there are no
binaries available online which could be used for regression tests,
so the code has likely completely bit-rotten already. It's been
marked as deprecated since two releases now and nobody spoke up
that there is still a need to keep it, thus let's remove it now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210430160355.698194-1-thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
[Commit message typos fixed, trivial conflicts resolved]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Commit: 09ec85176e4095be15f233ebc870d5680123f024
https://github.com/qemu/qemu/commit/09ec85176e4095be15f233ebc870d5680123f024
Author: Markus Armbruster <armbru@redhat.com>
Date: 2021-05-12 (Wed, 12 May 2021)
Changed paths:
M .gitlab-ci.yml
M MAINTAINERS
M block/meson.build
R block/sheepdog.c
M block/trace-events
M configure
M docs/system/deprecated.rst
M docs/system/device-url-syntax.rst.inc
M docs/system/qemu-block-drivers.rst.inc
M docs/system/removed-features.rst
M meson.build
M qapi/block-core.json
M qapi/transaction.json
M tests/qemu-iotests/005
M tests/qemu-iotests/025
M tests/qemu-iotests/check
M tests/qemu-iotests/common.rc
Log Message:
-----------
block: Drop the sheepdog block driver
It was deprecated in commit e1c4269763, v5.2.0. See that commit
message for rationale.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210501075747.3293186-1-armbru@redhat.com>
ACKed-by: Peter Krempa <pkrempa@redhat.com>
Commit: 9d49bcf6992a2ba77f79d2512e23b8ca26d72f6a
https://github.com/qemu/qemu/commit/9d49bcf6992a2ba77f79d2512e23b8ca26d72f6a
Author: Markus Armbruster <armbru@redhat.com>
Date: 2021-05-12 (Wed, 12 May 2021)
Changed paths:
M .gitlab-ci.yml
M MAINTAINERS
M configure
R default-configs/devices/lm32-softmmu.mak
R default-configs/targets/lm32-softmmu.mak
R disas/lm32.c
M disas/meson.build
M docs/system/deprecated.rst
M docs/system/removed-features.rst
M fpu/softfloat-specialize.c.inc
M hw/Kconfig
M hw/audio/meson.build
R hw/audio/milkymist-ac97.c
M hw/audio/trace-events
R hw/char/lm32_juart.c
R hw/char/lm32_uart.c
M hw/char/meson.build
R hw/char/milkymist-uart.c
M hw/char/trace-events
M hw/display/Kconfig
M hw/display/meson.build
R hw/display/milkymist-tmu2.c
R hw/display/milkymist-vgafb.c
R hw/display/milkymist-vgafb_template.h
M hw/display/trace-events
M hw/input/meson.build
R hw/input/milkymist-softusb.c
M hw/input/trace-events
R hw/intc/lm32_pic.c
M hw/intc/meson.build
M hw/intc/trace-events
R hw/lm32/Kconfig
R hw/lm32/lm32.h
R hw/lm32/lm32_boards.c
R hw/lm32/lm32_hwsetup.h
R hw/lm32/meson.build
R hw/lm32/milkymist-hw.h
R hw/lm32/milkymist.c
M hw/meson.build
M hw/misc/meson.build
R hw/misc/milkymist-hpdmc.c
R hw/misc/milkymist-pfpu.c
M hw/misc/trace-events
M hw/net/meson.build
R hw/net/milkymist-minimac2.c
M hw/net/trace-events
M hw/sd/meson.build
R hw/sd/milkymist-memcard.c
M hw/sd/trace-events
R hw/timer/lm32_timer.c
M hw/timer/meson.build
R hw/timer/milkymist-sysctl.c
M hw/timer/trace-events
M hw/usb/quirks-ftdi-ids.h
M hw/usb/quirks.h
M include/disas/dis-asm.h
M include/exec/poison.h
R include/hw/char/lm32_juart.h
R include/hw/display/milkymist_tmu2.h
R include/hw/lm32/lm32_pic.h
M include/sysemu/arch_init.h
M meson.build
M qapi/machine.json
M qemu-options.hx
M softmmu/arch_init.c
R target/lm32/README
R target/lm32/TODO
R target/lm32/cpu-param.h
R target/lm32/cpu-qom.h
R target/lm32/cpu.c
R target/lm32/cpu.h
R target/lm32/gdbstub.c
R target/lm32/helper.c
R target/lm32/helper.h
R target/lm32/lm32-semi.c
R target/lm32/machine.c
R target/lm32/meson.build
R target/lm32/op_helper.c
R target/lm32/translate.c
M target/meson.build
M tests/qtest/machine-none-test.c
M tests/tcg/README
M tests/tcg/configure.sh
R tests/tcg/lm32/Makefile
R tests/tcg/lm32/crt.S
R tests/tcg/lm32/helper.S
R tests/tcg/lm32/linker.ld
R tests/tcg/lm32/macros.inc
R tests/tcg/lm32/test_add.S
R tests/tcg/lm32/test_addi.S
R tests/tcg/lm32/test_and.S
R tests/tcg/lm32/test_andhi.S
R tests/tcg/lm32/test_andi.S
R tests/tcg/lm32/test_b.S
R tests/tcg/lm32/test_be.S
R tests/tcg/lm32/test_bg.S
R tests/tcg/lm32/test_bge.S
R tests/tcg/lm32/test_bgeu.S
R tests/tcg/lm32/test_bgu.S
R tests/tcg/lm32/test_bi.S
R tests/tcg/lm32/test_bne.S
R tests/tcg/lm32/test_break.S
R tests/tcg/lm32/test_bret.S
R tests/tcg/lm32/test_call.S
R tests/tcg/lm32/test_calli.S
R tests/tcg/lm32/test_cmpe.S
R tests/tcg/lm32/test_cmpei.S
R tests/tcg/lm32/test_cmpg.S
R tests/tcg/lm32/test_cmpge.S
R tests/tcg/lm32/test_cmpgei.S
R tests/tcg/lm32/test_cmpgeu.S
R tests/tcg/lm32/test_cmpgeui.S
R tests/tcg/lm32/test_cmpgi.S
R tests/tcg/lm32/test_cmpgu.S
R tests/tcg/lm32/test_cmpgui.S
R tests/tcg/lm32/test_cmpne.S
R tests/tcg/lm32/test_cmpnei.S
R tests/tcg/lm32/test_divu.S
R tests/tcg/lm32/test_eret.S
R tests/tcg/lm32/test_lb.S
R tests/tcg/lm32/test_lbu.S
R tests/tcg/lm32/test_lh.S
R tests/tcg/lm32/test_lhu.S
R tests/tcg/lm32/test_lw.S
R tests/tcg/lm32/test_modu.S
R tests/tcg/lm32/test_mul.S
R tests/tcg/lm32/test_muli.S
R tests/tcg/lm32/test_nor.S
R tests/tcg/lm32/test_nori.S
R tests/tcg/lm32/test_or.S
R tests/tcg/lm32/test_orhi.S
R tests/tcg/lm32/test_ori.S
R tests/tcg/lm32/test_ret.S
R tests/tcg/lm32/test_sb.S
R tests/tcg/lm32/test_scall.S
R tests/tcg/lm32/test_sextb.S
R tests/tcg/lm32/test_sexth.S
R tests/tcg/lm32/test_sh.S
R tests/tcg/lm32/test_sl.S
R tests/tcg/lm32/test_sli.S
R tests/tcg/lm32/test_sr.S
R tests/tcg/lm32/test_sri.S
R tests/tcg/lm32/test_sru.S
R tests/tcg/lm32/test_srui.S
R tests/tcg/lm32/test_sub.S
R tests/tcg/lm32/test_sw.S
R tests/tcg/lm32/test_xnor.S
R tests/tcg/lm32/test_xnori.S
R tests/tcg/lm32/test_xor.S
R tests/tcg/lm32/test_xori.S
Log Message:
-----------
Drop the deprecated lm32 target
Target lm32 was deprecated in commit d8498005122, v5.2.0. See there
for rationale.
Some of its code lives on in device models derived from milkymist
ones: hw/char/digic-uart.c and hw/display/bcm2835_fb.c.
Cc: Michael Walle <michael@walle.cc>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210503084034.3804963-2-armbru@redhat.com>
Acked-by: Michael Walle <michael@walle.cc>
[Trivial conflicts resolved, reST markup fixed]
Commit: 4369223902a79b7fc56ca076d99b88ff14964ddd
https://github.com/qemu/qemu/commit/4369223902a79b7fc56ca076d99b88ff14964ddd
Author: Markus Armbruster <armbru@redhat.com>
Date: 2021-05-12 (Wed, 12 May 2021)
Changed paths:
M .gitlab-ci.yml
M MAINTAINERS
M configure
R default-configs/devices/unicore32-softmmu.mak
R default-configs/targets/unicore32-softmmu.mak
M docs/system/deprecated.rst
M docs/system/removed-features.rst
M fpu/softfloat-specialize.c.inc
M hw/Kconfig
M hw/dma/meson.build
R hw/dma/puv3_dma.c
M hw/gpio/meson.build
R hw/gpio/puv3_gpio.c
M hw/intc/meson.build
R hw/intc/puv3_intc.c
M hw/meson.build
M hw/misc/meson.build
R hw/misc/puv3_pm.c
M hw/timer/meson.build
R hw/timer/puv3_ost.c
R hw/unicore32/Kconfig
R hw/unicore32/meson.build
R hw/unicore32/puv3.c
M include/elf.h
M include/exec/poison.h
R include/hw/unicore32/puv3.h
M include/sysemu/arch_init.h
M qapi/machine.json
M softmmu/arch_init.c
M target/meson.build
R target/unicore32/cpu-param.h
R target/unicore32/cpu-qom.h
R target/unicore32/cpu.c
R target/unicore32/cpu.h
R target/unicore32/helper.c
R target/unicore32/helper.h
R target/unicore32/meson.build
R target/unicore32/op_helper.c
R target/unicore32/softmmu.c
R target/unicore32/translate.c
R target/unicore32/ucf64_helper.c
M tests/qtest/machine-none-test.c
Log Message:
-----------
Drop the deprecated unicore32 target
Target unicore32 was deprecated in commit 8e4ff4a8d2b, v5.2.0. See
there for rationale.
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210503084034.3804963-3-armbru@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Commit: 2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426
https://github.com/qemu/qemu/commit/2d3fc4e2b069494b1e9e2e4a1e3de24cbc036426
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2021-05-13 (Thu, 13 May 2021)
Changed paths:
M .gitlab-ci.yml
M MAINTAINERS
M block/meson.build
R block/sheepdog.c
M block/trace-events
M configure
R default-configs/devices/lm32-softmmu.mak
R default-configs/devices/moxie-softmmu.mak
R default-configs/devices/unicore32-softmmu.mak
R default-configs/targets/lm32-softmmu.mak
R default-configs/targets/moxie-softmmu.mak
R default-configs/targets/unicore32-softmmu.mak
R disas/lm32.c
M disas/meson.build
R disas/moxie.c
M docs/system/deprecated.rst
M docs/system/device-url-syntax.rst.inc
M docs/system/qemu-block-drivers.rst.inc
M docs/system/removed-features.rst
M fpu/softfloat-specialize.c.inc
M hw/Kconfig
M hw/audio/meson.build
R hw/audio/milkymist-ac97.c
M hw/audio/trace-events
R hw/char/lm32_juart.c
R hw/char/lm32_uart.c
M hw/char/meson.build
R hw/char/milkymist-uart.c
M hw/char/trace-events
M hw/display/Kconfig
M hw/display/meson.build
R hw/display/milkymist-tmu2.c
R hw/display/milkymist-vgafb.c
R hw/display/milkymist-vgafb_template.h
M hw/display/trace-events
M hw/dma/meson.build
R hw/dma/puv3_dma.c
M hw/gpio/meson.build
R hw/gpio/puv3_gpio.c
M hw/input/meson.build
R hw/input/milkymist-softusb.c
M hw/input/trace-events
R hw/intc/lm32_pic.c
M hw/intc/meson.build
R hw/intc/puv3_intc.c
M hw/intc/trace-events
R hw/lm32/Kconfig
R hw/lm32/lm32.h
R hw/lm32/lm32_boards.c
R hw/lm32/lm32_hwsetup.h
R hw/lm32/meson.build
R hw/lm32/milkymist-hw.h
R hw/lm32/milkymist.c
M hw/meson.build
M hw/misc/meson.build
R hw/misc/milkymist-hpdmc.c
R hw/misc/milkymist-pfpu.c
R hw/misc/puv3_pm.c
M hw/misc/trace-events
R hw/moxie/Kconfig
R hw/moxie/meson.build
R hw/moxie/moxiesim.c
M hw/net/meson.build
R hw/net/milkymist-minimac2.c
M hw/net/trace-events
M hw/sd/meson.build
R hw/sd/milkymist-memcard.c
M hw/sd/trace-events
R hw/timer/lm32_timer.c
M hw/timer/meson.build
R hw/timer/milkymist-sysctl.c
R hw/timer/puv3_ost.c
M hw/timer/trace-events
R hw/unicore32/Kconfig
R hw/unicore32/meson.build
R hw/unicore32/puv3.c
M hw/usb/quirks-ftdi-ids.h
M hw/usb/quirks.h
M include/disas/dis-asm.h
M include/elf.h
M include/exec/poison.h
R include/hw/char/lm32_juart.h
R include/hw/display/milkymist_tmu2.h
M include/hw/elf_ops.h
R include/hw/lm32/lm32_pic.h
R include/hw/unicore32/puv3.h
M include/sysemu/arch_init.h
M meson.build
M monitor/qmp.c
M qapi/block-core.json
M qapi/machine.json
M qapi/misc-target.json
M qapi/transaction.json
M qemu-options.hx
M softmmu/arch_init.c
R target/lm32/README
R target/lm32/TODO
R target/lm32/cpu-param.h
R target/lm32/cpu-qom.h
R target/lm32/cpu.c
R target/lm32/cpu.h
R target/lm32/gdbstub.c
R target/lm32/helper.c
R target/lm32/helper.h
R target/lm32/lm32-semi.c
R target/lm32/machine.c
R target/lm32/meson.build
R target/lm32/op_helper.c
R target/lm32/translate.c
M target/meson.build
R target/moxie/cpu-param.h
R target/moxie/cpu.c
R target/moxie/cpu.h
R target/moxie/helper.c
R target/moxie/helper.h
R target/moxie/machine.c
R target/moxie/machine.h
R target/moxie/meson.build
R target/moxie/mmu.c
R target/moxie/mmu.h
R target/moxie/translate.c
R target/unicore32/cpu-param.h
R target/unicore32/cpu-qom.h
R target/unicore32/cpu.c
R target/unicore32/cpu.h
R target/unicore32/helper.c
R target/unicore32/helper.h
R target/unicore32/meson.build
R target/unicore32/op_helper.c
R target/unicore32/softmmu.c
R target/unicore32/translate.c
R target/unicore32/ucf64_helper.c
M tests/qemu-iotests/005
M tests/qemu-iotests/025
M tests/qemu-iotests/check
M tests/qemu-iotests/common.rc
M tests/qtest/boot-serial-test.c
M tests/qtest/machine-none-test.c
M tests/qtest/meson.build
M tests/tcg/README
M tests/tcg/configure.sh
R tests/tcg/lm32/Makefile
R tests/tcg/lm32/crt.S
R tests/tcg/lm32/helper.S
R tests/tcg/lm32/linker.ld
R tests/tcg/lm32/macros.inc
R tests/tcg/lm32/test_add.S
R tests/tcg/lm32/test_addi.S
R tests/tcg/lm32/test_and.S
R tests/tcg/lm32/test_andhi.S
R tests/tcg/lm32/test_andi.S
R tests/tcg/lm32/test_b.S
R tests/tcg/lm32/test_be.S
R tests/tcg/lm32/test_bg.S
R tests/tcg/lm32/test_bge.S
R tests/tcg/lm32/test_bgeu.S
R tests/tcg/lm32/test_bgu.S
R tests/tcg/lm32/test_bi.S
R tests/tcg/lm32/test_bne.S
R tests/tcg/lm32/test_break.S
R tests/tcg/lm32/test_bret.S
R tests/tcg/lm32/test_call.S
R tests/tcg/lm32/test_calli.S
R tests/tcg/lm32/test_cmpe.S
R tests/tcg/lm32/test_cmpei.S
R tests/tcg/lm32/test_cmpg.S
R tests/tcg/lm32/test_cmpge.S
R tests/tcg/lm32/test_cmpgei.S
R tests/tcg/lm32/test_cmpgeu.S
R tests/tcg/lm32/test_cmpgeui.S
R tests/tcg/lm32/test_cmpgi.S
R tests/tcg/lm32/test_cmpgu.S
R tests/tcg/lm32/test_cmpgui.S
R tests/tcg/lm32/test_cmpne.S
R tests/tcg/lm32/test_cmpnei.S
R tests/tcg/lm32/test_divu.S
R tests/tcg/lm32/test_eret.S
R tests/tcg/lm32/test_lb.S
R tests/tcg/lm32/test_lbu.S
R tests/tcg/lm32/test_lh.S
R tests/tcg/lm32/test_lhu.S
R tests/tcg/lm32/test_lw.S
R tests/tcg/lm32/test_modu.S
R tests/tcg/lm32/test_mul.S
R tests/tcg/lm32/test_muli.S
R tests/tcg/lm32/test_nor.S
R tests/tcg/lm32/test_nori.S
R tests/tcg/lm32/test_or.S
R tests/tcg/lm32/test_orhi.S
R tests/tcg/lm32/test_ori.S
R tests/tcg/lm32/test_ret.S
R tests/tcg/lm32/test_sb.S
R tests/tcg/lm32/test_scall.S
R tests/tcg/lm32/test_sextb.S
R tests/tcg/lm32/test_sexth.S
R tests/tcg/lm32/test_sh.S
R tests/tcg/lm32/test_sl.S
R tests/tcg/lm32/test_sli.S
R tests/tcg/lm32/test_sr.S
R tests/tcg/lm32/test_sri.S
R tests/tcg/lm32/test_sru.S
R tests/tcg/lm32/test_srui.S
R tests/tcg/lm32/test_sub.S
R tests/tcg/lm32/test_sw.S
R tests/tcg/lm32/test_xnor.S
R tests/tcg/lm32/test_xnori.S
R tests/tcg/lm32/test_xor.S
R tests/tcg/lm32/test_xori.S
Log Message:
-----------
Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2021-05-12' into
staging
Miscellaneous patches for 2021-05-12
# gpg: Signature made Wed 12 May 2021 17:22:15 BST
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* remotes/armbru/tags/pull-misc-2021-05-12:
Drop the deprecated unicore32 target
Drop the deprecated lm32 target
block: Drop the sheepdog block driver
Remove the deprecated moxie target
monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/dab59ce03122...2d3fc4e2b069