qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5994dc: ui, monitor: remove deprecated VNC AC


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 5994dc: ui, monitor: remove deprecated VNC ACL option and ...
Date: Thu, 18 Mar 2021 12:06:30 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 5994dcb8d8525ac044a31913c6bceeee788ec700
      
https://github.com/qemu/qemu/commit/5994dcb8d8525ac044a31913c6bceeee788ec700
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hmp-commands.hx
    M monitor/misc.c
    M ui/vnc.c

  Log Message:
  -----------
  ui, monitor: remove deprecated VNC ACL option and HMP commands

The VNC ACL concept has been replaced by the pluggable "authz" framework
which does not use monitor commands.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 283d845c9164f57f5dba020a4783bb290493802f
      
https://github.com/qemu/qemu/commit/283d845c9164f57f5dba020a4783bb290493802f
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M monitor/monitor.c
    M qemu-options.hx

  Log Message:
  -----------
  monitor: raise error when 'pretty' option is used with HMP

This is only semantically useful for QMP.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 8becb36063fb14df1e3ae4916215667e2cb65fa2
      
https://github.com/qemu/qemu/commit/8becb36063fb14df1e3ae4916215667e2cb65fa2
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M monitor/qmp-cmds-control.c
    M qapi/control.json

  Log Message:
  -----------
  monitor: remove 'query-events' QMP command

The code comment suggests removing QAPIEvent_(str|lookup) symbols too,
however, these are both auto-generated as standard for any enum in
QAPI. As such it they'll exist whether we use them or not.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: cbde7be900d2a2279cbc4becb91d1ddd6a014def
      
https://github.com/qemu/qemu/commit/cbde7be900d2a2279cbc4becb91d1ddd6a014def
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/devel/migration.rst
    M docs/rdma.txt
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M docs/xbzrle.txt
    M hmp-commands-info.hx
    M hmp-commands.hx
    M include/monitor/hmp.h
    M migration/migration.c
    M migration/ram.c
    M monitor/hmp-cmds.c
    M qapi/migration.json
    M tests/migration/guestperf/engine.py
    M tests/qemu-iotests/181
    M tests/qtest/migration-test.c
    M tests/qtest/test-hmp.c
    M tests/qtest/vhost-user-test.c

  Log Message:
  -----------
  migrate: remove QMP/HMP commands for speed, downtime and cache size

The generic 'migrate_set_parameters' command handle all types of param.

Only the QMP commands were documented in the deprecations page, but the
rationale for deprecating applies equally to HMP, and the replacements
exist. Furthermore the HMP commands are just shims to the QMP commands,
so removing the latter breaks the former unless they get re-implemented.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 8af54b9172ff3b9bbdbb3191ed84994d275a0d81
      
https://github.com/qemu/qemu/commit/8af54b9172ff3b9bbdbb3191ed84994d275a0d81
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/core/machine-hmp-cmds.c
    M hw/core/machine-qmp-cmds.c
    M qapi/machine.json
    M tests/acceptance/pc_cpu_hotplug_props.py
    M tests/acceptance/x86_cpu_model_versions.py
    M tests/migration/guestperf/engine.py
    M tests/qtest/numa-test.c
    M tests/qtest/qmp-test.c
    M tests/qtest/test-x86-cpuid-compat.c

  Log Message:
  -----------
  machine: remove 'query-cpus' QMP command

The newer 'query-cpus-fast' command avoids side effects on the guest
execution. Note that some of the field names are different in the
'query-cpus-fast' command.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Tested-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 445a5b4087567bf4d4ce76d394adf78d9d5c88a5
      
https://github.com/qemu/qemu/commit/445a5b4087567bf4d4ce76d394adf78d9d5c88a5
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/core/machine-qmp-cmds.c
    M qapi/machine.json

  Log Message:
  -----------
  machine: remove 'arch' field from 'query-cpus-fast' QMP command

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 24e13a4dc1eb1630eceffc7ab334145d902e763d
      
https://github.com/qemu/qemu/commit/24e13a4dc1eb1630eceffc7ab334145d902e763d
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M chardev/char-socket.c
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst

  Log Message:
  -----------
  chardev: reject use of 'wait' flag for socket client chardevs

This only makes sense conceptually when used with listener chardevs.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: b50101833987b47e0740f1621de48637c468c3d1
      
https://github.com/qemu/qemu/commit/b50101833987b47e0740f1621de48637c468c3d1
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/qdev-device-use.txt
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/i386/pc.c
    M hw/ide/qdev.c
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c
    M hw/sparc64/sun4u.c
    M scripts/device-crash-test
    M softmmu/vl.c
    M tests/qemu-iotests/051
    M tests/qemu-iotests/051.pc.out

  Log Message:
  -----------
  hw/ide: remove 'ide-drive' device

The 'ide-hd' and 'ide-cd' devices provide suitable alternatives.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 879be3af49132d232602e0ca783ec9b4112530fa
      
https://github.com/qemu/qemu/commit/879be3af49132d232602e0ca783ec9b4112530fa
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/i386/pc.c
    M hw/scsi/scsi-disk.c
    M scripts/device-crash-test
    M tests/qemu-iotests/051
    M tests/qemu-iotests/051.pc.out

  Log Message:
  -----------
  hw/scsi: remove 'scsi-disk' device

The 'scsi-hd' and 'scsi-cd' devices provide suitable alternatives.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: ad1324e044240ae9fcf67e4c215481b7a35591b9
      
https://github.com/qemu/qemu/commit/ad1324e044240ae9fcf67e4c215481b7a35591b9
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M block/qapi.c
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M qapi/block-core.json
    M tests/qemu-iotests/184.out
    M tests/qemu-iotests/191.out
    M tests/qemu-iotests/273.out

  Log Message:
  -----------
  block: remove 'encryption_key_missing' flag from QAPI

This has been hardcoded to "false" since 2.10.0, since secrets required
to unlock block devices are now always provided up front instead of using
interactive prompts.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 81cbfd5088690c53541ffd0d74851c8ab055a829
      
https://github.com/qemu/qemu/commit/81cbfd5088690c53541ffd0d74851c8ab055a829
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M block/dirty-bitmap.c
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M include/block/dirty-bitmap.h
    M qapi/block-core.json
    M tests/qemu-iotests/124
    M tests/qemu-iotests/194.out
    M tests/qemu-iotests/236.out
    M tests/qemu-iotests/246.out
    M tests/qemu-iotests/254.out
    M tests/qemu-iotests/257.out

  Log Message:
  -----------
  block: remove dirty bitmaps 'status' field

The same information is available via the 'recording' and 'busy' fields.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: e67d8e2928200e24ecb47c7be3ea8270077f2996
      
https://github.com/qemu/qemu/commit/e67d8e2928200e24ecb47c7be3ea8270077f2996
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M block/qapi.c
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M qapi/block-core.json
    M tests/qemu-iotests/194
    M tests/qemu-iotests/236
    M tests/qemu-iotests/246
    M tests/qemu-iotests/254
    M tests/qemu-iotests/260
    M tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test

  Log Message:
  -----------
  block: remove 'dirty-bitmaps' field from 'BlockInfo' struct

The same data is available in the 'BlockDeviceInfo' struct.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 8d17adf34f501ded65a106572740760f0a75577c
      
https://github.com/qemu/qemu/commit/8d17adf34f501ded65a106572740760f0a75577c
  Author: Daniel P. Berrangé <berrange@redhat.com>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M block/file-posix.c
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M tests/qemu-iotests/226.out

  Log Message:
  -----------
  block: remove support for using "file" driver with block/char devices

The 'host_device' and 'host_cdrom' drivers must be used instead.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 1b507e55f8199eaad99744613823f6929e4d57c6
      
https://github.com/qemu/qemu/commit/1b507e55f8199eaad99744613823f6929e4d57c6
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-03-18 (Thu, 18 Mar 2021)

  Changed paths:
    M block/dirty-bitmap.c
    M block/file-posix.c
    M block/qapi.c
    M chardev/char-socket.c
    M docs/devel/migration.rst
    M docs/qdev-device-use.txt
    M docs/rdma.txt
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M docs/xbzrle.txt
    M hmp-commands-info.hx
    M hmp-commands.hx
    M hw/core/machine-hmp-cmds.c
    M hw/core/machine-qmp-cmds.c
    M hw/i386/pc.c
    M hw/ide/qdev.c
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c
    M hw/scsi/scsi-disk.c
    M hw/sparc64/sun4u.c
    M include/block/dirty-bitmap.h
    M include/monitor/hmp.h
    M migration/migration.c
    M migration/ram.c
    M monitor/hmp-cmds.c
    M monitor/misc.c
    M monitor/monitor.c
    M monitor/qmp-cmds-control.c
    M qapi/block-core.json
    M qapi/control.json
    M qapi/machine.json
    M qapi/migration.json
    M qemu-options.hx
    M scripts/device-crash-test
    M softmmu/vl.c
    M tests/acceptance/pc_cpu_hotplug_props.py
    M tests/acceptance/x86_cpu_model_versions.py
    M tests/migration/guestperf/engine.py
    M tests/qemu-iotests/051
    M tests/qemu-iotests/051.pc.out
    M tests/qemu-iotests/124
    M tests/qemu-iotests/181
    M tests/qemu-iotests/184.out
    M tests/qemu-iotests/191.out
    M tests/qemu-iotests/194
    M tests/qemu-iotests/194.out
    M tests/qemu-iotests/226.out
    M tests/qemu-iotests/236
    M tests/qemu-iotests/236.out
    M tests/qemu-iotests/246
    M tests/qemu-iotests/246.out
    M tests/qemu-iotests/254
    M tests/qemu-iotests/254.out
    M tests/qemu-iotests/257.out
    M tests/qemu-iotests/260
    M tests/qemu-iotests/273.out
    M tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
    M tests/qtest/migration-test.c
    M tests/qtest/numa-test.c
    M tests/qtest/qmp-test.c
    M tests/qtest/test-hmp.c
    M tests/qtest/test-x86-cpuid-compat.c
    M tests/qtest/vhost-user-test.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/berrange-gitlab/tags/dep-many-pull-request' into staging

Remove many old deprecated features

The following features have been deprecated for well over the 2
release cycle we promise

  ``-drive file=json:{...{'driver':'file'}}`` (since 3.0)
  ``-vnc acl`` (since 4.0.0)
  ``-mon ...,control=readline,pretty=on|off`` (since 4.1)
  ``migrate_set_downtime`` and ``migrate_set_speed`` (since 2.8.0)
  ``query-named-block-nodes`` result ``encryption_key_missing`` (since 2.10.0)
  ``query-block`` result ``inserted.encryption_key_missing`` (since 2.10.0)
  ``migrate-set-cache-size`` and ``query-migrate-cache-size`` (since 2.11.0)
  ``query-named-block-nodes`` and ``query-block`` result 
dirty-bitmaps[i].status (since 4.0)
  ``query-cpus`` (since 2.12.0)
  ``query-cpus-fast`` ``arch`` output member (since 3.0.0)
  ``query-events`` (since 4.0)
  chardev client socket with ``wait`` option (since 4.0)
  ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` 
(since 4.0.0)
  ``ide-drive`` (since 4.2)
  ``scsi-disk`` (since 4.2)

# gpg: Signature made Thu 18 Mar 2021 09:23:39 GMT
# gpg:                using RSA key DAF3A6FDB26B62912D0E8E3FBE86EBB415104FDF
# gpg: Good signature from "Daniel P. Berrange <dan@berrange.com>" [full]
# gpg:                 aka "Daniel P. Berrange <berrange@redhat.com>" [full]
# Primary key fingerprint: DAF3 A6FD B26B 6291 2D0E  8E3F BE86 EBB4 1510 4FDF

* remotes/berrange-gitlab/tags/dep-many-pull-request:
  block: remove support for using "file" driver with block/char devices
  block: remove 'dirty-bitmaps' field from 'BlockInfo' struct
  block: remove dirty bitmaps 'status' field
  block: remove 'encryption_key_missing' flag from QAPI
  hw/scsi: remove 'scsi-disk' device
  hw/ide: remove 'ide-drive' device
  chardev: reject use of 'wait' flag for socket client chardevs
  machine: remove 'arch' field from 'query-cpus-fast' QMP command
  machine: remove 'query-cpus' QMP command
  migrate: remove QMP/HMP commands for speed, downtime and cache size
  monitor: remove 'query-events' QMP command
  monitor: raise error when 'pretty' option is used with HMP
  ui, monitor: remove deprecated VNC ACL option and HMP commands

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/4083904bc9fe...1b507e55f819



reply via email to

[Prev in Thread] Current Thread [Next in Thread]