qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7707be: hw/usb/bus: Remove the "full-path" pr

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 7707be: hw/usb/bus: Remove the "full-path" property
Date: Tue, 16 Mar 2021 06:18:55 -0700 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 7707beaea780d1ed918fd25a9ce84f055fe17921
      
https://github.com/qemu/qemu/commit/7707beaea780d1ed918fd25a9ce84f055fe17921
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/bus.c
    M include/hw/usb.h

  Log Message:
  -----------
  hw/usb/bus: Remove the "full-path" property

This property was only required for the pc-1.0 and earlier machine
types. Since these have been removed now, we can delete the property
as well.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210302120152.118042-1-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 405cf80ceb6ba62c7bafba55a85af51262d25b36
      
https://github.com/qemu/qemu/commit/405cf80ceb6ba62c7bafba55a85af51262d25b36
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/bus.c
    M hw/usb/dev-serial.c
    M include/hw/usb.h

  Log Message:
  -----------
  usb: remove support for -usbdevice parameters

No device needs them anymore and in fact they're undocumented.
Remove the code.  The only change in behavior is that "-usbdevice
braille:hello" now reports an error, which is a bugfix.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210310173323.1422754-2-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6523c96c9ce0d4d8c34d447fbdf489ca0affb515
      
https://github.com/qemu/qemu/commit/6523c96c9ce0d4d8c34d447fbdf489ca0affb515
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/u2f.c

  Log Message:
  -----------
  usb: remove '-usbdevice u2f-key'

It never worked.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210310173323.1422754-3-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6db34277e3b3071707a3a20afb82176e4f229b8f
      
https://github.com/qemu/qemu/commit/6db34277e3b3071707a3a20afb82176e4f229b8f
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/usb/dev-audio.c
    M softmmu/vl.c

  Log Message:
  -----------
  usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)

When trying to remove the -usbdevice option, there were complaints that
"-usbdevice braille" is still a very useful shortcut for some people.
Thus we never remove this option. Since it's not such a big burden to
keep it around, and it's also convenient in the sense that you don't
have to worry to enable a host controller explicitly with this option,
we should remove it from he deprecation list again.

However, there is one exception: "-usbdevice audio" should go away, since
audio devices without "audiodev=..." parameter are also on the deprecation
list and you cannot use "-usbdevice audio" with "audiodev".

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210310173323.1422754-4-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: c2a34ab2a0196e9a97e7206b94a6377cc70fb623
      
https://github.com/qemu/qemu/commit/c2a34ab2a0196e9a97e7206b94a6377cc70fb623
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  usb: Document the missing -usbdevice options

There are some more -usbdevice options that have never been mentioned
in the documentation. Now that we removed -usbdevice from the list
of deprecated features again, we should document them properly.

While we're at it, also sort them alphabetically.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20210310173323.1422754-5-thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: f4c46916dc670f894997409ea261e77867a136fa
      
https://github.com/qemu/qemu/commit/f4c46916dc670f894997409ea261e77867a136fa
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/isa/Kconfig

  Log Message:
  -----------
  hw/southbridge: Add missing Kconfig dependency VT82C686 on USB_UHCI

The VT82C686 south bridge provides a USB UHCI bus via a PCI function.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <20210309190802.830969-2-f4bug@amsat.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 9a4e12a64dffa241fc5c06e61c7f90799a67891e
      
https://github.com/qemu/qemu/commit/9a4e12a64dffa241fc5c06e61c7f90799a67891e
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/hcd-uhci.c
    A hw/usb/hcd-uhci.h

  Log Message:
  -----------
  hw/usb/hcd-uhci: Expose generic prototypes to local header

Extract generic UHCI prototypes into a new "hcd-uhci.h" local
header so we can reuse them in other units.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210309190802.830969-3-f4bug@amsat.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6f2bcd5fc84700b5eabfd58c08cbc61f1d7b5b6e
      
https://github.com/qemu/qemu/commit/6f2bcd5fc84700b5eabfd58c08cbc61f1d7b5b6e
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M MAINTAINERS
    M hw/usb/hcd-uhci.c
    M hw/usb/meson.build
    A hw/usb/vt82c686-uhci-pci.c

  Log Message:
  -----------
  hw/usb: Extract VT82C686 UHCI PCI function into a new unit

Extract the VT82C686 PCI UHCI function into a new unit so
it is only build when the VT82C686 south bridge is selected.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210309190802.830969-4-f4bug@amsat.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bbd8323d3196c9979385cba1b8b38859836e63c3
      
https://github.com/qemu/qemu/commit/bbd8323d3196c9979385cba1b8b38859836e63c3
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/dev-storage.c
    A include/hw/usb/msd.h

  Log Message:
  -----------
  usb/storage: move declarations to usb/msd.h header

In preparation for splitting the usb-storage.c file move
declarations to the new usb/msd.h header file.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210312090425.772900-2-kraxel@redhat.com>


  Commit: 31b7bed8b600e10c853595fb48f510c54ec86523
      
https://github.com/qemu/qemu/commit/31b7bed8b600e10c853595fb48f510c54ec86523
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    A hw/usb/dev-storage-bot.c
    M hw/usb/dev-storage.c
    M hw/usb/meson.build

  Log Message:
  -----------
  usb/storage: move usb-bot device to separate source file

Pure code motion, no functional change.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210312090425.772900-3-kraxel@redhat.com>


  Commit: 65561351e32d0cf7f0c1769003529cebec52d579
      
https://github.com/qemu/qemu/commit/65561351e32d0cf7f0c1769003529cebec52d579
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    A hw/usb/dev-storage-classic.c
    M hw/usb/dev-storage.c
    M hw/usb/meson.build

  Log Message:
  -----------
  usb/storage move usb-storage device to separate source file

Pure code motion, no functional change.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210312090425.772900-4-kraxel@redhat.com>


  Commit: f98c9bd45fb4f479ca38f8a2b2abcf27e9c2b9aa
      
https://github.com/qemu/qemu/commit/f98c9bd45fb4f479ca38f8a2b2abcf27e9c2b9aa
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/Kconfig
    M hw/usb/meson.build

  Log Message:
  -----------
  usb/storage: add kconfig symbols

Add new kconfig symbols so usb-storage and usb-bot can
be enabled or disabled individually at build time.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210312090425.772900-5-kraxel@redhat.com>


  Commit: 39912c14da07a2dbc73854addcfa0a42596340ac
      
https://github.com/qemu/qemu/commit/39912c14da07a2dbc73854addcfa0a42596340ac
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-03-15 (Mon, 15 Mar 2021)

  Changed paths:
    M hw/usb/dev-storage.c

  Log Message:
  -----------
  usb/storage: clear csw on reset

Stale data in csw (specifically residue) can confuse the state machine
and allows the guest trigger an assert().  So clear csw on reset to
avoid this happening in case the guest resets the device in the middle
of a request.

Buglink: https://bugs.launchpad.net/qemu/+bug/1523811
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210312094954.796799-1-kraxel@redhat.com>


  Commit: 5b7f5586d182b0cafb1f8d558992a14763e2953e
      
https://github.com/qemu/qemu/commit/5b7f5586d182b0cafb1f8d558992a14763e2953e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-03-16 (Tue, 16 Mar 2021)

  Changed paths:
    M MAINTAINERS
    M docs/system/deprecated.rst
    M docs/system/removed-features.rst
    M hw/isa/Kconfig
    M hw/usb/Kconfig
    M hw/usb/bus.c
    M hw/usb/dev-audio.c
    M hw/usb/dev-serial.c
    A hw/usb/dev-storage-bot.c
    A hw/usb/dev-storage-classic.c
    M hw/usb/dev-storage.c
    M hw/usb/hcd-uhci.c
    A hw/usb/hcd-uhci.h
    M hw/usb/meson.build
    M hw/usb/u2f.c
    A hw/usb/vt82c686-uhci-pci.c
    M include/hw/usb.h
    A include/hw/usb/msd.h
    M qemu-options.hx
    M softmmu/vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20210315-pull-request' 
into staging

usb: -usbdevice cleanup and un-deprecation.
usb: split usb-storage.
usb: misc fixes and cleanups.

# gpg: Signature made Mon 15 Mar 2021 18:02:28 GMT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20210315-pull-request:
  usb/storage: clear csw on reset
  usb/storage: add kconfig symbols
  usb/storage move usb-storage device to separate source file
  usb/storage: move usb-bot device to separate source file
  usb/storage: move declarations to usb/msd.h header
  hw/usb: Extract VT82C686 UHCI PCI function into a new unit
  hw/usb/hcd-uhci: Expose generic prototypes to local header
  hw/southbridge: Add missing Kconfig dependency VT82C686 on USB_UHCI
  usb: Document the missing -usbdevice options
  usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed)
  usb: remove '-usbdevice u2f-key'
  usb: remove support for -usbdevice parameters
  hw/usb/bus: Remove the "full-path" property

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/0f8247d84376...5b7f5586d182
reply via email to
[Prev in Thread] Current Thread [Next in Thread]