qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3af167: spice: flush on GL update before noti


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 3af167: spice: flush on GL update before notifying client
Date: Sat, 20 Feb 2021 11:27:40 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3af167185229afae754f86e1b86d6dd9a5acfb70
      
https://github.com/qemu/qemu/commit/3af167185229afae754f86e1b86d6dd9a5acfb70
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice: flush on GL update before notifying client

Since the introduction of spice/virgl support in commit
474114b7 ("spice: add opengl/virgl/dmabuf support"), the drawing isn't
being flushed before notifying the client. This results in
outdated/sluggish drawing on client side, in particular when using the
Linux console.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210216092056.2301293-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: f4f2805ef8938565973864a7e5fd1207e074460e
      
https://github.com/qemu/qemu/commit/f4f2805ef8938565973864a7e5fd1207e074460e
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice: flush drawing before notifying client

This solves the client having slow/outdated VGA/2D console. It's a
regression introduced when the code was switched to render it via opengl
in commit 4423184376d ("spice/gl: render DisplaySurface via opengl")

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210216092056.2301293-2-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 708b72557ff510493ab3653c7a1ebfe983009469
      
https://github.com/qemu/qemu/commit/708b72557ff510493ab3653c7a1ebfe983009469
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Support unique keys of JIS keyboards

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210212000404.28413-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: c0ff29d1889040a61a7120731ac16e0c1da39149
      
https://github.com/qemu/qemu/commit/c0ff29d1889040a61a7120731ac16e0c1da39149
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Do not copy members of pixman image

The old CocoaView had an idea of synchronizing the host window
configuration and the guest screen configuration. Here, the guest screen
actually means pixman image given ui/cocoa display implementation.

However, [CocoaView -drawRect:] directly interacts with the pixman
image buffer in reality. There is no such distinction of "host" and
"guest." This change removes the "host" configuration and let drawRect
consistently have the direct reference to pixman image. It allows to
get rid of the error-prone "sync" and reduce code size a bit.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210212000629.28551-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 122e4ef6dea14a078a860ca253852e18ddebb8e2
      
https://github.com/qemu/qemu/commit/122e4ef6dea14a078a860ca253852e18ddebb8e2
  Author: Bruce Rogers <brogers@suse.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/spice-app.c

  Log Message:
  -----------
  spice-app: avoid crash when core spice module doesn't loaded

When qemu is built with modules, but a given module doesn't load
qemu should handle that gracefully. When ui-spice-core.so isn't
able to be loaded and qemu is invoked with -display spice-app or
-spice, qemu will dereference a null pointer. With this change we
check the pointer before dereferencing and error out in a normal
way.

Signed-off-by: Bruce Rogers <brogers@suse.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210213032318.346093-1-brogers@suse.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 4295f8365cbe8b583d1065b046e9d086b4bc54c9
      
https://github.com/qemu/qemu/commit/4295f8365cbe8b583d1065b046e9d086b4bc54c9
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Interpret left button down as is when command is pressed

Old Macs were not equipped with mice with an ability to perform
"right clicks" and ui/cocoa interpreted left button down with
left command key pressed as right button down as a workaround.

The workaround has an obvious downside: you cannot tell the guest
that the left button is down while the left command key is
pressed.

Today, Macs has trackpads, Apple Mice, or Magic Mice. They are
capable to emulate right clicks with gestures, which also allows
to perform right clicks on "BootCamp" OSes like Windows.

By removing the workaround, we overcome its downside, and provide
a behavior consistent with BootCamp.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210212000706.28616-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: cc7859c370b0e12f176aab3d0034ff7fa8f5a973
      
https://github.com/qemu/qemu/commit/cc7859c370b0e12f176aab3d0034ff7fa8f5a973
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M ui/cocoa.m

  Log Message:
  -----------
  ui/cocoa: Statically allocate dcl

There is no need of dynamic allocation as dcl is a small singleton.
Static allocation reduces code size and makes hacking with ui/cocoa a
bit easier.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210219084419.90181-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 075e7a5b7f3c640823fce76c8dab503c42f0d7f6
      
https://github.com/qemu/qemu/commit/075e7a5b7f3c640823fce76c8dab503c42f0d7f6
  Author: Akihiko Odaki <akihiko.odaki@gmail.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk-gl-area.c

  Log Message:
  -----------
  ui/console: Remove dpy_gl_ctx_get_current

It is not used, and it is unlikely that a new use case will emerge
anytime soon because the scope of OpenGL contexts are limited due to
the nature of the frontend, VirGL, processing simple commands from the
guest.

Remove the function and ease implementing a new OpenGL backend a little.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Message-Id: <20210219094702.90789-1-akihiko.odaki@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: d6798cc01d6edabaa4e326359b69f08d022bf4c7
      
https://github.com/qemu/qemu/commit/d6798cc01d6edabaa4e326359b69f08d022bf4c7
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M include/ui/gtk.h
    M ui/cocoa.m
    M ui/gtk-gl-area.c
    M ui/spice-app.c
    M ui/spice-display.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210219-pull-request' 
into staging

ui: spice bugfixes.
ui: first batch of cocoa updates.

# gpg: Signature made Fri 19 Feb 2021 22:00:14 GMT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20210219-pull-request:
  ui/console: Remove dpy_gl_ctx_get_current
  ui/cocoa: Statically allocate dcl
  ui/cocoa: Interpret left button down as is when command is pressed
  spice-app: avoid crash when core spice module doesn't loaded
  ui/cocoa: Do not copy members of pixman image
  ui/cocoa: Support unique keys of JIS keyboards
  spice: flush drawing before notifying client
  spice: flush on GL update before notifying client

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/e90ef02389dc...d6798cc01d6e



reply via email to

[Prev in Thread] Current Thread [Next in Thread]