qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9e5fa3: Acceptance Tests: bump Avocado versio


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 9e5fa3: Acceptance Tests: bump Avocado version requirement...
Date: Tue, 16 Feb 2021 08:46:32 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9e5fa3a47c8016e04eb0f2d0cc405a4367e45cb2
      
https://github.com/qemu/qemu/commit/9e5fa3a47c8016e04eb0f2d0cc405a4367e45cb2
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/requirements.txt

  Log Message:
  -----------
  Acceptance Tests: bump Avocado version requirement to 85.0

This version (and 84.0) contain improvements that address specific
QEMU use cases, including:

 * Being able to download and use Fedora 31 images and thus
   re-activate the "boot_linux.py" tests

 * Being able to register local assets via "avocado assets register"
   and use them in tests

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210211232835.2608059-2-crosa@redhat.com>
Acked-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 3e5c180be0ccf6ced16b76ed552182f364e5da6c
      
https://github.com/qemu/qemu/commit/3e5c180be0ccf6ced16b76ed552182f364e5da6c
  Author: Max Reitz <mreitz@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/virtiofs_submounts.py

  Log Message:
  -----------
  virtiofs_submounts.py test: Note on vmlinuz param

>From the cancel message, it is not entirely clear why this parameter is
mandatory now, or that it will be optional in the future.  Add such a
more detailed explanation as a comment in the test source file.

Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210212151649.252440-1-mreitz@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 3c1e16c60c72e8f11a15d63e9d4a2fd33be6b106
      
https://github.com/qemu/qemu/commit/3c1e16c60c72e8f11a15d63e9d4a2fd33be6b106
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M python/qemu/machine.py

  Log Message:
  -----------
  Python: close the log file kept by QEMUMachine before reading it

Closing a file that is open for writing, and then reading from it
sounds like a better idea than the opposite, given that the content
will be flushed.

Reference: https://docs.python.org/3/library/io.html#io.IOBase.close
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210211220146.2525771-2-crosa@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: cdcc50bf6e05749478d93b42dd4b13114f416b5a
      
https://github.com/qemu/qemu/commit/cdcc50bf6e05749478d93b42dd4b13114f416b5a
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/virtio-gpu.py

  Log Message:
  -----------
  tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log

Preserve log at location already prepared for keeping the test's log
files.

While at it, log info about its location (in the main test log
file), instead of printing it out.

Reference: 
https://avocado-framework.readthedocs.io/en/85.0/api/test/avocado.html#avocado.Test.logdir
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[philmd: use full sentence]
Message-Id: <20210211220146.2525771-7-crosa@redhat.com>

Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 991e80911ed131f1785bd6015647180fed4dd95f
      
https://github.com/qemu/qemu/commit/991e80911ed131f1785bd6015647180fed4dd95f
  Author: Eric Blake <eblake@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M .gitattributes

  Log Message:
  -----------
  maint: Tell git that *.py files should use python diff hunks

Git's default hunk pattern recognizer favors the C language, but it
also includes several built-in diff styles that give saner results in
other languages.  In particular, telling git to treat all .py files as
python changes the beginning of diff hunks as follows:

|  --- a/python/qemu/machine.py
|  +++ b/python/qemu/machine.py
| -@@ -337,12 +337,12 @@ class QEMUMachine:
| +@@ -337,12 +337,12 @@ def _post_shutdown(self) -> None:
|               self._qmp.close()

which makes it much easier to tell what function a patch is touching,
rather than a non-descript listing of what class contains the changes.

Sadly, our python files that don't use .py suffix (such as numerous
iotests) do not benefit from this glob.

Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20210215222524.1820223-1-eblake@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 6dd7457916e17f7674e96d02b66a376b0f923fcc
      
https://github.com/qemu/qemu/commit/6dd7457916e17f7674e96d02b66a376b0f923fcc
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py
    M tests/acceptance/virtiofs_submounts.py

  Log Message:
  -----------
  Acceptance Tests: introduce LinuxTest base class

This is basically the infrastructure around "boot_linux.py" tests, but
now made into a base class for general use.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210203172357.1422425-15-crosa@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: efe30d5011b7a667e3edac22ffd5318bc55c14b2
      
https://github.com/qemu/qemu/commit/efe30d5011b7a667e3edac22ffd5318bc55c14b2
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py
    M tests/acceptance/virtiofs_submounts.py

  Log Message:
  -----------
  Acceptance Tests: introduce method for requiring an accelerator

Some tests explicitly require a QEMU accelerator to be available.
Given that this depends on some runtime aspects not known before
the test is started, such as the currently set QEMU binary, it's
left to be checked also at runtime.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210203172357.1422425-17-crosa@redhat.com>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: e8197c6e0c56aff83d96df221bb56a57d0bc0e96
      
https://github.com/qemu/qemu/commit/e8197c6e0c56aff83d96df221bb56a57d0bc0e96
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: fix population of public key in cloudinit image

Currently the path of the ssh public key is being set, but its
content is obviously what's needed.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210203172357.1422425-18-crosa@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: c0c5a7f18e623b8f6eb7a9ccebdccdc56db2cec7
      
https://github.com/qemu/qemu/commit/c0c5a7f18e623b8f6eb7a9ccebdccdc56db2cec7
  Author: Cleber Rosa <crosa@redhat.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M tests/acceptance/avocado_qemu/__init__.py

  Log Message:
  -----------
  Acceptance Tests: set up existing ssh keys by default

It's questionable whether it's necessary to create one brand new pair
for each test.  It's not questionable that it takes less time and
resources to just use the keys available at "tests/keys" that exist
for that exact reason.

If a location for the public key is not given explicitly, the
LinuxTest will now set up the existing pair of keys as the default.
This removes the need for a lot of boilerplate code.

To avoid the ssh client from erroring on permission issues, a
directory with restrictive permissions is created for the private key.
This should still be a lot cheaper than creating a new key.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210203172357.1422425-19-crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
[marcandre: fix typos in commit message]
Signed-off-by: Cleber Rosa <crosa@redhat.com>


  Commit: 18543229fd7a2c79dcd6818c7b1f0f62512b5220
      
https://github.com/qemu/qemu/commit/18543229fd7a2c79dcd6818c7b1f0f62512b5220
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
    M .gitattributes
    M python/qemu/machine.py
    M tests/acceptance/avocado_qemu/__init__.py
    M tests/acceptance/boot_linux.py
    M tests/acceptance/virtio-gpu.py
    M tests/acceptance/virtiofs_submounts.py
    M tests/requirements.txt

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/cleber-gitlab/tags/python-next-pull-request' into staging

Acceptance Tests and Python libs improvements

Along with the Acceptance Tests and Python libs improvements, a
improvement to the diff generation for Python code.

# gpg: Signature made Tue 16 Feb 2021 04:55:45 GMT
# gpg:                using RSA key 7ABB96EB8B46B94D5E0FE9BB657E8D33A5F209F3
# gpg: Good signature from "Cleber Rosa <crosa@redhat.com>" [marginal]
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3

* remotes/cleber-gitlab/tags/python-next-pull-request:
  Acceptance Tests: set up existing ssh keys by default
  Acceptance Tests: fix population of public key in cloudinit image
  Acceptance Tests: introduce method for requiring an accelerator
  Acceptance Tests: introduce LinuxTest base class
  maint: Tell git that *.py files should use python diff hunks
  tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log
  Python: close the log file kept by QEMUMachine before reading it
  virtiofs_submounts.py test: Note on vmlinuz param
  Acceptance Tests: bump Avocado version requirement to 85.0

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/8ba4bca570ac...18543229fd7a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]