qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ee2fc6: m68k: improve cpu instantiation comme

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ee2fc6: m68k: improve cpu instantiation comments
Date: Sat, 13 Feb 2021 10:22:19 -0800 
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ee2fc6c6da8b2d6f961c8559d62e990c65f67736
      
https://github.com/qemu/qemu/commit/ee2fc6c6da8b2d6f961c8559d62e990c65f67736
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h

  Log Message:
  -----------
  m68k: improve cpu instantiation comments

Improvement in comments for the instantiation functions.
This is to highlight what each cpu class, in the 68000 series, contains
in terms of instructions/features.

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<2dfe32672ee6ddce4b54c6bcfce579d35abeaf51.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 4ecce5fb52314c02e680924cf8f5050b207e19d4
      
https://github.com/qemu/qemu/commit/4ecce5fb52314c02e680924cf8f5050b207e19d4
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h

  Log Message:
  -----------
  m68k: cascade m68k_features by m680xx_cpu_initfn() to improve readability

The m680XX_cpu_initfn functions have been rearranged to cascade starting from
the base 68000, so that the 68010 then inherits from this, and so on until the
68060.

This makes it simpler to track features since in most cases the m68k were
product enhancements on each other, with only a few instructions being retired.

Because each cpu class inherits the previous CPU class, then for example
the 68020 also has the feature 68010, and 68000 and so on upto the 68060.

- Added 68010 cpu class, and moved correct features into 68000/68010.
- Added m68k_unset_feature to allow removing a feature in the inheritence

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<c652fe7537f8b4fe87a13ecbbc0ea751fb71532f.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 60d8e96453d090f71027f95e47e5ddbe17f670e3
      
https://github.com/qemu/qemu/commit/60d8e96453d090f71027f95e47e5ddbe17f670e3
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/helper.c

  Log Message:
  -----------
  m68k: improve comments on m68k_move_to/from helpers

Add more detailed comments to each case of m68k_move_to/from helpers to list
the supported CPUs for that CR as they were wrong in some cases, and
missing some cpu classes in other cases.

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<a8bd70b66e3dbdb7d2ab7a852af71cdbf341d50c.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5736526ce2da32205022b10dcdf9807e735e451a
      
https://github.com/qemu/qemu/commit/5736526ce2da32205022b10dcdf9807e735e451a
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/cpu.h
    M target/m68k/helper.c

  Log Message:
  -----------
  m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to 
m68k_move_to/from

The BUSCR/PCR CR defines were missing for 68060, and the move_to/from helper
functions were also missing a decode for the 68060 M68K_CR_CAAR CR register.

Added missing defines, and respective decodes for all three CR registers to
the helpers.

Although this patch defines them, the implementation is empty in this patch
and these registers will result in a cpu abort - which is the default prior
to this patch.

This patch aims to reach full coverage of all CR registers within the helpers.

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: 
<19e5c0fa8baed6479ed0502fd3deb132d19457fb.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 8df0e6aedad33c6746f4bc2a4d0cfdd432877084
      
https://github.com/qemu/qemu/commit/8df0e6aedad33c6746f4bc2a4d0cfdd432877084
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/helper.c
    M target/m68k/translate.c

  Log Message:
  -----------
  m68k: MOVEC insn. should generate exception if wrong CR is accessed

Add CPU class detection for each CR type in the m68k_move_to/from helpers,
so that it throws and exception if an unsupported register is requested
for that CPU class.

Reclassified MOVEC insn. as only supported from 68010.

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<fc0d0187478716f05d990949347071969b743151.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 7525a9b94c0c5733b8450c9451ca1de334f71ed8
      
https://github.com/qemu/qemu/commit/7525a9b94c0c5733b8450c9451ca1de334f71ed8
  Author: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/helper.c

  Log Message:
  -----------
  m68k: add MSP detection support for stack pointer swap helpers

On m68k there are two varities of stack pointers: USP with SSP or ISP/MSP.

Only the 68020/30/40 support the MSP register the stack swap helpers don't
support this feature.

This patch adds this support, as well as comments to CPUM68KState to
make it clear how stacks are handled

Signed-off-by: Lucien Murray-Pitts <lucienmp.qemu@gmail.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: 
<c61ad2d8b39f3b03b431819b6bf602a1c332b921.1612137712.git.balaton@eik.bme.hu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 382d71af7d61620ffb023962f83cc4786303c60d
      
https://github.com/qemu/qemu/commit/382d71af7d61620ffb023962f83cc4786303c60d
  Author: Laurent Vivier <laurent@vivier.eu>
  Date:   2021-02-11 (Thu, 11 Feb 2021)

  Changed paths:
    M MAINTAINERS
    M hw/m68k/bootinfo.h
    M hw/m68k/q800.c
    A include/standard-headers/asm-m68k/bootinfo-mac.h
    A include/standard-headers/asm-m68k/bootinfo.h

  Log Message:
  -----------
  m68k: import bootinfo headers from linux

Copy bootinfo.h and bootinfo-mac.h from arch/m68k/include/uapi/asm/
to include/standard-headers/asm-m68k/

Imported from linux v5.9 but didn't change since v4.14 (header update)
and since v4.10 (content update).

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20201220112615.933036-2-laurent@vivier.eu>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: f4ceebdec531243dd72e38f85f085287e6e63258
      
https://github.com/qemu/qemu/commit/f4ceebdec531243dd72e38f85f085287e6e63258
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-02-13 (Sat, 13 Feb 2021)

  Changed paths:
    M MAINTAINERS
    M hw/m68k/bootinfo.h
    M hw/m68k/q800.c
    A include/standard-headers/asm-m68k/bootinfo-mac.h
    A include/standard-headers/asm-m68k/bootinfo.h
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/helper.c
    M target/m68k/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-6.0-pull-request' 
into staging

Pull request m68k-20210212

Move bootinfo headers to include/standard-headers/asm-m68k
Add M68K_FEATURE_MSP, M68K_FEATURE_MOVEC, M68K_FEATURE_M68010
Add 68060 CR BUSCR and PCR (unimplemented)
CPU types and features cleanup

# gpg: Signature made Fri 12 Feb 2021 21:14:28 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier/tags/m68k-for-6.0-pull-request:
  m68k: import bootinfo headers from linux
  m68k: add MSP detection support for stack pointer swap helpers
  m68k: MOVEC insn. should generate exception if wrong CR is accessed
  m68k: add missing BUSCR/PCR CR defines, and BUSCR/PCR/CAAR CR to 
m68k_move_to/from
  m68k: improve comments on m68k_move_to/from helpers
  m68k: cascade m68k_features by m680xx_cpu_initfn() to improve readability
  m68k: improve cpu instantiation comments

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/abb8b29aff35...f4ceebdec531
reply via email to
[Prev in Thread] Current Thread [Next in Thread]