[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] ada6f6: hw/display/qxl: Fix bad printf format
|
From: |
Peter Maydell |
|
Subject: |
[Qemu-commits] [qemu/qemu] ada6f6: hw/display/qxl: Fix bad printf format specifiers |
|
Date: |
Fri, 05 Feb 2021 03:57:01 -0800 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: ada6f6f4a34351c1320d30e4fc495c1d536bd19c
https://github.com/qemu/qemu/commit/ada6f6f4a34351c1320d30e4fc495c1d536bd19c
Author: Alex Chen <alex.chen@huawei.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/qxl-logger.c
M hw/display/qxl.c
Log Message:
-----------
hw/display/qxl: Fix bad printf format specifiers
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-id: 20201119025851.56487-1-alex.chen@huawei.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: c502758670432195d61ff848b1b47b0f78918ae2
https://github.com/qemu/qemu/commit/c502758670432195d61ff848b1b47b0f78918ae2
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/qxl.c
Log Message:
-----------
qxl: set qxl.ssd.dcl.con on secondary devices
On secondary QXL devices, the console is only set on qxl.vga.con. But
graphic_hw_update_done() is called with qxl.ssd.dcl.con.
Like for primary QXL devices, set qxl.sdd.dcl.con = qxl.vga.con.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210201201422.446552-2-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: b577ab2dda3afc7d6a7befabcf226507ff06c17c
https://github.com/qemu/qemu/commit/b577ab2dda3afc7d6a7befabcf226507ff06c17c
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/qxl-render.c
Log Message:
-----------
qxl: also notify the rendering is done when skipping it
Asynchronous handlers may be waiting for the graphic_hw_update_done() to
be called in this case too.
Fixes: 4d6316218 ("console: add graphic_hw_update_done()")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210201201422.446552-3-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: a652b120130e89850edb18cebd222310b77218f7
https://github.com/qemu/qemu/commit/a652b120130e89850edb18cebd222310b77218f7
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/qemu-spice.h
M ui/spice-core.c
M ui/spice-display.c
Log Message:
-----------
spice: delay starting until display are initialized
QEMU used to run qemu_spice.display_init() before vm_start(), and
QXL/display interfaces where started then. Now, vm_start() happens
before QXL/display interfaces are added and Spice server doesn't
automatically start them in this case (fixed in spice git)
Fixes Spice regression introduced after 5.2, with refactoring commits
b4e1a34211 ("vl: remove separate preconfig main_loop") and
facf7c60ee ("vl: initialize displays _after_ exiting preconfiguration"),
probably others.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210129152351.161971-1-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 326a51f32dfa56a63815c06c2ba3b14b371cef35
https://github.com/qemu/qemu/commit/326a51f32dfa56a63815c06c2ba3b14b371cef35
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/vhost-user-gpu.c
Log Message:
-----------
vhost-user-gpu: check backend for EDID support
EDID has been enabled by default, but the backend may not implement
it (such as the contrib backend). This results in extra warnings and
potentially other issues in the guest.
The option shouldn't probably have been added to VIRTIO_GPU_BASE, but
it's a bit too late now, report an error and disable EDID when it's
not available.
Fixes: 0a7196625 ("edid: flip the default to enabled")
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-2-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 1f83ea8dbd9b9698767770746b92ff7a9ccb9636
https://github.com/qemu/qemu/commit/1f83ea8dbd9b9698767770746b92ff7a9ccb9636
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M contrib/vhost-user-gpu/vhost-user-gpu.c
M contrib/vhost-user-gpu/vugpu.h
Log Message:
-----------
vhost-user-gpu: handle vhost-user-gpu features in a callback
Fixes a deadlock where the backend calls QEMU, while QEMU also calls the
backend simultaneously, both ends waiting for each other.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-3-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 72e631c6ac72363924f6c7030a99a7900d15451e
https://github.com/qemu/qemu/commit/72e631c6ac72363924f6c7030a99a7900d15451e
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M contrib/vhost-user-gpu/vhost-user-gpu.c
M contrib/vhost-user-gpu/virgl.c
M contrib/vhost-user-gpu/vugpu.h
Log Message:
-----------
vhost-user-gpu: use an extandable state enum for commands
Introduce a pending state for commands which aren't finished yet, but
are being handled. See following patch.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210204105232.834642-4-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: bd690feb155416defd1119aaad1c9fbe623c865f
https://github.com/qemu/qemu/commit/bd690feb155416defd1119aaad1c9fbe623c865f
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M contrib/vhost-user-gpu/vhost-user-gpu.c
Log Message:
-----------
vhost-user-gpu: handle display-info in a callback
Fixes a deadlock where the backend calls QEMU, while QEMU also calls the
backend simultaneously, both ends waiting for each other.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-5-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: f988e3c0c60dd25352281d9c6cf3df18532ca26d
https://github.com/qemu/qemu/commit/f988e3c0c60dd25352281d9c6cf3df18532ca26d
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M ui/gtk.c
Log Message:
-----------
ui: remove extra #ifdef CONFIG_OPENGL
Since commit 5cb69566daa8081abb82a13403dcc0fffed02007 ("gtk: remove
CONFIG_GTK_GL"), some #ifdef are redundants.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-6-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: c110d949b8166a633179edcf3390a42673ac843c
https://github.com/qemu/qemu/commit/c110d949b8166a633179edcf3390a42673ac843c
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/console.h
M include/ui/egl-context.h
M include/ui/sdl2.h
M ui/console.c
M ui/egl-context.c
M ui/egl-headless.c
M ui/gtk.c
M ui/sdl2-gl.c
M ui/sdl2.c
M ui/spice-display.c
Log Message:
-----------
ui: remove gl_ctx_get_current
There are no users left.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-7-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 568b12fccfe5394326df1ce3e10790608d439a37
https://github.com/qemu/qemu/commit/568b12fccfe5394326df1ce3e10790608d439a37
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/gtk.h
M ui/console.c
M ui/gtk-gl-area.c
M ui/gtk.c
Log Message:
-----------
ui: add gd_gl_area_scanout_disable
Require the callback, drop the fallback path.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-8-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 227d8444bb118bc551f324f1046a223cc641b4c6
https://github.com/qemu/qemu/commit/227d8444bb118bc551f324f1046a223cc641b4c6
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/console.h
Log Message:
-----------
ui: annotate DCLOps callback requirements
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-9-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 2cc002483e9cc075896912ebc3ebd3fe86660902
https://github.com/qemu/qemu/commit/2cc002483e9cc075896912ebc3ebd3fe86660902
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/vhost-user-gpu.c
M include/ui/console.h
M ui/console.c
Log Message:
-----------
ui: remove console_has_gl_dmabuf()
This check is currently limited. It only is used by vhost-user-gpu (not
by vfio-display), and will print an error repeatedly during run-time.
We are going to dissociate the GL context from the
DisplayChangeListener, and listeners may come and go. The following
patches will address this differently.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-10-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: ff64d44fb8f6636ece3064f86babe48e3807533d
https://github.com/qemu/qemu/commit/ff64d44fb8f6636ece3064f86babe48e3807533d
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/vhost-user-gpu.c
M include/hw/virtio/virtio-gpu.h
Log Message:
-----------
vhost-user-gpu: add a configuration flag for dmabuf usage
Let's inform VirtioGPUBase that vhost-user-gpu require DMABUF messages.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-11-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: a7dfbe289ede8adb253d735daef88a39709053dc
https://github.com/qemu/qemu/commit/a7dfbe289ede8adb253d735daef88a39709053dc
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/virtio-gpu-base.c
M hw/display/virtio-vga.c
M hw/vfio/display.c
M include/ui/console.h
Log Message:
-----------
ui: add an optional get_flags callback to GraphicHwOps
Those flags can be used to express different requirements for the
display or other needs.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-12-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: d0e137bc9ac9447e669879db4f59eb7f9f961383
https://github.com/qemu/qemu/commit/d0e137bc9ac9447e669879db4f59eb7f9f961383
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/console.h
M ui/console.c
Log Message:
-----------
ui: add a DCLOps callback to check dmabuf support
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-13-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 5983fdf1dcd21f95f1c2b7ecd523140215d99a8e
https://github.com/qemu/qemu/commit/5983fdf1dcd21f95f1c2b7ecd523140215d99a8e
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M ui/console.c
Log Message:
-----------
ui: check hw requirements during DCL registration
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-14-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 0df5c72b3b6e693d2347409b0e3057186c9173a0
https://github.com/qemu/qemu/commit/0df5c72b3b6e693d2347409b0e3057186c9173a0
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/egl-helpers.h
M ui/egl-helpers.c
Log Message:
-----------
ui: add qemu_egl_has_dmabuf helper
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-15-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 52a37e20dbb880ba909e7d0a89e57f77387d25a0
https://github.com/qemu/qemu/commit/52a37e20dbb880ba909e7d0a89e57f77387d25a0
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/gtk.h
M ui/gtk.c
Log Message:
-----------
ui: check gtk-egl dmabuf support
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-16-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 2606519b7492846ddbdf7d2a0b858e4a7ffb0b4d
https://github.com/qemu/qemu/commit/2606519b7492846ddbdf7d2a0b858e4a7ffb0b4d
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M include/ui/gtk.h
M ui/gtk-gl-area.c
M ui/gtk.c
Log Message:
-----------
ui: add egl dmabuf import to gtkglarea
GtkGLArea is used on wayland, where EGL is usually available.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-17-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: f8f3c2719e11145d4f2902c562f7979df741daf0
https://github.com/qemu/qemu/commit/f8f3c2719e11145d4f2902c562f7979df741daf0
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/virtio-gpu.c
M include/hw/virtio/virtio-gpu.h
Log Message:
-----------
virtio-gpu: avoid re-entering cmdq processing
The next patch will notify the GL context got flush, which will resume
the queue processing. However, if this happens within the caller
context, it will end up with a stack overflow flush/update loop.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-18-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 3cddb8b9e0b58eea04e6eb908fc6a12d5af3d3cb
https://github.com/qemu/qemu/commit/3cddb8b9e0b58eea04e6eb908fc6a12d5af3d3cb
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M hw/display/vhost-user-gpu.c
M hw/display/virtio-gpu-base.c
M hw/display/virtio-gpu.c
M hw/display/virtio-vga.c
M include/hw/virtio/virtio-gpu.h
M include/ui/console.h
M ui/console.c
M ui/gtk-egl.c
M ui/gtk-gl-area.c
M ui/sdl2-gl.c
M ui/spice-display.c
Log Message:
-----------
display/ui: add a callback to indicate GL state is flushed
Displaying rendered resources requires blocking qemu GPU to avoid extra
framebuffer copies. For an external display, via Spice currently, there
is a callback to block/unblock the rendering in the same thread.
But with the vhost-user-gpu backend, the qemu process doesn't handle
the rendering itself, and the blocking callback isn't effective.
Instead, the backend must be notified when the display code is done.
Fix this by adding a new GraphicHwOps callback to indicate the GL state
is flushed, and we are done manipulating the shared GL resources. Call
it from gtk and spice display.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-19-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: ebae6477dc43cf32b91564e07a776d9bff3b052f
https://github.com/qemu/qemu/commit/ebae6477dc43cf32b91564e07a776d9bff3b052f
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
M chardev/char-socket.c
Log Message:
-----------
chardev: check if the chardev is registered for yanking
Not all chardevs are created via qmp_chardev_open_socket(), and those
should not call the yank function registration, as this will eventually
assert() not being registered.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-20-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 73240f104dd0169b0637e46fae3c2c39cdfb2eb9
https://github.com/qemu/qemu/commit/73240f104dd0169b0637e46fae3c2c39cdfb2eb9
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: 2021-02-04 (Thu, 04 Feb 2021)
Changed paths:
A tests/acceptance/virtio-gpu.py
Log Message:
-----------
tests: add some virtio-gpu & vhost-user-gpu acceptance test
This will check virtio/vhost-user-vga & virgl are correctly initialized
by the Linux kernel on an egl-headless display.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210204105232.834642-21-marcandre.lureau@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commit: 923abdb4bdfb6d93bfe6c941ead70f3ea6707e40
https://github.com/qemu/qemu/commit/923abdb4bdfb6d93bfe6c941ead70f3ea6707e40
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2021-02-05 (Fri, 05 Feb 2021)
Changed paths:
M chardev/char-socket.c
M contrib/vhost-user-gpu/vhost-user-gpu.c
M contrib/vhost-user-gpu/virgl.c
M contrib/vhost-user-gpu/vugpu.h
M hw/display/qxl-logger.c
M hw/display/qxl-render.c
M hw/display/qxl.c
M hw/display/vhost-user-gpu.c
M hw/display/virtio-gpu-base.c
M hw/display/virtio-gpu.c
M hw/display/virtio-vga.c
M hw/vfio/display.c
M include/hw/virtio/virtio-gpu.h
M include/ui/console.h
M include/ui/egl-context.h
M include/ui/egl-helpers.h
M include/ui/gtk.h
M include/ui/qemu-spice.h
M include/ui/sdl2.h
A tests/acceptance/virtio-gpu.py
M ui/console.c
M ui/egl-context.c
M ui/egl-headless.c
M ui/egl-helpers.c
M ui/gtk-egl.c
M ui/gtk-gl-area.c
M ui/gtk.c
M ui/sdl2-gl.c
M ui/sdl2.c
M ui/spice-core.c
M ui/spice-display.c
Log Message:
-----------
Merge remote-tracking branch
'remotes/kraxel/tags/vga-ui-20210205-pull-request' into staging
ui+virtio-gpu: opengl cleanups and fixes.
qxl+spice: bugfixes
# gpg: Signature made Fri 05 Feb 2021 06:56:04 GMT
# gpg: using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg: aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg: aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901 FE7D 4CB6 D8EE D3E8 7138
* remotes/kraxel/tags/vga-ui-20210205-pull-request: (24 commits)
tests: add some virtio-gpu & vhost-user-gpu acceptance test
chardev: check if the chardev is registered for yanking
display/ui: add a callback to indicate GL state is flushed
virtio-gpu: avoid re-entering cmdq processing
ui: add egl dmabuf import to gtkglarea
ui: check gtk-egl dmabuf support
ui: add qemu_egl_has_dmabuf helper
ui: check hw requirements during DCL registration
ui: add a DCLOps callback to check dmabuf support
ui: add an optional get_flags callback to GraphicHwOps
vhost-user-gpu: add a configuration flag for dmabuf usage
ui: remove console_has_gl_dmabuf()
ui: annotate DCLOps callback requirements
ui: add gd_gl_area_scanout_disable
ui: remove gl_ctx_get_current
ui: remove extra #ifdef CONFIG_OPENGL
vhost-user-gpu: handle display-info in a callback
vhost-user-gpu: use an extandable state enum for commands
vhost-user-gpu: handle vhost-user-gpu features in a callback
vhost-user-gpu: check backend for EDID support
...
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/2c6df9879657...923abdb4bdfb