qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] d7bedd: MAINTAINERS: Add Vladimir as co-maint


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] d7bedd: MAINTAINERS: Add Vladimir as co-maintainer for Blo...
Date: Tue, 02 Feb 2021 08:48:35 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: d7beddcc024f90da6375c1694b805fc282c79402
      
https://github.com/qemu/qemu/commit/d7beddcc024f90da6375c1694b805fc282c79402
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic engine and backup-top filter
landed upstream, great thanks to reviewers and especially to
Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that
we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into
"Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
qemu-co-shared-resource can be reused somewhere else, but I'd keep an
eye on them in context of block-jobs) and add myself as co-maintainer.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210128144144.27617-1-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 722d8e73d65cb54f39d360ecb2147ac58f43c399
      
https://github.com/qemu/qemu/commit/722d8e73d65cb54f39d360ecb2147ac58f43c399
  Author: Sergio Lopez <slp@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M block.c

  Log Message:
  -----------
  block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Some graphs may contain an indirect reference to the first BDS in the
chain that can be reached while walking it bottom->up from one its
children.

Doubling-processing of a BDS is especially problematic for the
aio_notifiers, as they might attempt to work on both the old and the
new AIO contexts.

To avoid this problem, add every child and parent to the ignore list
before actually processing them.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Sergio Lopez <slp@redhat.com>
Message-Id: <20210201125032.44713-2-slp@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 1895b977f9a69419ae45cfc25805f71efae32eaf
      
https://github.com/qemu/qemu/commit/1895b977f9a69419ae45cfc25805f71efae32eaf
  Author: Sergio Lopez <slp@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M block.c
    M qemu-nbd.c
    M softmmu/runstate.c
    M storage-daemon/qemu-storage-daemon.c

  Log Message:
  -----------
  block: move blk_exp_close_all() to qemu_cleanup()

Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
bdrv_drain_all_begin().

Export drivers may have coroutines yielding at some point in the block
layer, so we need to shut them down before draining the block layer,
as otherwise they may get stuck blk_wait_while_drained().

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1900505
Signed-off-by: Sergio Lopez <slp@redhat.com>
Message-Id: <20210201125032.44713-3-slp@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: d0bc412302e6f32e65835a83ddefa656c7d7e9ba
      
https://github.com/qemu/qemu/commit/d0bc412302e6f32e65835a83ddefa656c7d7e9ba
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/pylintrc

  Log Message:
  -----------
  iotests/297: pylint: ignore too many statements

Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.

Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210129161323.615027-1-vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: ca502ca60dab85b11a7fad5978ab3de94c296fb6
      
https://github.com/qemu/qemu/commit/ca502ca60dab85b11a7fad5978ab3de94c296fb6
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/testenv.py

  Log Message:
  -----------
  iotests: Revert emulator selection to old behaviour

If the qemu-system-{arch} binary for the host architecture can't be
found, the old 'check' implementation selected the alphabetically first
system emulator binary that it could find. The new Python implementation
just uses the first result of glob.iglob(), which has an undefined
order.

This is a problem that breaks CI because the iotests aren't actually
prepared to run on any emulator. They should be, so this is really a bug
in the failing test cases that should be fixed there, but as a quick
fix, let's revert to the old behaviour to let CI runs succeed again.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210202142802.119999-1-kwolf@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 3ae50942f161e2e8fa6ecd69a9c17b681d419905
      
https://github.com/qemu/qemu/commit/3ae50942f161e2e8fa6ecd69a9c17b681d419905
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/check
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  iotests: check: return 1 on failure

We should indicate failure by exit code, not only output.

Reported-by: Peter Maydell
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210201085041.3079-1-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 0212fa2afd1e20c590f740036f5cb837e1177d53
      
https://github.com/qemu/qemu/commit/0212fa2afd1e20c590f740036f5cb837e1177d53
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  iotests: Fix -makecheck output

For -makecheck, the old 'check' implementation skipped the output when
starting a test. It only had the condensed output at the end of a test.

testrunner.py prints the normal output when starting a test even for
-makecheck. This output contains '\r' at the end so that it can be
overwritten with the result at the end of the test. However, for
-makecheck this is shorter output in a different format, so effectively
we end up with garbled output that mixes both output forms.

Revert to the old behaviour of only printing a message after the test
had completed in -makecheck mode.

Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210201161024.127921-1-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 97b709f32ed10a6cd63c3a41755245ec323eedbd
      
https://github.com/qemu/qemu/commit/97b709f32ed10a6cd63c3a41755245ec323eedbd
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M block/nvme.c

  Log Message:
  -----------
  block/nvme: Properly display doorbell stride length in trace event

Commit 15b2260bef3 ("block/nvme: Trace controller capabilities")
misunderstood the doorbell stride value from the datasheet, use
the correct one. The 'doorbell_scale' variable used few lines
later is correct.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210127212137.3482291-2-philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: fcc8672aca2902055c03ef79e4c9fcfad0227b70
      
https://github.com/qemu/qemu/commit/fcc8672aca2902055c03ef79e4c9fcfad0227b70
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M block/nvme.c
    M block/trace-events

  Log Message:
  -----------
  block/nvme: Trace NVMe spec version supported by the controller

NVMe controllers implement different versions of the spec,
and different features of it. It is useful to gather this
information when debugging.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210127212137.3482291-3-philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 26513a01741f51650f5dd716681995359794ba6f
      
https://github.com/qemu/qemu/commit/26513a01741f51650f5dd716681995359794ba6f
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M block/qapi.c

  Log Message:
  -----------
  block: Fix VM size column width in bdrv_snapshot_dump()

size_to_str() can return a size like "4.24 MiB", with a single digit
integer part and two fractional digits. This is eight characters, but
commit b39847a5 changed the format string to only reserve seven
characters for the column.

This can result in unaligned columns, which in turn changes the output of
iotests case 267 because exceeding the column size defeats the attempt
to filter the size out of the output (observed with the ppc64 emulator).
The resulting change is only a whitespace change, but since commit
f203080b this is enough for iotests to consider the test failed.

Taking a character away from the tag name column and adding it to the VM
size column doesn't change anything in the common case (the tag name is
left justified, the VM size is right justified), but fixes this case.

Fixes: b39847a50553b7679d6d7fefbe6a108a17aacf8d
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210202155911.179865-1-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 77f3804ab7ed94b471a14acb260e5aeacf26193f
      
https://github.com/qemu/qemu/commit/77f3804ab7ed94b471a14acb260e5aeacf26193f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M MAINTAINERS
    M block.c
    M block/nvme.c
    M block/qapi.c
    M block/trace-events
    M qemu-nbd.c
    M softmmu/runstate.c
    M storage-daemon/qemu-storage-daemon.c
    M tests/qemu-iotests/check
    M tests/qemu-iotests/pylintrc
    M tests/qemu-iotests/testenv.py
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging

Block layer patches:

- Fix double processing of nodes in bdrv_set_aio_context()
- Fix potential hang in block export shutdown
- block/nvme: Minor tracing improvements
- iotests: Some more fixups for the 'check' rewrite
- MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

# gpg: Signature made Tue 02 Feb 2021 16:26:02 GMT
# gpg:                using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
# gpg:                issuer "kwolf@redhat.com"
# gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>" [full]
# Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6

* remotes/kevin/tags/for-upstream:
  block: Fix VM size column width in bdrv_snapshot_dump()
  block/nvme: Trace NVMe spec version supported by the controller
  block/nvme: Properly display doorbell stride length in trace event
  iotests: Fix -makecheck output
  iotests: check: return 1 on failure
  iotests: Revert emulator selection to old behaviour
  iotests/297: pylint: ignore too many statements
  block: move blk_exp_close_all() to qemu_cleanup()
  block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()
  MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/f62a96bc73b5...77f3804ab7ed



reply via email to

[Prev in Thread] Current Thread [Next in Thread]