[Qemu-commits] [qemu/qemu] d23972: Revert "vnc: move initialization to framebuffer_up...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d239726c53fd9d3b5e6a89c5a22ed57d8ab0a9aa
      
https://github.com/qemu/qemu/commit/d239726c53fd9d3b5e6a89c5a22ed57d8ab0a9aa
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  Revert "vnc: move initialization to framebuffer_update_request"

This reverts commit 9e1632ad07ca49de99da4bb231e9e2f22f2d8df5.

Older gtk-vnc versions can't deal with non-incremental update
requests sending pseudo-encodings, so trying to send full server
state (including desktop size, cursor etc. which is done using
pseudo-encodings) doesn't fly.  Return to old behavior to send
those only for new connects and when changes happen.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210125104041.495274-2-kraxel@redhat.com>


  Commit: 104b8d193248032bb3357ef7f6f2f2dd5824731e
      
https://github.com/qemu/qemu/commit/104b8d193248032bb3357ef7f6f2f2dd5824731e
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: send extended desktop resize on update requests

Unlike other pseudo-encodings these don't break gtk-vnc
because older versions don't suport the extended desktop
resize extension in the first place.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Tested-by: Laszlo Ersek <lersek@redhat.com>
Message-Id: <20210125104041.495274-3-kraxel@redhat.com>


  Commit: 15b08119add1e49ccbc7f7d6b3a04932d2430d7e
      
https://github.com/qemu/qemu/commit/15b08119add1e49ccbc7f7d6b3a04932d2430d7e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M hw/display/vmware_vga.c

  Log Message:
  -----------
  hw/display/vmware_vga: Remove dependency on VNC header

In commit 2f487a3d40faff1 we fixed a problem observed with using the
vmware-vga device and the VNC UI frontend in a belt-and-braces
manner:
 * we made the VNC frontend handle non-multiple-of-16 surface widths
 * we rounded up the vmware-vga display width to a multiple of 16

However this introduced a spurious dependency of a device model on a
UI frontend header.  vmware-vga isn't special and should not care
about what UI frontend it is using, and the VNC frontend needs to
handle arbitrary surface widths because other display device models
could use them.  Moreover, even if the maximum width in vmware-vga is
made a multiple of 16, the guest itself can always program a
different width.

Remove the dependency on the VNC header.  Since we have been using
the rounded-up width value since 2014, stick with it rather than
introducing a behaviour change, but don't calculate it by rounding up
to VNC_DIRTY_BITS_PER_PIXEL any more.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20210112161608.16055-1-peter.maydell@linaro.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 091f255b89e818b84cd003c1da552b6dc3fe3cbd
      
https://github.com/qemu/qemu/commit/091f255b89e818b84cd003c1da552b6dc3fe3cbd
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-01-28 (Thu, 28 Jan 2021)

  Changed paths:
    M hw/display/vmware_vga.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210127-pull-request' 
into staging

vnc: fix gtk-vnc compatibility issues.
vnc: vmware svga cleanup

# gpg: Signature made Wed 27 Jan 2021 11:00:59 GMT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20210127-pull-request:
  hw/display/vmware_vga: Remove dependency on VNC header
  vnc: send extended desktop resize on update requests
  Revert "vnc: move initialization to framebuffer_update_request"

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/af47e82269f4...091f255b89e8