qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 4762c8: tests/docker: Install static libc pac


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 4762c8: tests/docker: Install static libc package in CentOS 7
Date: Thu, 28 Jan 2021 02:46:39 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4762c82cbda22b1036ce9dd2c5e951ac0ed0a7d3
      
https://github.com/qemu/qemu/commit/4762c82cbda22b1036ce9dd2c5e951ac0ed0a7d3
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M tests/docker/dockerfiles/centos7.docker

  Log Message:
  -----------
  tests/docker: Install static libc package in CentOS 7

We need to install the static libc package to be able to run
the TCG tests:

  $ make check-tcg
  ...
    BUILD   TCG tests for x86_64-softmmu
    BUILD   x86_64-softmmu guest-tests with cc
  /usr/bin/ld: hello: warning: allocated section `.notes' not in segment
  /usr/bin/ld: memory: warning: allocated section `.notes' not in segment
    BUILD   TCG tests for x86_64-linux-user
    BUILD   x86_64-linux-user guest-tests with cc
  /usr/bin/ld: cannot find -lpthread
  /usr/bin/ld: cannot find -lc
  collect2: error: ld returned 1 exit status
  make[2]: *** [threadcount] Error 1
  make[1]: *** [cross-build-guest-tests] Error 2
  make: *** [build-tcg-tests-x86_64-linux-user] Error 2

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210121172829.1643620-2-f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 4e41d4a34e4d9f11a99a03c2279f84e98df21984
      
https://github.com/qemu/qemu/commit/4e41d4a34e4d9f11a99a03c2279f84e98df21984
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Test building linux-user targets on CentOS 7

Add a configuration tested by Peter Maydell (see [1] and [2])
but not covered in our CI [3]:

  [705/2910] Compiling C object 
libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
  FAILED: libqemu-arm-linux-user.fa.p/linux-user_strace.c.o
  ../linux-user/strace.c: In function 'do_print_sockopt':
  ../linux-user/strace.c:2831:14: error: 'IPV6_ADDR_PREFERENCES' undeclared 
(first use in this function)
           case IPV6_ADDR_PREFERENCES:
                ^

This job currently takes 31 minutes 32 seconds ([4]).

[1] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05086.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg05379.html
[3] https://gitlab.com/philmd/qemu/-/jobs/977408284
[4] https://gitlab.com/philmd/qemu/-/jobs/978223286

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210121172829.1643620-3-f4bug@amsat.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: db0108d5d846e9a83545cb8f78444100a8686acb
      
https://github.com/qemu/qemu/commit/db0108d5d846e9a83545cb8f78444100a8686acb
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M .gitlab-ci.yml
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-amd64.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu2004.docker

  Log Message:
  -----------
  gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit

Since the meson build system rework, the configure script prefers the
git submodules over the system libraries. So we are testing compilation
with capstone, fdt and libslirp as a submodule all over the place,
burning CPU cycles by recompiling these third party modules and wasting
some network bandwidth in the CI by cloning the submodules each time.
Let's stop doing that in at least a couple of jobs and use the system
libraries instead.

While we're at it, also install meson in the Fedora container, since
it is new enough already, so we do not need to check out the meson
submodule here.

Message-Id: <20210121174451.658924-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 90520ee4ca53e51e35df1e82c0068067f662882e
      
https://github.com/qemu/qemu/commit/90520ee4ca53e51e35df1e82c0068067f662882e
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Only check for audio drivers if system-mode is selected

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210122204441.2145197-2-philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 610e7e0e69b2d8b1d153112c35ce87a4bc5176b2
      
https://github.com/qemu/qemu/commit/610e7e0e69b2d8b1d153112c35ce87a4bc5176b2
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2021-01-26 (Tue, 26 Jan 2021)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson: Do not build optional libraries by default

The following libraries will be selected if a feature requires it:

- capstone
- fdt
- SLiRP

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210122204441.2145197-5-philmd@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 8cd95aec4c205f0285b378f36648e9f1654dd954
      
https://github.com/qemu/qemu/commit/8cd95aec4c205f0285b378f36648e9f1654dd954
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci.yml: Exclude some redundant targets in 
build-without-default-features

The build-without-default-features job is running quite long and sometimes
already hits the 1h time limit. Exclude some targets which do not provide
additional test coverage here (since we e.g. also already test other targets
of the same type, just with different endianess, or a 64-bit superset) to
avoid that we hit the timeout here so easily.

Message-Id: <20210126172345.15947-1-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 12a917a14fb3cb01538c7e85d4569cd97f272281
      
https://github.com/qemu/qemu/commit/12a917a14fb3cb01538c7e85d4569cd97f272281
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci.yml: Avoid recompiling the sources in the test jobs

Currently, our check-system-* jobs are recompiling the whole sources
again. This happens due to the fact that the jobs are checking out
the whole source tree and required submodules again, and only try
to use the "build" directory with the binaries and object files as an
artifact from the previous stage - which simply does not work right
anymore (with the current version of meson). Due to some changed
time stamps, meson/ninja are always trying to rebuild the whole tree.

In the long run, we could likely use "meson test --no-rebuild", but
there is still some work going on in that area to improve the user
experience. So until this has been done, simply avoid recompiling the
sources with a trick: pass NINJA=":" to the make process in the test
jobs. Also check out the submodules manually before updating the
timestamps in the build folder, so that the binaries are definitely
newer that all the source files.
This saves ca. 10 - 15 minutes of precious CI cycles in each run.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20210126065757.403853-1-thuth@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: cf5891ec534e5418cf613cf9634160f911dadc50
      
https://github.com/qemu/qemu/commit/cf5891ec534e5418cf613cf9634160f911dadc50
  Author: Wainer dos Santos Moschetta <wainersm@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M docs/devel/testing.rst

  Log Message:
  -----------
  docs/devel: Explain how acceptance tests can be skipped

Documented under the "Acceptance tests using the Avocado Framework"
section in testing.rst how environment variables are used to skip tests.

Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210115210022.417996-1-wainersm@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f8a9b4c66569cbc1640722369a91c635102b5264
      
https://github.com/qemu/qemu/commit/f8a9b4c66569cbc1640722369a91c635102b5264
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  libqtest: Rework qtest_rsp()

qtest_rsp() is used in two different ways: (1) return some arguments
to caller, which the caller must free, and (2) return no arguments to
caller.  Passing non-zero @expected_args gets you (1), and passing
zero gets you (2).

Having "the return value must be freed" depend on an argument this way
is less than ideal.

Provide separate functions for the two ways: (1) qtest_rsp_args()
takes @expected_args (possibly zero), and returns that number of
arguments.  Caller must free the return value always.  (2) qtest_rsp()
assumes zero, and returns nothing.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210126151649.2220902-1-armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: af47e82269f447b36549384323013765efd7e01c
      
https://github.com/qemu/qemu/commit/af47e82269f447b36549384323013765efd7e01c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-01-27 (Wed, 27 Jan 2021)

  Changed paths:
    M .gitlab-ci.yml
    M configure
    M docs/devel/testing.rst
    M meson.build
    M tests/docker/dockerfiles/centos7.docker
    M tests/docker/dockerfiles/centos8.docker
    M tests/docker/dockerfiles/debian-amd64.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2021-01-27' into staging

* Patches to speed up and improve the gitlab-CI
* Documentation for the decorators in the "acceptance" tests
* One small rework of a libqtest function

# gpg: Signature made Wed 27 Jan 2021 06:22:11 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2021-01-27:
  libqtest: Rework qtest_rsp()
  docs/devel: Explain how acceptance tests can be skipped
  gitlab-ci.yml: Avoid recompiling the sources in the test jobs
  gitlab-ci.yml: Exclude some redundant targets in 
build-without-default-features
  meson: Do not build optional libraries by default
  configure: Only check for audio drivers if system-mode is selected
  gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit
  gitlab-ci: Test building linux-user targets on CentOS 7
  tests/docker: Install static libc package in CentOS 7

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/bf159f0bdc7b...af47e82269f4



reply via email to

[Prev in Thread] Current Thread [Next in Thread]