qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ef2663: sdlaudio: remove leftover SDL1.2 code


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] ef2663: sdlaudio: remove leftover SDL1.2 code
Date: Sat, 16 Jan 2021 05:05:23 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ef26632e3a2b4c7b963ed17e5cc5731ca9e1c5ba
      
https://github.com/qemu/qemu/commit/ef26632e3a2b4c7b963ed17e5cc5731ca9e1c5ba
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: remove leftover SDL1.2 code

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-1-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ff69c481a2ad28e1cac87f921d42fbdfa950b77e
      
https://github.com/qemu/qemu/commit/ff69c481a2ad28e1cac87f921d42fbdfa950b77e
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/alsaaudio.c
    M audio/sdlaudio.c

  Log Message:
  -----------
  audio: fix bit-rotted code

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-2-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 5a0926c23fa915f26f66f688e9030ce39fea1e35
      
https://github.com/qemu/qemu/commit/5a0926c23fa915f26f66f688e9030ce39fea1e35
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio.c
    M audio/audio_legacy.c
    M audio/audio_template.h
    M audio/sdlaudio.c
    M qapi/audio.json
    M qemu-options.hx

  Log Message:
  -----------
  sdlaudio: add -audiodev sdl,out.buffer-count option

Currently there is a crackling noise with SDL2 audio playback.
Commit bcf19777df: "audio/sdlaudio: Allow audio playback with
SDL2" already mentioned the crackling noise.

Add an out.buffer-count option to give users a chance to select
sane settings for glitch free audio playback. The idea was taken
from the coreaudio backend.

The in.buffer-count option will be used with one of the next
patches.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Acked-by: Markus Armbruster <armbru@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-3-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 14cefe14bb6450fb8e5b6b1eadd3631c150f119c
      
https://github.com/qemu/qemu/commit/14cefe14bb6450fb8e5b6b1eadd3631c150f119c
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: don't start playback in init routine

Every emulated audio device has a way to enable audio playback. Don't
start playback until the guest enables the audio device. This patch
keeps the SDL2 device pause state in sync with hw->enabled.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Thomas Huth <thuth@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-4-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bcce2ea5f63bb5eedfa6c4872f3a4b8a84ff9f07
      
https://github.com/qemu/qemu/commit/bcce2ea5f63bb5eedfa6c4872f3a4b8a84ff9f07
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: always clear the sample buffer

Always fill the remaining audio callback buffer with silence.
SDL 2.0 doesn't initialize the audio callback buffer. This was
an incompatible change compared to SDL 1.2. For reference read
the SDL 1.2 to 2.0 migration guide.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-5-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: e02d178f78d7cff93c3c9b7e3c3ac6822c46c563
      
https://github.com/qemu/qemu/commit/e02d178f78d7cff93c3c9b7e3c3ac6822c46c563
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: fill remaining sample buffer with silence

Fill the remaining sample buffer with silence. To fill it with
zeroes is wrong for unsigned samples because this is silence
with a DC bias.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-6-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ce31f099fba5ac72834fc96ae6edc41713275989
      
https://github.com/qemu/qemu/commit/ce31f099fba5ac72834fc96ae6edc41713275989
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: replace legacy functions with modern ones

With the modern audio functions it's possible to add new
features like audio recording.

As a side effect this patch fixes a bug where SDL2 can't be used
on Windows. This bug was reported on the qemu-devel mailing list at

https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg04043.html

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-7-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: a2893c8303e05dda92291487949b611aa361a039
      
https://github.com/qemu/qemu/commit/a2893c8303e05dda92291487949b611aa361a039
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio_int.h
    M audio/jackaudio.c
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/spiceaudio.c

  Log Message:
  -----------
  audio: split pcm_ops function get_buffer_in

Split off pcm_ops function run_buffer_in from get_buffer_in and
call run_buffer_in before get_buffer_in.

The next patch only needs the generic buffer management part
from audio_generic_get_buffer_in().

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-8-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: c2031dea894ed189e947a31dde15ffc4755030f9
      
https://github.com/qemu/qemu/commit/c2031dea894ed189e947a31dde15ffc4755030f9
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: add recording functions

Add audio recording functions. SDL 2.0.5 or later is required to
use the recording functions. Playback continues to work with
earlier SDL 2.0 versions.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-9-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 1d8549ad5e0fa1ac0d989884882061b83da46d27
      
https://github.com/qemu/qemu/commit/1d8549ad5e0fa1ac0d989884882061b83da46d27
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: break generic buffer dependency on mixing-engine

Break the unnecessary dependency of the generic buffer management
code on mixing-engine. This is required for the next patch.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-10-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bd37ede4ebd4b862fbd244750c73cf55a8facced
      
https://github.com/qemu/qemu/commit/bd37ede4ebd4b862fbd244750c73cf55a8facced
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/sdlaudio.c

  Log Message:
  -----------
  sdlaudio: enable (in|out).mixing-engine=off

Enable the SDL2 backend options -audiodev sdl,out.mixing-
engine=off,in.mixing-engine=off.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-11-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6fb0cd50541465114d8dd868bef8463e4edf7522
      
https://github.com/qemu/qemu/commit/6fb0cd50541465114d8dd868bef8463e4edf7522
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: remove remaining unused plive code

Commit 73ad33ef7b "audio: remove plive" forgot to remove this code.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-12-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: bea29e9f2ea6061abc212809090548cba6d64081
      
https://github.com/qemu/qemu/commit/bea29e9f2ea6061abc212809090548cba6d64081
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: avoid to clip samples multiple times

The pulseaudio backend currently converts, clips and copies audio
playback samples in the mixing-engine sample buffer multiple
times.

In qpa_get_buffer_out() the function pa_stream_begin_write()
returns a rather large buffer and this allows audio_pcm_hw_run_out()
in audio/audio.c to copy all samples in the mixing-engine buffer
to the pulse audio buffer. Immediately after copying, qpa_write()
notices with a call to pa_stream_writable_size() that pulse audio
only needs a smaller part of the copied samples and ignores the
rest. This copy and ignore process happens several times for each
audio sample.

To fix this behaviour, call pa_stream_writable_size() in
qpa_get_buffer_out() to limit the number of samples
audio_pcm_hw_run_out() will convert. With this change the
pulseaudio pcm_ops functions put_buffer_out and write are no
longer identical and a separate qpa_put_buffer_out is needed.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-13-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: e270c548262c8c7870ed04a443032a1816fde18b
      
https://github.com/qemu/qemu/commit/e270c548262c8c7870ed04a443032a1816fde18b
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: wait for PA_STREAM_READY in qpa_write()

Don't call pa_stream_writable_size() in qpa_write() before the
playback stream is ready. This prevents a lot of the following
pulseaudio error messages.

pulseaudio: pa_stream_writable_size failed
pulseaudio: Reason: Bad state

To reproduce start qemu with
-parallel none -device gus,audiodev=audio0
-audiodev pa,id=audio0,out.mixing-engine=off

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-14-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 7007cd3fc89f6357db8f4d3161c02d3af2274c33
      
https://github.com/qemu/qemu/commit/7007cd3fc89f6357db8f4d3161c02d3af2274c33
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: wait until the playback stream is ready

Don't call pa_stream_writable_size() in qpa_get_buffer_out()
before the playback stream is ready. This prevents a lot of the
following pulseaudio error messages.

pulseaudio: pa_stream_writable_size failed
pulseaudio: Reason: Bad state

To reproduce start qemu with
-parallel none -device gus,audiodev=audio0 -audiodev pa,id=audio0

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-15-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 521ce7142515c99f02eaf1db2b8480ba50087988
      
https://github.com/qemu/qemu/commit/521ce7142515c99f02eaf1db2b8480ba50087988
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: remove unneeded code

Commit baea032ec7 "audio/paaudio: fix ignored buffer_length setting"
added code to handle buffer_length defaults. This was unnecessary
because the audio_buffer_* functions in audio/audio.c already handle
this. Remove the unneeded code.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-16-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: cffd2fdf2c121804ac97a43f051a8d8cd71508b4
      
https://github.com/qemu/qemu/commit/cffd2fdf2c121804ac97a43f051a8d8cd71508b4
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: comment bugs in functions qpa_init_*

The audio buffer size in audio/paaudio.c is typically larger
than expected. Just comment the bugs in qpa_init_in() and
qpa_init_out() for now. Fixing these bugs may break glitch free
audio playback with fine tuned user audio settings.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-17-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 00413ed9c2fff416b3c1ee94b2e968e9c564c7bd
      
https://github.com/qemu/qemu/commit/00413ed9c2fff416b3c1ee94b2e968e9c564c7bd
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: limit minreq to 75% of audio timer_rate

Currently with the playback buffer attribute minreq = -1 and flag
PA_STREAM_EARLY_REQUESTS PulseAudio uses minreq = tlength / 4.
To improve audio playback with larger PulseAudio server side
buffers, limit minreq to a maximum of 75% of audio timer_rate.
That way there is a good chance qemu receives a stream buffer
size update before it tries to write data to the playback stream.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-18-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: d9a8b27a7e9b6467ff1709ae8a44d816d90c4d71
      
https://github.com/qemu/qemu/commit/d9a8b27a7e9b6467ff1709ae8a44d816d90c4d71
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  paaudio: send recorded data in smaller chunks

Tell PulseAudio to send recorded audio data in smaller chunks
than timer_period, so there's a good chance that qemu can read
recorded audio data every time it looks for new data.

PulseAudio tries to send buffer updates at a fragsize / 2 rate.
With fragsize = timer_period / 2 * 3 the update rate is 75% of
timer_period. The lower limit for the recording buffer size
maxlength is fragsize * 2.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-19-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 401dcf0540a1b26e88bf04da2dac583078ad7da6
      
https://github.com/qemu/qemu/commit/401dcf0540a1b26e88bf04da2dac583078ad7da6
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/dsound_template.h
    M audio/dsoundaudio.c

  Log Message:
  -----------
  dsoundaudio: replace GetForegroundWindow()

GetForegroundWindow() doesn't necessarily return the own window
handle. It just returns a handle to the currently active window
and can even return NULL. At the time dsound_open() gets called
the active window is most likely the shell window and not the
QEMU window.

Replace GetForegroundWindow() with GetDesktopWindow() which
always returns a valid window handle, and at the same time
replace the DirectSound buffer flag DSBCAPS_STICKYFOCUS with
DSBCAPS_GLOBALFOCUS where Windows only expects a valid window
handle for DirectSound function SetCooperativeLevel(). The
Microsoft online docs for IDirectSound::SetCooperativeLevel
recommend this in the remarks.

This fixes a bug where you can't hear sound from the guest.

To reproduce start qemu with -machine pcspk-audiodev=audio0
-device intel-hda -device hda-duplex,audiodev=audio0
-audiodev dsound,id=audio0,out.mixing-engine=off
from a shell and start audio playback with the hda device in the
guest. The guest will be silent. To hear guest audio you have to
activate the shell window once.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-20-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 3c18e43179c2b8c56236bd34e990e7facf21a7b4
      
https://github.com/qemu/qemu/commit/3c18e43179c2b8c56236bd34e990e7facf21a7b4
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/dsoundaudio.c

  Log Message:
  -----------
  dsoundaudio: rename dsound_open()

Rename dsound_open() to dsound_set_cooperative_level(). The
only task of that function is to set the cooperative level for
DirectSound.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-21-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 1157506161e4dcee5a8681618b3b3e41f759b323
      
https://github.com/qemu/qemu/commit/1157506161e4dcee5a8681618b3b3e41f759b323
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio_win_int.c

  Log Message:
  -----------
  dsoundaudio: enable f32 audio sample format

Enable the f32 audio sample format for the DirectSound backend.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-22-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 2d96a0058709067d417425743d5ed5fbff6c1b54
      
https://github.com/qemu/qemu/commit/2d96a0058709067d417425743d5ed5fbff6c1b54
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio_win_int.c

  Log Message:
  -----------
  dsoundaudio: fix log message

There is a mismatch between message and used argument. Change
the argument from frequency to format.

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 9315afe5-5958-c0b4-ea1e-14769511a9d5@t-online.de
Message-Id: <20210110100239.27588-23-vr_qemu@t-online.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 6c6886bd01dcbdc47287ac5fbdaf89a8f49bc35f
      
https://github.com/qemu/qemu/commit/6c6886bd01dcbdc47287ac5fbdaf89a8f49bc35f
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio_template.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/ossaudio.c

  Log Message:
  -----------
  audio: Add braces for statements/fix braces' position

Fix problems about braces:
-braces are necessary for all arms of if/for/while statements
-else should follow close brace '}'

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-2-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 3c8de96c074c035cb9f3e021769e4c8872d81268
      
https://github.com/qemu/qemu/commit/3c8de96c074c035cb9f3e021769e4c8872d81268
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio_template.h
    M audio/coreaudio.c
    M audio/dsoundaudio.c
    M audio/jackaudio.c

  Log Message:
  -----------
  audio: Add spaces around operator/delete redundant spaces

Fix problems about spaces:
-operator needs spaces around it, add them.
-somespaces are redundant, remove them.

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-3-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: dcf10e409570eaa5c6b3227f8b8251c5f5bbb156
      
https://github.com/qemu/qemu/commit/dcf10e409570eaa5c6b3227f8b8251c5f5bbb156
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/coreaudio.c

  Log Message:
  -----------
  audio: foo* bar" should be "foo *bar".

transfer "foo* " to "foo *"

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-4-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: c60840c758cea0cae729d41b0808a4abb7e1dff6
      
https://github.com/qemu/qemu/commit/c60840c758cea0cae729d41b0808a4abb7e1dff6
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/dsoundaudio.c

  Log Message:
  -----------
  audio: Fix lines over 90 characters

Fix the line width of code.

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-5-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: dea7d84fcf51b24f9ff485a50cf76542b841728e
      
https://github.com/qemu/qemu/commit/dea7d84fcf51b24f9ff485a50cf76542b841728e
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/dsoundaudio.c

  Log Message:
  -----------
  audio: Don't use '%#' in format strings

Use '0x' prefix instead of '%#'

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-6-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 289db3c5a282c8a28322a4fa7b773e123ffb03a9
      
https://github.com/qemu/qemu/commit/289db3c5a282c8a28322a4fa7b773e123ffb03a9
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  audio: Suspect code indent for conditional statements

Fix code indent.

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-7-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 8abf3feb4d464abadd5133d8810c8a3232cbbe6e
      
https://github.com/qemu/qemu/commit/8abf3feb4d464abadd5133d8810c8a3232cbbe6e
  Author: Zhang Han <zhanghan64@huawei.com>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/audio_template.h

  Log Message:
  -----------
  audio: space prohibited between function name and parenthesis'('

Delete spaces between function name and open parenthesis'('

Signed-off-by: Zhang Han <zhanghan64@huawei.com>
Message-id: 20210115012431.79533-1-zhanghan64@huawei.com
Message-Id: <20210115012431.79533-8-zhanghan64@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 825a215c003cd028e26c7d19aa5049d957345f43
      
https://github.com/qemu/qemu/commit/825a215c003cd028e26c7d19aa5049d957345f43
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-01-15 (Fri, 15 Jan 2021)

  Changed paths:
    M audio/alsaaudio.c
    M audio/audio.c
    M audio/audio_int.h
    M audio/audio_legacy.c
    M audio/audio_template.h
    M audio/audio_win_int.c
    M audio/coreaudio.c
    M audio/dsound_template.h
    M audio/dsoundaudio.c
    M audio/jackaudio.c
    M audio/noaudio.c
    M audio/ossaudio.c
    M audio/paaudio.c
    M audio/sdlaudio.c
    M audio/spiceaudio.c
    M qapi/audio.json
    M qemu-options.hx

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/audio-20210115-pull-request' into staging

audio: improvements for sdl, pulse, fsound.
audio: cleanups & codestyle fixes.

# gpg: Signature made Fri 15 Jan 2021 13:20:56 GMT
# gpg:                using RSA key A0328CFFB93A17A79901FE7D4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/audio-20210115-pull-request: (30 commits)
  audio: space prohibited between function name and parenthesis'('
  audio: Suspect code indent for conditional statements
  audio: Don't use '%#' in format strings
  audio: Fix lines over 90 characters
  audio: foo* bar" should be "foo *bar".
  audio: Add spaces around operator/delete redundant spaces
  audio: Add braces for statements/fix braces' position
  dsoundaudio: fix log message
  dsoundaudio: enable f32 audio sample format
  dsoundaudio: rename dsound_open()
  dsoundaudio: replace GetForegroundWindow()
  paaudio: send recorded data in smaller chunks
  paaudio: limit minreq to 75% of audio timer_rate
  paaudio: comment bugs in functions qpa_init_*
  paaudio: remove unneeded code
  paaudio: wait until the playback stream is ready
  paaudio: wait for PA_STREAM_READY in qpa_write()
  paaudio: avoid to clip samples multiple times
  audio: remove remaining unused plive code
  sdlaudio: enable (in|out).mixing-engine=off
  ...

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7cb6b97300f0...825a215c003c



reply via email to

[Prev in Thread] Current Thread [Next in Thread]