qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 102484: s390x: pv: Fence additional unavailab


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 102484: s390x: pv: Fence additional unavailable SCLP facil...
Date: Fri, 01 Jan 2021 10:44:57 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 10248418b4bd01e18dc5cb4333e19f0b65338faf
      
https://github.com/qemu/qemu/commit/10248418b4bd01e18dc5cb4333e19f0b65338faf
  Author: Janosch Frank <frankja@linux.ibm.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M target/s390x/cpu_features.c
    M target/s390x/cpu_models.c

  Log Message:
  -----------
  s390x: pv: Fence additional unavailable SCLP facilities for PV guests

There's no VSIE support for a protected guest, so let's better not
advertise it and its support facilities.

Fixes: c3347ed0d2ee ("s390x: protvirt: Support unpack facility")
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20201211105109.2913-1-frankja@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 99eaf137f4bc709c6a998a250d233a6944293941
      
https://github.com/qemu/qemu/commit/99eaf137f4bc709c6a998a250d233a6944293941
  Author: Cornelia Huck <cohuck@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: move my git tree to gitlab

I push to gitlab anyway to get some CI coverage, so let's make
it my primary tree to avoid workflow duplication.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Acked-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201214132628.56019-1-cohuck@redhat.com>


  Commit: 5b723a5d8df44b69b8ba350e643059c8fd889315
      
https://github.com/qemu/qemu/commit/5b723a5d8df44b69b8ba350e643059c8fd889315
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M qga/commands-posix.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga/commands-posix: Send CCW address on s390x with the fsinfo data

We need the CCW address on the libvirt side to correctly identify
the disk, so add this information to the GuestDiskAddress on s390x.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Michael Roth <michael.roth@amd.com>
Message-Id: <20201127082353.448251-1-thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: ff26d287bddc189fd5a084cc96078da1257b0826
      
https://github.com/qemu/qemu/commit/ff26d287bddc189fd5a084cc96078da1257b0826
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M target/s390x/cc_helper.c
    M target/s390x/helper.c
    M target/s390x/insn-data.def
    M target/s390x/internal.h
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: Improve cc computation for ADD LOGICAL

The resulting cc is only dependent on the result and the
carry-out.  So save those things rather than the inputs.

Carry-out for 64-bit inputs is had via tcg_gen_add2_i64 directly
into cc_src.  Carry-out for 32-bit inputs is had via extraction
from a normal 64-bit add (with zero-extended inputs).

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201214221356.68039-2-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 3bcc3fa79902d72ab6385bb135e4c3e34931a697
      
https://github.com/qemu/qemu/commit/3bcc3fa79902d72ab6385bb135e4c3e34931a697
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M target/s390x/cc_helper.c
    M target/s390x/helper.c
    M target/s390x/insn-data.def
    M target/s390x/internal.h
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: Improve ADD LOGICAL WITH CARRY

Now that ADD LOGICAL outputs carry, we can use that as input directly.
It also means we can re-use CC_OP_ADDU and produce an output carry
directly from ADD LOGICAL WITH CARRY.

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201214221356.68039-3-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: a2db06da7dff662159c809059cda5e2aa302ec86
      
https://github.com/qemu/qemu/commit/a2db06da7dff662159c809059cda5e2aa302ec86
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M target/s390x/cc_helper.c
    M target/s390x/helper.c
    M target/s390x/insn-data.def
    M target/s390x/internal.h
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: Improve cc computation for SUBTRACT LOGICAL

The resulting cc is only dependent on the result and the carry-out.
Carry-out and borrow-out are inverses, so are trivially converted.
With tcg ops, it is easier to compute borrow-out than carry-out, so
save result and borrow-out rather than the inputs.

Borrow-out for 64-bit inputs is had via tcg_gen_sub2_i64 directly
into cc_src.  Borrow-out for 32-bit inputs is had via extraction
from a normal 64-bit sub (with zero-extended inputs).

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201214221356.68039-4-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 1a9aaa4b735e62fab5e72153ee84757e0e5fd467
      
https://github.com/qemu/qemu/commit/1a9aaa4b735e62fab5e72153ee84757e0e5fd467
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M target/s390x/cc_helper.c
    M target/s390x/helper.c
    M target/s390x/insn-data.def
    M target/s390x/internal.h
    M target/s390x/translate.c

  Log Message:
  -----------
  target/s390x: Improve SUB LOGICAL WITH BORROW

Now that SUB LOGICAL outputs borrow, we can use that as input directly.
It also means we can re-use CC_OP_SUBU and produce an output borrow
directly from SUB LOGICAL WITH BORROW.

Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20201214221356.68039-5-richard.henderson@linaro.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 44637c4b2b03290cee8011979030896a834f951e
      
https://github.com/qemu/qemu/commit/44637c4b2b03290cee8011979030896a834f951e
  Author: Cornelia Huck <cohuck@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  tests/acceptance: test hot(un)plug of ccw devices

Hotplug a virtio-net-ccw device, and then hotunplug it again.

Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20201208122843.147186-1-cohuck@redhat.com>


  Commit: 09d4455e42e1bd2dd76d7c45dbb8560cc2371cc4
      
https://github.com/qemu/qemu/commit/09d4455e42e1bd2dd76d7c45dbb8560cc2371cc4
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  tests/acceptance: Extract the code to clear dmesg and wait for CRW reports

We will use this in more spots soon, so it's easier to put this into
a separate function.

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201215183623.110128-2-thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 7e549424f017eed6ce22bcf222c269739343238f
      
https://github.com/qemu/qemu/commit/7e549424f017eed6ce22bcf222c269739343238f
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  tests/acceptance: Test virtio-rng on s390 via /dev/hwrng

/dev/hwrng is only functional if virtio-rng is working right, so let's
add a sanity check for this device node.

Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201215183623.110128-3-thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: d986bc4a1c2de68dbb056b1b761a863dc47313ee
      
https://github.com/qemu/qemu/commit/d986bc4a1c2de68dbb056b1b761a863dc47313ee
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  tests/acceptance: Test the virtio-balloon device on s390x

Inflate the balloon and check whether the size of the memory changes.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201215183623.110128-4-thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 704d7a2304d890a570b722e20bd66e5e6303b7d9
      
https://github.com/qemu/qemu/commit/704d7a2304d890a570b722e20bd66e5e6303b7d9
  Author: Matthew Rosato <mjrosato@linux.ibm.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M hw/s390x/s390-pci-inst.c

  Log Message:
  -----------
  s390x/pci: fix pcistb length

In pcistb_service_call, we are grabbing 8 bits from a guest register to
indicate the length of the store operation -- but per the architecture
the length is actually defined by 13 bits of the guest register.

Fixes: 863f6f52b7 ("s390: implement pci instructions")
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Message-Id: <1608243397-29428-2-git-send-email-mjrosato@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: b3834073dad120a7ffddc22fd860acf967b62150
      
https://github.com/qemu/qemu/commit/b3834073dad120a7ffddc22fd860acf967b62150
  Author: Matthew Rosato <mjrosato@linux.ibm.com>
  Date:   2020-12-21 (Mon, 21 Dec 2020)

  Changed paths:
    M hw/s390x/s390-pci-inst.c

  Log Message:
  -----------
  s390x/pci: Fix memory_region_access_valid call

In pcistb_service_handler, a call is made to validate that the memory
region can be accessed.  However, the call is made using the entire length
of the pcistb operation, which can be larger than the allowed memory
access size (8).  Since we already know that the provided buffer is a
multiple of 8, fix the call to memory_region_access_valid to iterate
over the memory region in the same way as the subsequent call to
memory_region_dispatch_write.

Fixes: 863f6f52b7 ("s390: implement pci instructions")
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Acked-by: Pierre Morel <pmorel@linux.ibm.com>
Message-Id: <1608243397-29428-3-git-send-email-mjrosato@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 24bfaae13958b823a4f33b70fca52f086851641f
      
https://github.com/qemu/qemu/commit/24bfaae13958b823a4f33b70fca52f086851641f
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-12-22 (Tue, 22 Dec 2020)

  Changed paths:
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  tests/acceptance: Add a test with the Fedora 31 kernel and initrd

This initrd contains a virtio-net and a virtio-gpu kernel module,
so we can check that we can set a MAC address for the network device
and whether we can hot-plug and -unplug a virtio-crypto device.
But the most interesting part is maybe that we can also successfully
write some stuff into the emulated framebuffer of the virtio-gpu
device and make sure that we can read back that data from a screenshot.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201221143423.23607-1-thuth@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Tested-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>


  Commit: 83734919c408ba02adb6ea616d68cd1a72837fbe
      
https://github.com/qemu/qemu/commit/83734919c408ba02adb6ea616d68cd1a72837fbe
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-01-01 (Fri, 01 Jan 2021)

  Changed paths:
    M MAINTAINERS
    M hw/s390x/s390-pci-inst.c
    M qga/commands-posix.c
    M qga/qapi-schema.json
    M target/s390x/cc_helper.c
    M target/s390x/cpu_features.c
    M target/s390x/cpu_models.c
    M target/s390x/helper.c
    M target/s390x/insn-data.def
    M target/s390x/internal.h
    M target/s390x/translate.c
    M tests/acceptance/machine_s390_ccw_virtio.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck-gitlab/tags/s390x-20201222' into 
staging

Further s390x updates:
- enhance the s390 devices acceptance test
- tcg: improve carry computation
- qga: send the ccw address with the fsinfo data
- fixes for protected virtualisation and zpci

# gpg: Signature made Tue 22 Dec 2020 10:37:34 GMT
# gpg:                using RSA key C3D0D66DC3624FF6A8C018CEDECF6B93C6F02FAF
# gpg:                issuer "cohuck@redhat.com"
# gpg: Good signature from "Cornelia Huck <conny@cornelia-huck.de>" [unknown]
# gpg:                 aka "Cornelia Huck <huckc@linux.vnet.ibm.com>" [full]
# gpg:                 aka "Cornelia Huck <cornelia.huck@de.ibm.com>" [full]
# gpg:                 aka "Cornelia Huck <cohuck@kernel.org>" [unknown]
# gpg:                 aka "Cornelia Huck <cohuck@redhat.com>" [unknown]
# Primary key fingerprint: C3D0 D66D C362 4FF6 A8C0  18CE DECF 6B93 C6F0 2FAF

* remotes/cohuck-gitlab/tags/s390x-20201222:
  tests/acceptance: Add a test with the Fedora 31 kernel and initrd
  s390x/pci: Fix memory_region_access_valid call
  s390x/pci: fix pcistb length
  tests/acceptance: Test the virtio-balloon device on s390x
  tests/acceptance: Test virtio-rng on s390 via /dev/hwrng
  tests/acceptance: Extract the code to clear dmesg and wait for CRW reports
  tests/acceptance: test hot(un)plug of ccw devices
  target/s390x: Improve SUB LOGICAL WITH BORROW
  target/s390x: Improve cc computation for SUBTRACT LOGICAL
  target/s390x: Improve ADD LOGICAL WITH CARRY
  target/s390x: Improve cc computation for ADD LOGICAL
  qga/commands-posix: Send CCW address on s390x with the fsinfo data
  MAINTAINERS: move my git tree to gitlab
  s390x: pv: Fence additional unavailable SCLP facilities for PV guests

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3896895ab491...83734919c408



reply via email to

[Prev in Thread] Current Thread [Next in Thread]