qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 952648: hw/m68k/q800: Don't connect two qemu_


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 952648: hw/m68k/q800: Don't connect two qemu_irqs directly...
Date: Sat, 12 Dec 2020 12:08:04 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9526486164818f1c59a142dec8a1f09fbf77669c
      
https://github.com/qemu/qemu/commit/9526486164818f1c59a142dec8a1f09fbf77669c
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M hw/m68k/Kconfig
    M hw/m68k/q800.c

  Log Message:
  -----------
  hw/m68k/q800: Don't connect two qemu_irqs directly to the same input

The q800 board code connects both of the IRQ outputs of the ESCC
to the same pic[3] qemu_irq. Connecting two qemu_irqs outputs directly
to the same input is not valid as it produces subtly wrong behaviour
(for instance if both the IRQ lines are high, and then one goes
low, the PIC input will see this as a high-to-low transition
even though the second IRQ line should still be holding it high).

This kind of wiring needs an explicitly created OR gate; add one.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20201106235109.7066-2-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 07e39012fee26267fa7cdcbc8456a3601f199d41
      
https://github.com/qemu/qemu/commit/07e39012fee26267fa7cdcbc8456a3601f199d41
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M hw/m68k/q800.c

  Log Message:
  -----------
  hw/m68k/q800.c: Make the GLUE chip an actual QOM device

The handling of the GLUE (General Logic Unit) device is
currently open-coded. Make this into a proper QOM device.

This minor piece of modernisation gets rid of the free
floating qemu_irq array 'pic', which Coverity points out
is technically leaked when we exit the machine init function.
(The replacement glue device is not leaked because it gets
added to the sysbus, so it's accessible via that.)

Fixes: Coverity CID 1421883
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Laurent vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201106235109.7066-3-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 4160d5e6bd347e5d27804912b61d02df0a90ba8e
      
https://github.com/qemu/qemu/commit/4160d5e6bd347e5d27804912b61d02df0a90ba8e
  Author: Laurent Vivier <laurent@vivier.eu>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M target/m68k/cpu.h

  Log Message:
  -----------
  target/m68k: remove useless qregs array

They are unused since the target has been converted to TCG.

Fixes: e1f3808e03f7 ("Convert m68k target to TCG.")
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201022203000.1922749-2-laurent@vivier.eu>


  Commit: d21f73c61ddd7676fae5df4990479f3c5fe4b858
      
https://github.com/qemu/qemu/commit/d21f73c61ddd7676fae5df4990479f3c5fe4b858
  Author: Laurent Vivier <laurent@vivier.eu>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/fpu_helper.c

  Log Message:
  -----------
  target/m68k: Add vmstate definition for M68kCPU

Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20201022203000.1922749-3-laurent@vivier.eu>


  Commit: ce00ff729ee8461dc94a1593d25ceda65d973d3c
      
https://github.com/qemu/qemu/commit/ce00ff729ee8461dc94a1593d25ceda65d973d3c
  Author: zhaolichang <zhaolichang@huawei.com>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M target/m68k/translate.c

  Log Message:
  -----------
  m68k: fix some comment spelling errors

I found that there are many spelling errors in the comments of qemu/target/m68k.
I used spellcheck to check the spelling errors and found some errors in the 
folder.

Signed-off-by: zhaolichang <zhaolichang@huawei.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Reviewed-by: Philippe Mathieu-Daude<f4bug@amsat.org>
Reviewed-by: Laurent Vivier<laurent@vivier.eu>
Message-Id: <20201009064449.2336-9-zhaolichang@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 17584289af1aaa72c932e7e47c25d583b329dc45
      
https://github.com/qemu/qemu/commit/17584289af1aaa72c932e7e47c25d583b329dc45
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-12 (Sat, 12 Dec 2020)

  Changed paths:
    M hw/m68k/Kconfig
    M hw/m68k/q800.c
    M target/m68k/cpu.c
    M target/m68k/cpu.h
    M target/m68k/fpu_helper.c
    M target/m68k/translate.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-6.0-pull-request' 
into staging

m68k pull request 20201212

Fix for Coverity CID 1421883
Fix some comment spelling errors
Add m68k vmstate

# gpg: Signature made Sat 12 Dec 2020 17:54:28 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier/tags/m68k-for-6.0-pull-request:
  m68k: fix some comment spelling errors
  target/m68k: Add vmstate definition for M68kCPU
  target/m68k: remove useless qregs array
  hw/m68k/q800.c: Make the GLUE chip an actual QOM device
  hw/m68k/q800: Don't connect two qemu_irqs directly to the same input

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/ad717e6da385...17584289af1a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]