[Qemu-commits] [qemu/qemu] 37b6fd: gitlab-ci: Document 'build-tcg-disabled' is a KVM ...

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 37b6fd6658ff79dd8e3ef0d3bc0d13866d077b53
      
https://github.com/qemu/qemu/commit/37b6fd6658ff79dd8e3ef0d3bc0d13866d077b53
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job

Document what this job cover (build X86 targets with
KVM being the single accelerator available).

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201207131503.3858889-2-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b62ea746487a15813575873e1cb93631671c8b03
      
https://github.com/qemu/qemu/commit/b62ea746487a15813575873e1cb93631671c8b03
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)

'extends' is an alternative to using YAML anchors
and is a little more flexible and readable. See:
https://docs.gitlab.com/ee/ci/yaml/#extends

More importantly it allows exploding YAML jobs.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201207131503.3858889-3-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0cdd3b0aa4186cad81f316a9d48968f0baf84b2c
      
https://github.com/qemu/qemu/commit/0cdd3b0aa4186cad81f316a9d48968f0baf84b2c
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci: Introduce 'cross_accel_build_job' template

Introduce a job template to cross-build accelerator specific
jobs (enable a specific accelerator, disabling the others).

The specific accelerator is selected by the $ACCEL environment
variable (default to KVM).

Extra options such disabling other accelerators are passed
via the $ACCEL_CONFIGURE_OPTS environment variable.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201207131503.3858889-4-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b16999a32c1ac6b99b1ab1e4183cfb7972e13bf7
      
https://github.com/qemu/qemu/commit/b16999a32c1ac6b99b1ab1e4183cfb7972e13bf7
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci: Add KVM s390x cross-build jobs

Cross-build s390x target with only KVM accelerator enabled.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201207131503.3858889-5-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 84eda1107920c92eaae74510760d5c975ba895d7
      
https://github.com/qemu/qemu/commit/84eda1107920c92eaae74510760d5c975ba895d7
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci: Add Xen cross-build jobs

Cross-build ARM and X86 targets with only Xen accelerator enabled.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201207131503.3858889-6-philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 43d1da7cb99ea66008583f531b584235d36fd0a3
      
https://github.com/qemu/qemu/commit/43d1da7cb99ea66008583f531b584235d36fd0a3
  Author: Alex Chen <alex.chen@huawei.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M tests/test-qga.c

  Log Message:
  -----------
  test-qga: fix a resource leak in test_qga_guest_get_osinfo()

The fixture->fd is created in fixture_setup() and, likewise, needs to be closed
in fixture_tear_down().

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20201125102403.57709-1-alex.chen@huawei.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 6536c9e0ebc40342a879b503040e7b0502524972
      
https://github.com/qemu/qemu/commit/6536c9e0ebc40342a879b503040e7b0502524972
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M tests/qtest/fuzz-test.c

  Log Message:
  -----------
  tests/qtest/fuzz-test: Quit test_lp1878642 once done

Missed in fd250172842 ("qtest: add a reproducer for LP#1878642").

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201201191026.4149955-2-philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b98b9fdef00e2383f63f939e079fe2c9eba87ca1
      
https://github.com/qemu/qemu/commit/b98b9fdef00e2383f63f939e079fe2c9eba87ca1
  Author: Alexander Bulekov <alxndr@bu.edu>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M tests/qtest/fuzz/generic_fuzz.c

  Log Message:
  -----------
  fuzz: avoid double-fetches by default

The generic fuzzer can find double-fetch bugs. However:
* We currently have no good way of producing qemu-system reproducers for
  double-fetch bugs. Even if we can get developers to run the binary-blob
  reproducers with the qemu-fuzz builds, we currently don't have a minimizer for
  these reproducers, so they are usually not easy to follow.
* Often times the fuzzer will provide a reproducer containing a
  double-fetch for a bug that can be reproduced without double-fetching.

Until we find a way to build nice double-fetch reproducers that
developers are willing to look at, lets tell OSS-Fuzz to avoid
double-fetches.

Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Message-Id: <20201202164214.93867-1-alxndr@bu.edu>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 94a4f8167dd9dde35b27e1d82bdf6c2fa5071364
      
https://github.com/qemu/qemu/commit/94a4f8167dd9dde35b27e1d82bdf6c2fa5071364
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled

We will keep adding/removing options to our 'configure' script,
so for easier maintainability it makes sense to have CONFIGURE_ARGS
declared as one option per line. This way we can review diff easily
(or rebase/cherry-pick).

No logical change.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201108204535.2319870-6-philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 0c4d885f08485de1a4a51b31a7b5af66e181667e
      
https://github.com/qemu/qemu/commit/0c4d885f08485de1a4a51b31a7b5af66e181667e
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Update 'build-disabled' to cover all configurable options

Add these missing options to the 'build-disabled' job:
  --disable-auth-pam             (commit 8953caf3cd38)
  --disable-gcrypt               (commit 91bfcdb01d48)
  --disable-keyring              (commit 54e7aac05624)
  --disable-libudev              (commit 5c53015a480b)
  --disable-opengl               (commit da076ffed6b9)
  --disable-sparse               (commit 03b4fe7de226)

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[thuth: Dropped the unnecessary hunk with --disable-vhost-user-blk-server]
Message-Id: <20201108204535.2319870-7-philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d01bc2531c4055ca8b5c3a0cacb9e26d321550c7
      
https://github.com/qemu/qemu/commit/d01bc2531c4055ca8b5c3a0cacb9e26d321550c7
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml

  Log Message:
  -----------
  gitlab-ci: Move user-static test across to gitlab

Similarly to commit 8cdb2cef3f1, move the user-static test to GitLab.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201108204535.2319870-11-philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: d1a8b308a4ceb1071683bfcee22bd646b251f4a0
      
https://github.com/qemu/qemu/commit/d1a8b308a4ceb1071683bfcee22bd646b251f4a0
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml

  Log Message:
  -----------
  gitlab-ci: Move coroutine tests across to gitlab

Similarly to commit 8cdb2cef3f1, move the coroutine tests to GitLab.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201108204535.2319870-13-philmd@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
[thuth: Replaced Travis by Gitlab-CI in comment]
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: b0bed2c916286326b248da05b2ca5f6d152aba44
      
https://github.com/qemu/qemu/commit/b0bed2c916286326b248da05b2ca5f6d152aba44
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M hw/m68k/mcf5206.c

  Log Message:
  -----------
  hw/m68k/mcf5206: Don't leak IRQs in mcf5206_mbar_realize()

Coverity points out that the realize function for the TYPE_MCF5206_MBAR
device leaks the IRQ array it allocates with qemu_allocate_irqs().
Keep a pointer to it in the device state struct to avoid the leak.
(Since it needs to stay around for the life of the simulation there
is no need to actually free it, and the leak was harmless.)

Fixes: Coverity CID 1432412
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201120172314.14725-1-peter.maydell@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 28db503fd7a750861aa4381653800d4eb28b5426
      
https://github.com/qemu/qemu/commit/28db503fd7a750861aa4381653800d4eb28b5426
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml
    M .gitlab-ci.yml
    M .travis.yml
    M hw/m68k/mcf5206.c
    M tests/qtest/fuzz-test.c
    M tests/qtest/fuzz/generic_fuzz.c
    M tests/test-qga.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2020-12-09' into staging

* Gitlab-CI improvement patches by Philippe
* Some small fixes for tests
* Fix coverity warning in the mcf5206 code

# gpg: Signature made Wed 09 Dec 2020 07:13:12 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2020-12-09:
  hw/m68k/mcf5206: Don't leak IRQs in mcf5206_mbar_realize()
  gitlab-ci: Move coroutine tests across to gitlab
  gitlab-ci: Move user-static test across to gitlab
  gitlab-ci: Update 'build-disabled' to cover all configurable options
  gitlab-ci: Split CONFIGURE_ARGS one argument per line for build-disabled
  fuzz: avoid double-fetches by default
  tests/qtest/fuzz-test: Quit test_lp1878642 once done
  test-qga: fix a resource leak in test_qga_guest_get_osinfo()
  gitlab-ci: Add Xen cross-build jobs
  gitlab-ci: Add KVM s390x cross-build jobs
  gitlab-ci: Introduce 'cross_accel_build_job' template
  gitlab-ci: Replace YAML anchors by extends (cross_system_build_job)
  gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/86667e8e44dc...28db503fd7a7