qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 923e93: docs: Get rid of the weird _005f link


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 923e93: docs: Get rid of the weird _005f links in the man ...
Date: Fri, 20 Nov 2020 12:18:56 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 923e931188dcbb72387961d313478b80ffc75231
      
https://github.com/qemu/qemu/commit/923e931188dcbb72387961d313478b80ffc75231
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-11-20 (Fri, 20 Nov 2020)

  Changed paths:
    M docs/system/gdb.rst
    M docs/system/images.rst
    M docs/system/monitor.rst
    M docs/system/mux-chardev.rst
    M docs/system/usb.rst
    M docs/system/vnc-security.rst
    M qemu-options.hx

  Log Message:
  -----------
  docs: Get rid of the weird _005f links in the man page

The man page does not contain all the chapters from the System Emulation
Users Guide, so some of the links that we've put into the qemu options
descriptions can not be resolved and thus the link names are used in the
man pages instead. These link names currently contain weird "_005f" letters
in the middle and just do not make any sense for the users. To avoid this
situation, replace the link names with more descriptive, natural text.

Message-Id: <20201116145341.91606-1-thuth@redhat.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3
Buglink: https://bugs.launchpad.net/qemu/+bug/1453608
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: f369797617297e190e2fba3d1b7ba459580f619c
      
https://github.com/qemu/qemu/commit/f369797617297e190e2fba3d1b7ba459580f619c
  Author: Chen Qun <kuhn.chenqun@huawei.com>
  Date:   2020-11-20 (Fri, 20 Nov 2020)

  Changed paths:
    M tests/qtest/npcm7xx_timer-test.c

  Log Message:
  -----------
  tests/qtest: variable defined by g_autofree need to be initialized

According to the glib function requirements, we need initialise
 the variable. Otherwise there will be compilation warnings:

glib-autocleanups.h:28:3: warning: ‘full_name’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
   28 |   g_free (*pp);
      |   ^~~~~~~~~~~~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
Message-Id: <20201118115646.2461726-2-kuhn.chenqun@huawei.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7aed584ca6a11b6c8e673f3a8ba56c927d076440
      
https://github.com/qemu/qemu/commit/7aed584ca6a11b6c8e673f3a8ba56c927d076440
  Author: Chen Qun <kuhn.chenqun@huawei.com>
  Date:   2020-11-20 (Fri, 20 Nov 2020)

  Changed paths:
    M tests/qtest/npcm7xx_watchdog_timer-test.c

  Log Message:
  -----------
  tests/qtest: fix memleak in npcm7xx_watchdog_timer-test

Properly free resp for get_watchdog_action() to avoid memory leak.
ASAN shows memory leak stack:

Indirect leak of 12360 byte(s) in 3 object(s) allocated from:
    #0 0x7f41ab6cbd4e in __interceptor_calloc (/lib64/libasan.so.5+0x112d4e)
    #1 0x7f41ab4eaa50 in g_malloc0 (/lib64/libglib-2.0.so.0+0x55a50)
    #2 0x556487d5374b in qdict_new ../qobject/qdict.c:29
    #3 0x556487d65e1a in parse_object ../qobject/json-parser.c:318
    #4 0x556487d65cb6 in parse_pair ../qobject/json-parser.c:287
    #5 0x556487d65ebd in parse_object ../qobject/json-parser.c:343
    #6 0x556487d661d5 in json_parser_parse ../qobject/json-parser.c:580
    #7 0x556487d513df in json_message_process_token 
../qobject/json-streamer.c:92
    #8 0x556487d63919 in json_lexer_feed_char ../qobject/json-lexer.c:313
    #9 0x556487d63d75 in json_lexer_feed ../qobject/json-lexer.c:350
    #10 0x556487d28b2a in qmp_fd_receive ../tests/qtest/libqtest.c:613
    #11 0x556487d2a16f in qtest_qmp_eventwait_ref ../tests/qtest/libqtest.c:827
    #12 0x556487d248e2 in get_watchdog_action 
../tests/qtest/npcm7xx_watchdog_timer-test.c:94
    #13 0x556487d25765 in test_enabling_flags 
../tests/qtest/npcm7xx_watchdog_timer-test.c:243

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Message-Id: <20201118115646.2461726-3-kuhn.chenqun@huawei.com>
Reviewed-by: Havard Skinnemoen <hskinnemoen@google.com>
Reviewed-by: Hao Wu <wuhaotsh@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 88a8b27e556f5cb49a19d4c98a96590f61b74ed2
      
https://github.com/qemu/qemu/commit/88a8b27e556f5cb49a19d4c98a96590f61b74ed2
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2020-11-20 (Fri, 20 Nov 2020)

  Changed paths:
    M tests/qtest/libqtest.c

  Log Message:
  -----------
  qtest: do not return freed argument vector from qtest_rsp

If expected_args is 0, qtest frees the argument vector and then returns it
nevertheless.  Coverity complains; in practice this is not an issue because
expected_args == 0 means that the caller is not interested in the argument
vector, but it would be a potential problem if somebody wanted to add
commands with optional arguments to qtest.

Suggested-by: Kamil Dudka <kdudka@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20201120073149.99079-1-pbonzini@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>


  Commit: 7761e07c3ffd8daad6fd933ad0bb03493080e193
      
https://github.com/qemu/qemu/commit/7761e07c3ffd8daad6fd933ad0bb03493080e193
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-20 (Fri, 20 Nov 2020)

  Changed paths:
    M docs/system/gdb.rst
    M docs/system/images.rst
    M docs/system/monitor.rst
    M docs/system/mux-chardev.rst
    M docs/system/usb.rst
    M docs/system/vnc-security.rst
    M qemu-options.hx
    M tests/qtest/libqtest.c
    M tests/qtest/npcm7xx_timer-test.c
    M tests/qtest/npcm7xx_watchdog_timer-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2020-11-20' into staging

* Some small qtest fixes
* One documentation update

# gpg: Signature made Fri 20 Nov 2020 15:35:15 GMT
# gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
# gpg:                issuer "thuth@redhat.com"
# gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
# gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
# gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
# gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2020-11-20:
  qtest: do not return freed argument vector from qtest_rsp
  tests/qtest: fix memleak in npcm7xx_watchdog_timer-test
  tests/qtest: variable defined by g_autofree need to be initialized
  docs: Get rid of the weird _005f links in the man page

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7fbd7e710323...7761e07c3ffd



reply via email to

[Prev in Thread] Current Thread [Next in Thread]