qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a6e037: audio/jack: fix use after free segfau


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a6e037: audio/jack: fix use after free segfault
Date: Fri, 13 Nov 2020 04:50:02 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: a6e037390dd91276f4a631d41188c87e8a60bb3f
      
https://github.com/qemu/qemu/commit/a6e037390dd91276f4a631d41188c87e8a60bb3f
  Author: Geoffrey McRae <geoff@hostfission.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M audio/jackaudio.c

  Log Message:
  -----------
  audio/jack: fix use after free segfault

This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is received. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.

Signed-off-by: Geoffrey McRae <geoff@hostfission.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Message-Id: <20201108063351.35804-2-geoff@hostfission.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 1cd8b9487025966123287e532636f231b46e8398
      
https://github.com/qemu/qemu/commit/1cd8b9487025966123287e532636f231b46e8398
  Author: lichun <lichun@ruijie.com.cn>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: avoid passing con=NULL to graphic_hw_update_done()

In graphic_hw_update(), first select an existing console,
a specific-console or active_console(if not specified),
then updating the console.

Signed-off-by: lichun <lichun@ruijie.com.cn>
Message-id: 1604682219-114389-1-git-send-email-lichun@ruijie.com.cn
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: f0617abfd6c08a7711cb99cc02a74533846c2f7d
      
https://github.com/qemu/qemu/commit/f0617abfd6c08a7711cb99cc02a74533846c2f7d
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/usb/Kconfig

  Log Message:
  -----------
  hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)

Since commit 755fba11fbc and 8ddab8dd3d8 we can not build
USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig
dependency.

Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201109135300.2592982-2-philmd@redhat.com

[ kraxel: restore "default y if PCI_DEVICES" because
          "qemu-system-ppc64 -M pseries,usb=on" needs USB_XHCI_NEC=y ]

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 0d5528612badad84821c5d93c82253f86987659d
      
https://github.com/qemu/qemu/commit/0d5528612badad84821c5d93c82253f86987659d
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Remove debugging code commented out

Commit ec87f206d70 ("cirrus: replace debug printf with trace points")
forgot to remove this code once replaced. Do it now.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-id: 20201103112558.2554390-2-philmd@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: e016a844ddfc94167fa25d55b46e1d1accafdec2
      
https://github.com/qemu/qemu/commit/e016a844ddfc94167fa25d55b46e1d1accafdec2
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Fix hexadecimal format string specifier

The '%u' conversion specifier is for decimal notation.
When prefixing a format with '0x', we want the hexadecimal
specifier ('%x').

Inspired-by: Dov Murik <dovmurik@linux.vnet.ibm.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-id: 20201103112558.2554390-3-philmd@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 172bc8520db1cb98d09b367360068a675fbc9413
      
https://github.com/qemu/qemu/commit/172bc8520db1cb98d09b367360068a675fbc9413
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M hw/usb/hcd-xhci-nec.c

  Log Message:
  -----------
  xhci: fix nec-usb-xhci properties

Storing properties directly in XHCIPciState.xhci doesn't work,
the object_initialize_child() call in xhci_instance_init() will
overwrite them.

This changes the defaults for some properties, which in turn breaks
live migration and possibly other things as well.

So add XHCINecState, store properties there, copy them over on
instance init.

Fixes: 8ddab8dd3d81 ("usb/hcd-xhci: Split pci wrapper for xhci base model")
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20201112103741.2335-1-kraxel@redhat.com


  Commit: 6980c128b5cbc1d2a1b85609bb4d1e006e65109e
      
https://github.com/qemu/qemu/commit/6980c128b5cbc1d2a1b85609bb4d1e006e65109e
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M audio/jackaudio.c
    M hw/display/cirrus_vga.c
    M hw/usb/Kconfig
    M hw/usb/hcd-xhci-nec.c
    M ui/console.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/fixes-20201113-pull-request' into staging

fixes for console, audio, usb, vga.

# gpg: Signature made Fri 13 Nov 2020 12:29:44 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/fixes-20201113-pull-request:
  xhci: fix nec-usb-xhci properties
  hw/display/cirrus_vga: Fix hexadecimal format string specifier
  hw/display/cirrus_vga: Remove debugging code commented out
  hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)
  console: avoid passing con=NULL to graphic_hw_update_done()
  audio/jack: fix use after free segfault

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/be2df2ac6f6b...6980c128b5cb



reply via email to

[Prev in Thread] Current Thread [Next in Thread]