qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] adab8d: dev-serial: style changes to improve

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] adab8d: dev-serial: style changes to improve readability a...
Date: Wed, 04 Nov 2020 08:52:10 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: adab8d48cff47ddb6c53c8b131f434e16fef133c
      
https://github.com/qemu/qemu/commit/adab8d48cff47ddb6c53c8b131f434e16fef133c
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c

  Log Message:
  -----------
  dev-serial: style changes to improve readability and checkpatch fixes

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-id: 20201027150456.24606-2-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 8a0e4ee704a684d0e0e0c7e8ff9c37e56bba26c5
      
https://github.com/qemu/qemu/commit/8a0e4ee704a684d0e0e0c7e8ff9c37e56bba26c5
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c

  Log Message:
  -----------
  dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201027150456.24606-3-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ebb1132023db782570e4157112b8e2c0ea00f4fc
      
https://github.com/qemu/qemu/commit/ebb1132023db782570e4157112b8e2c0ea00f4fc
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/trace-events

  Log Message:
  -----------
  dev-serial: convert from DPRINTF to trace-events

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201027150456.24606-4-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 655ec806c86621a8f5fe3a278649b3b6ba2bc829
      
https://github.com/qemu/qemu/commit/655ec806c86621a8f5fe3a278649b3b6ba2bc829
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/trace-events

  Log Message:
  -----------
  dev-serial: add trace-events for baud rate and data parameters

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201027150456.24606-5-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 687dfe63e3d9dd8a1a682a7da76bec75a5f656ba
      
https://github.com/qemu/qemu/commit/687dfe63e3d9dd8a1a682a7da76bec75a5f656ba
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c

  Log Message:
  -----------
  dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros 
from usb.h

The DeviceOutVendor and DeviceInVendor macros can be replaced with their
equivalent VendorDeviceOutRequest and VendorDeviceRequest macros from usb.h.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201027150456.24606-6-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 66007a95674d4b8e616245541faad6cdf5e9f70d
      
https://github.com/qemu/qemu/commit/66007a95674d4b8e616245541faad6cdf5e9f70d
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c

  Log Message:
  -----------
  dev-serial: add always-plugged property to ensure USB device is always 
attached

Some operating systems will generate a new device ID when a USB device is 
unplugged
and then replugged into the USB. If this is done whilst switching between 
multiple
applications over a virtual serial port, the change of device ID requires going
back into the OS/application to locate the new device accordingly.

Add a new always-plugged property that if specified will ensure that the device
always remains attached to the USB regardless of the state of the backend
chardev.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-id: 20201027150456.24606-7-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: a79f86cdbe9ccd5c3be76a9c6288d07a7716cb12
      
https://github.com/qemu/qemu/commit/a79f86cdbe9ccd5c3be76a9c6288d07a7716cb12
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/trace-events

  Log Message:
  -----------
  dev-serial: add support for setting data_bits in QEMUSerialSetParams

Also implement the behaviour reported in Linux's ftdi_sio.c whereby if an 
invalid
data_bits value is provided then the hardware defaults to using 8.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20201027150456.24606-8-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 963a7bed570ce12604a48755c78244a2b6e179b3
      
https://github.com/qemu/qemu/commit/963a7bed570ce12604a48755c78244a2b6e179b3
  Author: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/trace-events

  Log Message:
  -----------
  dev-serial: store flow control and xon/xoff characters

Note that whilst the device does not do anything with these values, they are
logged with trace events and stored to allow future implementation.

The default flow control is set to none at reset as documented in the Linux
ftdi_sio.h header file.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Message-id: 20201027150456.24606-9-mark.cave-ayland@ilande.co.uk
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: b1266b6ee5aecb8f14db1a1e43109b8ecae6131a
      
https://github.com/qemu/qemu/commit/b1266b6ee5aecb8f14db1a1e43109b8ecae6131a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/trace-events

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20201104-pull-request' 
into staging

usb: bugfixes for usb-serial

# gpg: Signature made Wed 04 Nov 2020 12:13:05 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20201104-pull-request:
  dev-serial: store flow control and xon/xoff characters
  dev-serial: add support for setting data_bits in QEMUSerialSetParams
  dev-serial: add always-plugged property to ensure USB device is always 
attached
  dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros 
from usb.h
  dev-serial: add trace-events for baud rate and data parameters
  dev-serial: convert from DPRINTF to trace-events
  dev-serial: use USB_SERIAL QOM macro for USBSerialState assignments
  dev-serial: style changes to improve readability and checkpatch fixes

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/e46912b66f50...b1266b6ee5ae
reply via email to
[Prev in Thread] Current Thread [Next in Thread]