qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b4cb76: tcg: Do not kill globals at condition


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b4cb76: tcg: Do not kill globals at conditional branches
Date: Sat, 31 Oct 2020 02:47:17 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b4cb76e6208cf6b5bb39404c6d44a6514eb6842a
      
https://github.com/qemu/qemu/commit/b4cb76e6208cf6b5bb39404c6d44a6514eb6842a
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M include/tcg/tcg-opc.h
    M include/tcg/tcg.h
    M tcg/tcg.c

  Log Message:
  -----------
  tcg: Do not kill globals at conditional branches

We can easily register allocate the entire extended basic block
(in this case, the set of blocks connected by fallthru), simply
by not discarding the register state at the branch.

This does not help blocks starting with a label, as they are
reached via a taken branch, and that would require saving the
complete register state at the branch.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: cd0372c515c4732d8bd3777cdd995c139c7ed7ea
      
https://github.com/qemu/qemu/commit/cd0372c515c4732d8bd3777cdd995c139c7ed7ea
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M tcg/optimize.c

  Log Message:
  -----------
  tcg/optimize: Flush data at labels not TCG_OPF_BB_END

We can easily propagate temp values through the entire extended
basic block (in this case, the set of blocks connected by fallthru),
simply by not discarding the register state at the branch.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 1d705e8a5bbfe36294081baa45ab68a9ad987f33
      
https://github.com/qemu/qemu/commit/1d705e8a5bbfe36294081baa45ab68a9ad987f33
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M accel/tcg/translate-all.c

  Log Message:
  -----------
  accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile()

When using -icount, it's useful for the CPU_LOG_EXEC logging
to include information about when cpu_io_recompile() was
called, because it alerts the reader of the log that the
tracing of a previous TB execution may not actually
correspond to an actually executed instruction. For instance
if you're using -icount and also -singlestep then a guest
instruction that makes an IO access appears in two
"Trace" lines, once in a TB that triggers the cpu_io_recompile()
and then again in the TB that actually executes.

(This is a similar reason to why the "Stopped execution of
TB chain before..." logging in cpu_tb_exec() is helpful
when trying to track execution flow in the logs.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20201013122658.4620-1-peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: c3dee4de9252ec6f675603e460f9a668f1b5ec1b
      
https://github.com/qemu/qemu/commit/c3dee4de9252ec6f675603e460f9a668f1b5ec1b
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    M accel/tcg/translate-all.c
    M include/tcg/tcg-opc.h
    M include/tcg/tcg.h
    M tcg/optimize.c
    M tcg/tcg.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20201027' into 
staging

Optimize across branches.
Add logging for cpu_io_recompile.

# gpg: Signature made Tue 27 Oct 2020 16:48:50 GMT
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth-gitlab/tags/pull-tcg-20201027:
  accel/tcg: Add CPU_LOG_EXEC tracing for cpu_io_recompile()
  tcg/optimize: Flush data at labels not TCG_OPF_BB_END
  tcg: Do not kill globals at conditional branches

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/9a2ea4f4a723...c3dee4de9252



reply via email to

[Prev in Thread] Current Thread [Next in Thread]