qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 4ac4e7: ide: run diagnostic after SRST


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 4ac4e7: ide: run diagnostic after SRST
Date: Fri, 30 Oct 2020 07:13:00 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4ac4e7281a2dd1ca5158812198c4d2cbacf2ae25
      
https://github.com/qemu/qemu/commit/4ac4e7281a2dd1ca5158812198c4d2cbacf2ae25
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: run diagnostic after SRST

Software reset (SRST) should cause the diagnostic command to be run. Make an
explicit call to that routine.

Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20201020200242.1497705-2-jsnow@redhat.com
Fixes: 55adb3c45620c31f29978f209e2a44a08d34e2da
Fixes: https://bugs.launchpad.net/bugs/1900155
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: b45bcd81e05dea2781f2164ca1c9dd86069502ea
      
https://github.com/qemu/qemu/commit/b45bcd81e05dea2781f2164ca1c9dd86069502ea
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: perform SRST as early as possible

We don't need to wait for the falling edge. We can set BSY as
soon as possible and begin immediately resetting the drive. Devices
don't appear to need to take any specific action on the falling edge.

Signed-off-by: John Snow <jsnow@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-id: 20201020200242.1497705-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: 1a9925e3390b6adf1125e3abaa17c80ca012bede
      
https://github.com/qemu/qemu/commit/1a9925e3390b6adf1125e3abaa17c80ca012bede
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  ide: clear SRST after SRST finishes

The SRST protocol states that after diagnostics are complete and the
status is posted, we should clear the SRST bit if it should so happen to
be set.

The reset method itself should handle this, but just in case -- make our
intention explicit here.

Signed-off-by: John Snow <jsnow@redhat.com>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-id: 20201020200242.1497705-4-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>


  Commit: d03e884e4ece4b528ed87d4133867fcf87aa76e5
      
https://github.com/qemu/qemu/commit/d03e884e4ece4b528ed87d4133867fcf87aa76e5
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    M hw/ide/core.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/jsnow-gitlab/tags/ide-pull-request' 
into staging

IDE Pull request

# gpg: Signature made Tue 27 Oct 2020 14:41:59 GMT
# gpg:                using RSA key F9B7ABDBBCACDF95BE76CBD07DEF8106AAFC390E
# gpg: Good signature from "John Snow (John Huston) <jsnow@redhat.com>" [full]
# Primary key fingerprint: FAEB 9711 A12C F475 812F  18F2 88A9 064D 1835 61EB
#      Subkey fingerprint: F9B7 ABDB BCAC DF95 BE76  CBD0 7DEF 8106 AAFC 390E

* remotes/jsnow-gitlab/tags/ide-pull-request:
  ide: clear SRST after SRST finishes
  ide: perform SRST as early as possible
  ide: run diagnostic after SRST

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/a19d4bc45253...d03e884e4ece



reply via email to

[Prev in Thread] Current Thread [Next in Thread]