[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 982050: hw/sd/sdcard: Update the SDState docu
From: |
Peter Maydell |
Subject: |
[Qemu-commits] [qemu/qemu] 982050: hw/sd/sdcard: Update the SDState documentation |
Date: |
Mon, 26 Oct 2020 15:36:10 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 9820502cad6c1b5810d90c7189badef882471dc7
https://github.com/qemu/qemu/commit/9820502cad6c1b5810d90c7189badef882471dc7
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Update the SDState documentation
Add more descriptive comments to keep a clear separation
between static property vs runtime changeable.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630133912.9428-12-f4bug@amsat.org>
Commit: ef6dd5f5c41b2d8fcfd72c946ac224e6c3aa1363
https://github.com/qemu/qemu/commit/ef6dd5f5c41b2d8fcfd72c946ac224e6c3aa1363
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Simplify cmd_valid_while_locked()
cmd_valid_while_locked() only needs to read SDRequest->cmd,
pass it directly and make it const.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630133912.9428-13-f4bug@amsat.org>
Commit: aecaa05922bca8b1760cd463935ca2a71df776f5
https://github.com/qemu/qemu/commit/aecaa05922bca8b1760cd463935ca2a71df776f5
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Constify sd_crc*()'s message argument
CRC functions don't modify the buffer argument,
make it const.
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200630133912.9428-14-f4bug@amsat.org>
Commit: 692fb0ef31af680632c84bc18bc639cba4a0e24b
https://github.com/qemu/qemu/commit/692fb0ef31af680632c84bc18bc639cba4a0e24b
Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
M hw/sd/trace-events
Log Message:
-----------
hw/sd/sdcard: Make iolen unsigned
I/O request length can not be negative.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630133912.9428-15-f4bug@amsat.org>
Commit: 89c6700fe7eed9195f10055751edbc6d5e7ab940
https://github.com/qemu/qemu/commit/89c6700fe7eed9195f10055751edbc6d5e7ab940
Author: Bin Meng <bin.meng@windriver.com>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
Log Message:
-----------
hw/sd/sdcard: Zero out function selection fields before being populated
The function selection fields (399:376) should be zeroed out to
prevent leftover from being or'ed into the switch function status
data structure.
This fixes the boot failure as seen in the acceptance testing on
the orangepi target.
Fixes: b638627c723a ("hw/sd: Fix incorrect populated function switch status
data structure")
Reported-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201024014954.21330-1-bmeng.cn@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Commit: 1dc887329a10903940501b43e8c0cc67af7c06d5
https://github.com/qemu/qemu/commit/1dc887329a10903940501b43e8c0cc67af7c06d5
Author: Peter Maydell <peter.maydell@linaro.org>
Date: 2020-10-26 (Mon, 26 Oct 2020)
Changed paths:
M hw/sd/sd.c
M hw/sd/trace-events
Log Message:
-----------
Merge remote-tracking branch 'remotes/philmd-gitlab/tags/sd-next-20201026'
into staging
SD/MMC patches
- Fix a bug in CMD6/SWITCH_FUNCTION (Bin Meng)
- Minor housekeeping patches
CI jobs result:
. https://cirrus-ci.com/build/5461987880599552
. https://gitlab.com/philmd/qemu/-/pipelines/207532287
. https://travis-ci.org/github/philmd/qemu/builds/738901111
. https://app.shippable.com/github/philmd/qemu/runs/888/summary/console
# gpg: Signature made Mon 26 Oct 2020 11:02:22 GMT
# gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>"
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE
* remotes/philmd-gitlab/tags/sd-next-20201026:
hw/sd/sdcard: Zero out function selection fields before being populated
hw/sd/sdcard: Make iolen unsigned
hw/sd/sdcard: Constify sd_crc*()'s message argument
hw/sd/sdcard: Simplify cmd_valid_while_locked()
hw/sd/sdcard: Update the SDState documentation
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Compare: https://github.com/qemu/qemu/compare/a95e0396c805...1dc887329a10
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 982050: hw/sd/sdcard: Update the SDState documentation,
Peter Maydell <=