qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a64627: qemu-img-cmds.hx: Update comment that


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a64627: qemu-img-cmds.hx: Update comment that mentions Tex...
Date: Tue, 13 Oct 2020 08:30:40 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a64627edcc063ccb51a56258d3605fffaee0157e
      
https://github.com/qemu/qemu/commit/a64627edcc063ccb51a56258d3605fffaee0157e
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2020-10-12 (Mon, 12 Oct 2020)

  Changed paths:
    M qemu-img-cmds.hx

  Log Message:
  -----------
  qemu-img-cmds.hx: Update comment that mentions Texinfo

Missed in 3c95fdef94 "Update comments in .hx files that mention
Texinfo".

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200929075824.1517969-2-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 32048d724d85c986dbd1883bc30c39befb8d7767
      
https://github.com/qemu/qemu/commit/32048d724d85c986dbd1883bc30c39befb8d7767
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2020-10-12 (Mon, 12 Oct 2020)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  target/i386/cpu: Update comment that mentions Texinfo

Missed in commit 41fba1618b "docs/system: convert the documentation of
deprecated features to rST."

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200929075824.1517969-3-armbru@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 009f51df0e697bab4578037092057ac398fd15f4
      
https://github.com/qemu/qemu/commit/009f51df0e697bab4578037092057ac398fd15f4
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M hw/block/nvme.c

  Log Message:
  -----------
  hw/block/nvme: Simplify timestamp sum

As the 'timestamp' variable is declared as a 48-bit bitfield,
we do not need to wrap the sum result.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Message-Id: <20201002075716.1657849-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: ff82a54bc4ce76ee407c7c42aa64eeec86285bb7
      
https://github.com/qemu/qemu/commit/ff82a54bc4ce76ee407c7c42aa64eeec86285bb7
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M tests/test-char.c

  Log Message:
  -----------
  tests/test-char: Use a proper fallthrough comment

For being able to compile with -Werror=implicit-fallthrough we need
to use comments that the compiler recognizes. Use "fallthrough" instead
of "no break" here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201002171343.283426-1-thuth@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: cd466702f042f435cf8661e2cdcafeb0482e6b3d
      
https://github.com/qemu/qemu/commit/cd466702f042f435cf8661e2cdcafeb0482e6b3d
  Author: Christian Borntraeger <borntraeger@de.ibm.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M block/vmdk.c

  Log Message:
  -----------
  vmdk: fix maybe uninitialized warnings

Fedora 32 gcc 10 seems to give false positives:

Compiling C object libblock.fa.p/block_vmdk.c.o
../block/vmdk.c: In function ‘vmdk_parse_extents’:
../block/vmdk.c:587:5: error: ‘extent’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  587 |     g_free(extent->l1_table);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
../block/vmdk.c:754:17: note: ‘extent’ was declared here
  754 |     VmdkExtent *extent;
      |                 ^~~~~~
../block/vmdk.c:620:11: error: ‘extent’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  620 |     ret = vmdk_init_tables(bs, extent, errp);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../block/vmdk.c:598:17: note: ‘extent’ was declared here
  598 |     VmdkExtent *extent;
      |                 ^~~~~~
../block/vmdk.c:1178:39: error: ‘extent’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
 1178 |             extent->flat_start_offset = flat_offset << 9;
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../block/vmdk.c: In function ‘vmdk_open_vmdk4’:
../block/vmdk.c:581:22: error: ‘extent’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  581 |     extent->l2_cache =
      |     ~~~~~~~~~~~~~~~~~^
  582 |         g_malloc(extent->entry_size * extent->l2_size * L2_CACHE_SIZE);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../block/vmdk.c:872:17: note: ‘extent’ was declared here
  872 |     VmdkExtent *extent;
      |                 ^~~~~~
../block/vmdk.c: In function ‘vmdk_open’:
../block/vmdk.c:620:11: error: ‘extent’ may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
  620 |     ret = vmdk_init_tables(bs, extent, errp);
      |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../block/vmdk.c:598:17: note: ‘extent’ was declared here
  598 |     VmdkExtent *extent;
      |                 ^~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile.ninja:884: libblock.fa.p/block_vmdk.c.o] Error 1

fix them by assigning a default value.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Fam Zheng <fam@euphon.net>
Message-Id: <20200930155859.303148-2-borntraeger@de.ibm.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5ad1037cad3572e382043a2a525b7967ddc9357f
      
https://github.com/qemu/qemu/commit/5ad1037cad3572e382043a2a525b7967ddc9357f
  Author: Greg Kurz <groug@kaod.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M hw/acpi/piix4.c

  Log Message:
  -----------
  hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties()

Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <160165476743.57452.2128307974125615413.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 21786c7e59847b1612406ff394958f22e5b323f8
      
https://github.com/qemu/qemu/commit/21786c7e59847b1612406ff394958f22e5b323f8
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M softmmu/memory.c

  Log Message:
  -----------
  softmmu/memory: Log invalid memory accesses

Log invalid memory accesses with as GUEST_ERROR.

This is particularly useful since commit 5d971f9e67 which reverted
("memory: accept mismatching sizes in memory_region_access_valid").

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20201005152725.2143444-1-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 3298bbce1b0e560b88103ddbbbb6548e4b9576cd
      
https://github.com/qemu/qemu/commit/3298bbce1b0e560b88103ddbbbb6548e4b9576cd
  Author: Julia Suvorova <jusual@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M hw/pci/pci.c
    M hw/ppc/spapr_pci.c

  Log Message:
  -----------
  hw/pci: Fix typo in PCI hot-plug error message

'occupied' is spelled like 'ocuppied' in the message.

Signed-off-by: Julia Suvorova <jusual@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20201006133958.600932-1-jusual@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5b4c95d0a377fe4d898572d35ec5d82b6f89338d
      
https://github.com/qemu/qemu/commit/5b4c95d0a377fe4d898572d35ec5d82b6f89338d
  Author: Elena Afanasova <eafanasova@gmail.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M block/blkdebug.c

  Log Message:
  -----------
  block/blkdebug: fix memory leak

Spotted by PVS-Studio

Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1e903f928eb3da332cc95e2a6f87243bd9fe66e4.camel@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 9aa2c49eb76838618f1eabd04a688ad2a44c24e5
      
https://github.com/qemu/qemu/commit/9aa2c49eb76838618f1eabd04a688ad2a44c24e5
  Author: Laurent Vivier <lvivier@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M hw/char/serial.c

  Log Message:
  -----------
  hw/char/serial: remove duplicate .class_init in serial_mm_info

.class_init is already set to serial_mm_class_init.

Remove the duplicate entry.

Fixes: 17fd1a6490b1 ("serial-mm: add "regshift" property")
Cc: marcandre.lureau@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20201009113843.60995-1-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 16b66c5626c27b660692f3e60827f58f167e001f
      
https://github.com/qemu/qemu/commit/16b66c5626c27b660692f3e60827f58f167e001f
  Author: Laurent Vivier <lvivier@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M hw/rtc/goldfish_rtc.c

  Log Message:
  -----------
  goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN

The doc [1] doesn't define the endianness, but the kernel driver
uses readl() to access the registers, so we can guess it depends
on the architecture endianness.

As riscv architecture endianness is little it might not change anything
for it.

Moreover, android implementation uses DEVICE_NATIVE_ENDIAN [2]

[1] 
https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT
[2] 
https://android.googlesource.com/platform/external/qemu/+/refs/heads/emu-master-dev/hw/timer/goldfish_timer.c#177

Fixes: 9a5b40b84279 ("hw: rtc: Add Goldfish RTC device")
Cc: Anup.Patel@wdc.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20201009113843.60995-2-lvivier@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: b5c6b870efe1c279b363d08c78ab76365ca7156e
      
https://github.com/qemu/qemu/commit/b5c6b870efe1c279b363d08c78ab76365ca7156e
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M target/sparc/int32_helper.c

  Log Message:
  -----------
  target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry

Commit 0b09be2b2f ("Nicer debug output for exceptions") added
twice the same "Tag Overflow" entry, remove the extra one.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20201011200112.3222822-1-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 662770af7c6e8cf02aebdbf53cae6828ea1e49aa
      
https://github.com/qemu/qemu/commit/662770af7c6e8cf02aebdbf53cae6828ea1e49aa
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M migration/dirtyrate.c
    M tests/test-bitmap.c

  Log Message:
  -----------
  mingw: fix error __USE_MINGW_ANSI_STDIO redefined

Always put osdep.h first, and remove redundant stdlib.h include.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20201008165953.884599-1-marcandre.lureau@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 6125673eaf711247405e796604204bb7d74090f4
      
https://github.com/qemu/qemu/commit/6125673eaf711247405e796604204bb7d74090f4
  Author: Sergei Trofimovich <slyfox@gentoo.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M meson.build

  Log Message:
  -----------
  meson.build: drop duplicate 'sparc64' entry

CC: Laurent Vivier <laurent@vivier.eu>
CC: qemu-trivial@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Message-Id: <20201012175719.2573367-1-slyfox@gentoo.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 96292515c07e3a99f5a29540ed2f257b1ff75111
      
https://github.com/qemu/qemu/commit/96292515c07e3a99f5a29540ed2f257b1ff75111
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-13 (Tue, 13 Oct 2020)

  Changed paths:
    M block/blkdebug.c
    M block/vmdk.c
    M hw/acpi/piix4.c
    M hw/block/nvme.c
    M hw/char/serial.c
    M hw/pci/pci.c
    M hw/ppc/spapr_pci.c
    M hw/rtc/goldfish_rtc.c
    M meson.build
    M migration/dirtyrate.c
    M qemu-img-cmds.hx
    M softmmu/memory.c
    M target/i386/cpu.c
    M target/sparc/int32_helper.c
    M tests/test-bitmap.c
    M tests/test-char.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging

Trivial Patches Pull request 20201013

# gpg: Signature made Tue 13 Oct 2020 12:49:59 BST
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-for-5.2-pull-request:
  meson.build: drop duplicate 'sparc64' entry
  mingw: fix error __USE_MINGW_ANSI_STDIO redefined
  target/sparc/int32_helper: Remove duplicated 'Tag Overflow' entry
  goldfish_rtc: change MemoryRegionOps endianness to DEVICE_NATIVE_ENDIAN
  hw/char/serial: remove duplicate .class_init in serial_mm_info
  block/blkdebug: fix memory leak
  hw/pci: Fix typo in PCI hot-plug error message
  softmmu/memory: Log invalid memory accesses
  hw/acpi/piix4: Rename piix4_pm_add_propeties() to piix4_pm_add_properties()
  vmdk: fix maybe uninitialized warnings
  tests/test-char: Use a proper fallthrough comment
  hw/block/nvme: Simplify timestamp sum
  target/i386/cpu: Update comment that mentions Texinfo
  qemu-img-cmds.hx: Update comment that mentions Texinfo

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b37da837630c...96292515c07e



reply via email to

[Prev in Thread] Current Thread [Next in Thread]