qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 043c2c: migration: Silence compiler warning i


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 043c2c: migration: Silence compiler warning in global_stat...
Date: Fri, 02 Oct 2020 06:30:34 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 043c2c1a5d4dafa330680ca9a3a0369d9a93ef4e
      
https://github.com/qemu/qemu/commit/043c2c1a5d4dafa330680ca9a3a0369d9a93ef4e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M migration/global_state.c

  Log Message:
  -----------
  migration: Silence compiler warning in global_state_store_running()

GCC 9.3.0 on Ubuntu complains:

In file included from /usr/include/string.h:495,
                 from /home/travis/build/huth/qemu/include/qemu/osdep.h:87,
                 from ../migration/global_state.c:13:
In function ‘strncpy’,
    inlined from ‘global_state_store_running’ at 
../migration/global_state.c:47:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error:
 ‘__builtin_strncpy’ specified bound 100 equals destination size 
[-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

... but we apparently really want to do a strncpy here - the size is already
checked with the assert() statement right in front of it. To silence the
warning, simply replace it with our strpadcpy() function.

Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (two years ago)
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200918103430.297167-4-thuth@redhat.com>
Message-Id: <20200925154027.12672-5-alex.bennee@linaro.org>


  Commit: 51f9206d070105f11989ac874e09997094594d97
      
https://github.com/qemu/qemu/commit/51f9206d070105f11989ac874e09997094594d97
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Drop the default softmmu builds

The total runtime of all Travis jobs is very long and we are testing
all softmmu targets in the gitlab-CI already - so we can speed up the
Travis testing a little bit by not testing the softmmu targets here
anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200918103430.297167-5-thuth@redhat.com>
Message-Id: <20200925154027.12672-6-alex.bennee@linaro.org>


  Commit: e769905e4c057fe80c6eaba071f957ef1dda1770
      
https://github.com/qemu/qemu/commit/e769905e4c057fe80c6eaba071f957ef1dda1770
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Update Travis to use Bionic and Focal instead of Xenial

According to our support policy, we do not support Xenial anymore.
Time to switch the bigger parts of the builds to Focal instead.
Some few jobs have to be updated to Bionic instead, since they are
currently still failing on Focal otherwise. Also "--disable-pie" is
causing linker problems with newer versions of Ubuntu ... so remove
that switch from the jobs now (we still test it in a gitlab CI job,
so we don't lose much test coverage here).

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20200918103430.297167-6-thuth@redhat.com>
Message-Id: <20200925154027.12672-7-alex.bennee@linaro.org>


  Commit: 2ef1d9384820ab99facb85f6d799da78fd5df1b6
      
https://github.com/qemu/qemu/commit/2ef1d9384820ab99facb85f6d799da78fd5df1b6
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Drop the superfluous Python 3.6 build

Python 3.6 is already the default Python in the jobs that are based
on Ubuntu Bionic, so it does not make much sense to test this again
separately.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200918103430.297167-7-thuth@redhat.com>
Message-Id: <20200925154027.12672-8-alex.bennee@linaro.org>


  Commit: f4d830c8951b4615db3d558ddeb6ec000c61cac0
      
https://github.com/qemu/qemu/commit/f4d830c8951b4615db3d558ddeb6ec000c61cac0
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Drop the Python 3.5 build

We are soon going to remove the support for Python 3.5. So remove
the CI job now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200922070441.48844-1-thuth@redhat.com>
Message-Id: <20200925154027.12672-9-alex.bennee@linaro.org>


  Commit: 93cc0506f6c0f42e959cd94b627b8d737eecedec
      
https://github.com/qemu/qemu/commit/93cc0506f6c0f42e959cd94b627b8d737eecedec
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M .gitlab-ci.d/crossbuilds.yml
    A tests/docker/dockerfiles/fedora-win32-cross.docker
    A tests/docker/dockerfiles/fedora-win64-cross.docker

  Log Message:
  -----------
  tests/docker: Use Fedora containers for MinGW cross-builds in the gitlab-CI

According to our support policy, we do not support Debian 9 in QEMU
anymore, and we only support building the Windows binaries with a
very recent version of the MinGW toolchain. So we should not test
the MinGW cross-compilation with Debian 9 anymore, but switch to
something newer like Fedora. To do this, we need a separate Fedora
container for each build that provides the QEMU_CONFIGURE_OPTS
environment variable.
Unfortunately, the MinGW 64-bit compiler seems to be a little bit
slow, so we also have to disable some features like "capstone" in the
build here to make sure that the CI pipelines still finish within a
reasonable amount of time.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200921174320.46062-2-thuth@redhat.com>
Message-Id: <20200925154027.12672-10-alex.bennee@linaro.org>


  Commit: 5fdf6e22d9521b2c3a5a84b3d17141bf93572c0f
      
https://github.com/qemu/qemu/commit/5fdf6e22d9521b2c3a5a84b3d17141bf93572c0f
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab-ci: Remove the Debian9-based containers and containers-layer3

According to our support policy, Debian 9 is not supported by the
QEMU project anymore. Since we now switched the MinGW cross-compiler
builds to Fedora, we do not need these Debian9-based containers
in the gitlab-CI anymore, and can now also get rid of the "layer3"
container build stage this way.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200921174320.46062-3-thuth@redhat.com>
Message-Id: <20200925154027.12672-11-alex.bennee@linaro.org>


  Commit: cf63177e59206afbfe7c8c904fad72bb7ebf59ae
      
https://github.com/qemu/qemu/commit/cf63177e59206afbfe7c8c904fad72bb7ebf59ae
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M tests/docker/Makefile.include
    M tests/docker/dockerfiles/debian-tricore-cross.docker

  Log Message:
  -----------
  tests/docker: Update the tricore container to debian 10

We do not support Debian 9 anymore, thus update the Tricore container
to Debian 10 now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200921174320.46062-4-thuth@redhat.com>
Message-Id: <20200925154027.12672-12-alex.bennee@linaro.org>


  Commit: 4a73cefbdaa3ac7dc470036ba07fab899da73f77
      
https://github.com/qemu/qemu/commit/4a73cefbdaa3ac7dc470036ba07fab899da73f77
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .shippable.yml

  Log Message:
  -----------
  shippable.yml: Remove the Debian9-based MinGW cross-compiler tests

We're not supporting Debian 9 anymore, and we are now testing
MinGW cross-compiler builds in the gitlab-CI, too, so we do not
really need these jobs in the shippable.yml anymore.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200921174320.46062-5-thuth@redhat.com>
Message-Id: <20200925154027.12672-13-alex.bennee@linaro.org>


  Commit: e3755276d1f5462fb14e25e558e50b1e477406d7
      
https://github.com/qemu/qemu/commit/e3755276d1f5462fb14e25e558e50b1e477406d7
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    R tests/docker/dockerfiles/debian-win32-cross.docker
    R tests/docker/dockerfiles/debian-win64-cross.docker
    R tests/docker/dockerfiles/debian9-mxe.docker
    R tests/docker/dockerfiles/debian9.docker

  Log Message:
  -----------
  tests/docker: Remove old Debian 9 containers

We do not support Debian 9 in QEMU anymore, and the Debian 9 containers
are now no longer used in the gitlab-CI. Time to remove them.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200921174320.46062-6-thuth@redhat.com>
Message-Id: <20200925154027.12672-14-alex.bennee@linaro.org>


  Commit: 254ef17e3f444d1bee03a4274fdd59e853321d5e
      
https://github.com/qemu/qemu/commit/254ef17e3f444d1bee03a4274fdd59e853321d5e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/crossbuilds.yml

  Log Message:
  -----------
  gitlab-ci: Increase the timeout for the cross-compiler builds

Some of the cross-compiler builds (the mips build and the win64 build
for example) are quite slow and sometimes hit the 1h time limit.
Increase the limit a little bit to make sure that we do not get failures
in the CI runs just because of some few minutes.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200921174320.46062-7-thuth@redhat.com>
Message-Id: <20200925154027.12672-15-alex.bennee@linaro.org>


  Commit: 1b11f28d05121fec43a12389b673cc2d7e1d2e26
      
https://github.com/qemu/qemu/commit/1b11f28d05121fec43a12389b673cc2d7e1d2e26
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M configure
    M docs/conf.py
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  configure: Bump the minimum required Python version to 3.6

All our supported build platforms have Python 3.6 or newer nowadays, and
there are some useful features in Python 3.6 which are not available in
3.5 yet (e.g. the type hint annotations which will allow us to statically
type the QAPI parser), so let's bump the minimum Python version to 3.6 now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200923162908.95372-1-thuth@redhat.com>
Message-Id: <20200925154027.12672-16-alex.bennee@linaro.org>


  Commit: 8cdb2cef3f1c5f0d7c1fb96ed337d27d9b6267d6
      
https://github.com/qemu/qemu/commit/8cdb2cef3f1c5f0d7c1fb96ed337d27d9b6267d6
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.yml
    M .travis.yml

  Log Message:
  -----------
  gitlab: move linux-user plugins test across to gitlab

Even with the recent split moving beefier plugins into contrib and
dropping them from the check-tcg tests we are still hitting time
limits. This possibly points to a slow down of --debug-tcg but seeing
as we are migrating stuff to gitlab we might as well move there and
bump the timeout.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201002103223.24022-1-alex.bennee@linaro.org>


  Commit: 2614670b7585ce4ec503546bc3023844d392f270
      
https://github.com/qemu/qemu/commit/2614670b7585ce4ec503546bc3023844d392f270
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.yml

  Log Message:
  -----------
  gitlab: split deprecated job into build/check stages

While the job is pretty fast for only a few targets we still want to
catch breakage of the build. By splitting the test step we can
allow_failures for that while still ensuring we don't miss the build
breaking.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201002091538.3017-1-alex.bennee@linaro.org>


  Commit: 0d2a4545bf7e763984d3ee3e802617544cb7fc7a
      
https://github.com/qemu/qemu/commit/0d2a4545bf7e763984d3ee3e802617544cb7fc7a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M .gitlab-ci.d/crossbuilds.yml
    M .gitlab-ci.yml
    M .shippable.yml
    M .travis.yml
    M configure
    M docs/conf.py
    M migration/global_state.c
    M tests/docker/Makefile.include
    M tests/docker/dockerfiles/debian-tricore-cross.docker
    R tests/docker/dockerfiles/debian-win32-cross.docker
    R tests/docker/dockerfiles/debian-win64-cross.docker
    R tests/docker/dockerfiles/debian9-mxe.docker
    R tests/docker/dockerfiles/debian9.docker
    A tests/docker/dockerfiles/fedora-win32-cross.docker
    A tests/docker/dockerfiles/fedora-win64-cross.docker
    M tests/qemu-iotests/iotests.py

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-testing-and-python-021020-1' into staging

Python testing updates:

  - drop python 3.5 test from travis
  - replace Debian 9 containers with 10
  - increase cross build timeout
  - bump minimum python version in configure
  - move user plugins tests to gitlab
  - split deprecated builds into build and test

# gpg: Signature made Fri 02 Oct 2020 12:34:36 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-testing-and-python-021020-1:
  gitlab: split deprecated job into build/check stages
  gitlab: move linux-user plugins test across to gitlab
  configure: Bump the minimum required Python version to 3.6
  gitlab-ci: Increase the timeout for the cross-compiler builds
  tests/docker: Remove old Debian 9 containers
  shippable.yml: Remove the Debian9-based MinGW cross-compiler tests
  tests/docker: Update the tricore container to debian 10
  gitlab-ci: Remove the Debian9-based containers and containers-layer3
  tests/docker: Use Fedora containers for MinGW cross-builds in the gitlab-CI
  travis.yml: Drop the Python 3.5 build
  travis.yml: Drop the superfluous Python 3.6 build
  travis.yml: Update Travis to use Bionic and Focal instead of Xenial
  travis.yml: Drop the default softmmu builds
  migration: Silence compiler warning in global_state_store_running()

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b5ce42f5d138...0d2a4545bf7e



reply via email to

[Prev in Thread] Current Thread [Next in Thread]