[Qemu-commits] [qemu/qemu] 2cd1e3: ui/gtk-gl-area: Plug memleak in gd_gl_area_create_...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2cd1e3f91582efbee497a0069f6cbe19f324f0b3
      
https://github.com/qemu/qemu/commit/2cd1e3f91582efbee497a0069f6cbe19f324f0b3
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M ui/gtk-gl-area.c

  Log Message:
  -----------
  ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

Receiving error in local variable err, and forgot to free it.
This patch check the return value of 'gdk_window_create_gl_context'
and 'gdk_gl_context_realize', then free err to fix it.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Message-Id: <20200831134315.1221-6-pannengyuan@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 7791acaf3d1852cea4b0e82d07c6577faec6e900
      
https://github.com/qemu/qemu/commit/7791acaf3d1852cea4b0e82d07c6577faec6e900
  Author: Pan Nengyuan <pannengyuan@huawei.com>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M ui/vnc-auth-sasl.c

  Log Message:
  -----------
  vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string

'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200831134315.1221-11-pannengyuan@huawei.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 5b57a87e4eb42c78e26c88dd7d88005c55b93be1
      
https://github.com/qemu/qemu/commit/5b57a87e4eb42c78e26c88dd7d88005c55b93be1
  Author: Frediano Ziglio <freddy77@gmail.com>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M ui/spice-input.c

  Log Message:
  -----------
  ui: Add more mouse buttons to SPICE

Add support for SIDE and EXTRA buttons.

The constants for buttons in both SPICE and QEMU are defined as
  LEFT
  MIDDLE
  RIGHT
  UP
  DOWN
  SIDE
  EXTRA
(same order).

"button_mask" contains for each bit the state of a button. Qemu currently
uses bits 0, 1, 2 respectively as LEFT, RIGHT, MIDDLE; also add bits 4
and 5 as UP and DOWN (using wheel movements). SPICE protocol uses
a bitmask based on the order above where LEFT is bit 0, MIDDLE is
bit 1 and so on till EXTRA being bit 6. To avoid clash with Qemu usage
SPICE bitmask from SIDE are move a bit more resulting respectively
in 0x40 and 0x80 values.

Signed-off-by: Frediano Ziglio <freddy77@gmail.com>
Message-id: 20200820145851.50846-1-fziglio@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: dc26435edb469ebdadf298dc3945b95d08f743d4
      
https://github.com/qemu/qemu/commit/dc26435edb469ebdadf298dc3945b95d08f743d4
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-09-04 (Fri, 04 Sep 2020)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: Update refresh interval after widget is realized

Nikola reported on Windows when gd_vc_gfx_init() is called, the
window is not yet realized, so we run gd_refresh_rate_millihz(NULL)
which returns 0 milli-Hertz.
When a Widget is realized, it fires a 'realized' event. We already
have the gd_draw_event() handler registered for this even, so simply
move the gd_refresh_rate_millihz() there. When the event fires, the
window is known to exist.
This completes commit c4c00922cc original intention.

Reported-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Tested-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200817172331.598255-1-philmd@redhat.com
Suggested-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Tested-by: Nikola Pavlica <pavlica.nikola@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 7c37270b3fbe3d034ba80e488761461676e21eb4
      
https://github.com/qemu/qemu/commit/7c37270b3fbe3d034ba80e488761461676e21eb4
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-09-06 (Sun, 06 Sep 2020)

  Changed paths:
    M ui/gtk-gl-area.c
    M ui/gtk.c
    M ui/spice-input.c
    M ui/vnc-auth-sasl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20200904-pull-request' 
into staging

ui: memleak fixes.
gtk: refresh interval fix.
spice: add mouse buttons.

# gpg: Signature made Fri 04 Sep 2020 08:00:55 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20200904-pull-request:
  ui/gtk: Update refresh interval after widget is realized
  ui: Add more mouse buttons to SPICE
  vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string
  ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/227de21ed075...7c37270b3fbe