[Qemu-commits] [qemu/qemu] cb3fa1: coccinelle/err-bad-newline: Fix for Python 3, and ...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cb3fa1e4c05a4ad2563b39cdb1146e617f3b5424
      
https://github.com/qemu/qemu/commit/cb3fa1e4c05a4ad2563b39cdb1146e617f3b5424
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M scripts/coccinelle/err-bad-newline.cocci

  Log Message:
  -----------
  coccinelle/err-bad-newline: Fix for Python 3, and add patterns

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200722084048.1726105-2-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>


  Commit: ff5b5d5b6df5655946142820912b28f1a67efc94
      
https://github.com/qemu/qemu/commit/ff5b5d5b6df5655946142820912b28f1a67efc94
  Author: Markus Armbruster <armbru@redhat.com>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M hw/i386/intel_iommu.c
    M target/ppc/mmu-hash64.c

  Log Message:
  -----------
  error: Strip trailing '\n' from error string arguments (again)

Tracked down with scripts/coccinelle/err-bad-newline.cocci.

Cc: Peter Xu <peterx@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200722084048.1726105-3-armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Peter Xu <peterx@redhat.com>


  Commit: 838886378eac879771708100a08a1099173d6935
      
https://github.com/qemu/qemu/commit/838886378eac879771708100a08a1099173d6935
  Author: Stefan Weil <sw@weilnetz.de>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M hw/sd/milkymist-memcard.c

  Log Message:
  -----------
  sd/milkymist-memcard: Fix format string

Fixes: b98e8d1230ff7023bb34ddeb7194424dfcbaf789
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20200722204054.1400555-1-sw@weilnetz.de>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>


  Commit: 192cf54ac5408d21c20c17b3794a632970bbb880
      
https://github.com/qemu/qemu/commit/192cf54ac5408d21c20c17b3794a632970bbb880
  Author: Philippe Mathieu-Daudé <philmd@redhat.com>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M include/qapi/error.h

  Log Message:
  -----------
  qapi/error: Check format string argument in error_*prepend()

error_propagate_prepend() "behaves like error_prepend()", and
error_prepend() uses "formatting @fmt, ... like printf()".
error_prepend() checks its format string argument, but
error_propagate_prepend() does not. Fix by addint the format
attribute to error_propagate_prepend() and error_vprepend().

This would have caught the bug fixed in the previous commit.

Missed in commit 4b5766488f "error: Fix use of error_prepend() with
&error_fatal, &error_abort".

Inspired-by: Stefan Weil <sw@weilnetz.de>
Suggested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200723171205.14949-1-philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>


  Commit: e68808a797d0c585b0e82e4a788d1ba8899b01eb
      
https://github.com/qemu/qemu/commit/e68808a797d0c585b0e82e4a788d1ba8899b01eb
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-24 (Fri, 24 Jul 2020)

  Changed paths:
    M hw/i386/intel_iommu.c
    M hw/sd/milkymist-memcard.c
    M include/qapi/error.h
    M scripts/coccinelle/err-bad-newline.cocci
    M target/ppc/mmu-hash64.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-24' into 
staging

Error reporting patches patches for 2020-07-24

# gpg: Signature made Fri 24 Jul 2020 14:03:44 BST
# gpg:                using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg:                issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [full]
# gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>" [full]
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-error-2020-07-24:
  qapi/error: Check format string argument in error_*prepend()
  sd/milkymist-memcard: Fix format string
  error: Strip trailing '\n' from error string arguments (again)
  coccinelle/err-bad-newline: Fix for Python 3, and add patterns

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/7adfbea8fd1e...e68808a797d0