[Qemu-commits] [qemu/qemu] 7da1d7: qemu/osdep: Document os_find_datadir() return value

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7da1d7dcc0c08519b92d8af579fec2e2ea9e60b1
      
https://github.com/qemu/qemu/commit/7da1d7dcc0c08519b92d8af579fec2e2ea9e60b1
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M os-posix.c
    M os-win32.c

  Log Message:
  -----------
  qemu/osdep: Document os_find_datadir() return value

Document os_find_datadir() returned data must be freed.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-2-f4bug@amsat.org>


  Commit: d450cccc9a4f4409434f4bd0a80270836f6bc3c3
      
https://github.com/qemu/qemu/commit/d450cccc9a4f4409434f4bd0a80270836f6bc3c3
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M include/qemu/osdep.h

  Log Message:
  -----------
  qemu/osdep: Reword qemu_get_exec_dir() documentation

This comment is confuse, reword it a bit.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-3-f4bug@amsat.org>


  Commit: b6c61f69349ca3706c7e757ec1f2df916b70de7a
      
https://github.com/qemu/qemu/commit/b6c61f69349ca3706c7e757ec1f2df916b70de7a
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M include/qemu-common.h

  Log Message:
  -----------
  qemu-common: Document qemu_find_file()

Document qemu_find_file(), in particular the returned
value which must be freed.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-4-f4bug@amsat.org>


  Commit: 5e29521a82e540552880c3572cb8274bcaa1002c
      
https://github.com/qemu/qemu/commit/5e29521a82e540552880c3572cb8274bcaa1002c
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M hw/avr/boot.c

  Log Message:
  -----------
  hw/avr/boot: Fix memory leak in avr_load_firmware()

The value returned by qemu_find_file() must be freed.

This fixes Coverity issue CID 1430449, which points out
that the memory returned by qemu_find_file() is leaked.

Fixes: Coverity CID 1430449 (RESOURCE_LEAK)
Fixes: 7dd8f6fde4 ('hw/avr: Add support for loading ELF/raw binaries')
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Michael Rolnik <mrolnik@gmail.com>
Tested-by: Michael Rolnik <mrolnik@gmail.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20200714164257.23330-5-f4bug@amsat.org>


  Commit: 53ce7b47b5bf47db067b81c18c786ed7b792d031
      
https://github.com/qemu/qemu/commit/53ce7b47b5bf47db067b81c18c786ed7b792d031
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-23 (Thu, 23 Jul 2020)

  Changed paths:
    M hw/avr/boot.c
    M include/qemu-common.h
    M include/qemu/osdep.h
    M os-posix.c
    M os-win32.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/philmd-gitlab/tags/avr-20200721' into 
staging

AVR patches

Fixes a memory leak reported by Coverity (CID 1430449).

CI jobs result:
. https://gitlab.com/philmd/qemu/-/pipelines/168722631

# gpg: Signature made Tue 21 Jul 2020 19:00:03 BST
# gpg:                using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <f4bug@amsat.org>" 
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD  6BB2 E3E3 2C2C DEAD C0DE

* remotes/philmd-gitlab/tags/avr-20200721:
  hw/avr/boot: Fix memory leak in avr_load_firmware()
  qemu-common: Document qemu_find_file()
  qemu/osdep: Reword qemu_get_exec_dir() documentation
  qemu/osdep: Document os_find_datadir() return value

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/d0cc24816496...53ce7b47b5bf