[Qemu-commits] [qemu/qemu] 1f4367: i368/cpu: Clear env->user_features after loading v...

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1f43671a0d55d863f9111535ca4241e9fa238506
      
https://github.com/qemu/qemu/commit/1f43671a0d55d863f9111535ca4241e9fa238506
  Author: Xiaoyao Li <xiaoyao.li@intel.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  i368/cpu: Clear env->user_features after loading versioned CPU model

Features defined in versioned CPU model are recorded in env->user_features
since they are updated as property. It's unwated because they are not
user specified.

Simply clear env->user_features as a fix. It won't clear user specified
features because user specified features are filled to
env->user_features later in x86_cpu_expand_features().

Cc: Chenyi Qiang <chenyi.qiang@intel.com>
Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Message-Id: <20200713174436.41070-2-xiaoyao.li@intel.com>
[ehabkost: fix coding style]
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: f9f08e7cae8a6c292cacaf6531ede88786fcb3d3
      
https://github.com/qemu/qemu/commit/f9f08e7cae8a6c292cacaf6531ede88786fcb3d3
  Author: Xiaoyao Li <xiaoyao.li@intel.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  i386/cpu: Don't add unavailable_features to env->user_features

Features unavailable due to absent of their dependent features should
not be added to env->user_features. env->user_features only contains the
feature explicity specified with -feature/+feature by user.

Fixes: 99e24dbdaa68 ("target/i386: introduce generic feature dependency 
mechanism")
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Message-Id: <20200713174436.41070-3-xiaoyao.li@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: 5cb287d2bd578dfe4897458793b4fce35bc4f744
      
https://github.com/qemu/qemu/commit/5cb287d2bd578dfe4897458793b4fce35bc4f744
  Author: Chenyi Qiang <chenyi.qiang@intel.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c
    M target/i386/cpu.h

  Log Message:
  -----------
  target/i386: add fast short REP MOV support

For CPUs support fast short REP MOV[CPUID.(EAX=7,ECX=0):EDX(bit4)], e.g
Icelake and Tigerlake, expose it to the guest VM.

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20200714084148.26690-2-chenyi.qiang@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: e0013791b9326945ccd09b5b602437beb322cab8
      
https://github.com/qemu/qemu/commit/e0013791b9326945ccd09b5b602437beb322cab8
  Author: Chenyi Qiang <chenyi.qiang@intel.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  target/i386: fix model number and add missing features for Icelake-Server CPU 
model

Add the missing features(sha_ni, avx512ifma, rdpid, fsrm,
vmx-rdseed-exit, vmx-pml, vmx-eptp-switching) and change the model
number to 106 in the Icelake-Server-v4 CPU model.

Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20200714084148.26690-3-chenyi.qiang@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: 644e3c5d812d1d672388124eeb43d0e26b3ff58c
      
https://github.com/qemu/qemu/commit/644e3c5d812d1d672388124eeb43d0e26b3ff58c
  Author: Chenyi Qiang <chenyi.qiang@intel.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  target/i386: add the missing vmx features for Skylake-Server and 
Cascadelake-Server CPU models

Add the missing vmx features in Skylake-Server and Cascadelake-Server
CPU models based on the output of Paolo's script.

Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
Message-Id: <20200714084148.26690-4-chenyi.qiang@intel.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: 818b9f111d64b40661d08f5e23236ac1ca5df505
      
https://github.com/qemu/qemu/commit/818b9f111d64b40661d08f5e23236ac1ca5df505
  Author: Roman Bolshakov <r.bolshakov@yadro.com>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/hvf/vmx.h

  Log Message:
  -----------
  i386: hvf: Explicitly set CR4 guest/host mask

Removal of register reset omitted initialization of CR4 guest/host mask.
x86_64 guests aren't booting without it.

Fixes: 5009ef22c6bb2 ("i386: hvf: Don't duplicate register reset")
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Message-Id: <20200714090726.41082-1-r.bolshakov@yadro.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>


  Commit: 151f76c689b1ff4c2c59e6d8469a0d4fe5346f55
      
https://github.com/qemu/qemu/commit/151f76c689b1ff4c2c59e6d8469a0d4fe5346f55
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-16 (Thu, 16 Jul 2020)

  Changed paths:
    M target/i386/cpu.c
    M target/i386/cpu.h
    M target/i386/hvf/vmx.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' 
into staging

x86 fixes for -rc1

Fixes for x86 that missed hard freeze:
* Don't trigger warnings for features set by
  CPU model versions (Xiaoyao Li)
* Missing features in Icelake-Server, Skylake-Server,
  Cascadelake-Server CPU models (Chenyi Qiang)
* Fix hvf x86_64 guest boot crash (Roman Bolshakov)

# gpg: Signature made Thu 16 Jul 2020 19:17:18 BST
# gpg:                using RSA key 5A322FD5ABC4D3DBACCFD1AA2807936F984DC5A6
# gpg:                issuer "ehabkost@redhat.com"
# gpg: Good signature from "Eduardo Habkost <ehabkost@redhat.com>" [full]
# Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6

* remotes/ehabkost/tags/x86-next-pull-request:
  i386: hvf: Explicitly set CR4 guest/host mask
  target/i386: add the missing vmx features for Skylake-Server and 
Cascadelake-Server CPU models
  target/i386: fix model number and add missing features for Icelake-Server CPU 
model
  target/i386: add fast short REP MOV support
  i386/cpu: Don't add unavailable_features to env->user_features
  i368/cpu: Clear env->user_features after loading versioned CPU model

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/95d1fbabae0c...151f76c689b1