[Qemu-commits] [qemu/qemu] 93154e: docs/devel: fix grammar in multi-thread-tcg

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 93154e767f1b886e6d258178821d400333042a22
      
https://github.com/qemu/qemu/commit/93154e767f1b886e6d258178821d400333042a22
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M docs/devel/multi-thread-tcg.rst

  Log Message:
  -----------
  docs/devel: fix grammar in multi-thread-tcg

Review comment came just too late ;-)

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200713200415.26214-9-alex.bennee@linaro.org>


  Commit: a77312e77c7d19702aa4e2ddefd20cae060a7fb9
      
https://github.com/qemu/qemu/commit/a77312e77c7d19702aa4e2ddefd20cae060a7fb9
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M tests/docker/dockerfiles/ubuntu2004.docker

  Log Message:
  -----------
  tests/docker: Remove the libssh workaround from the ubuntu 20.04 image

The libssh problem only exists in Ubuntu 18.04 - we can enable it
in 20.04 again.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200713185237.9419-1-thuth@redhat.com>
Message-Id: <20200713200415.26214-3-alex.bennee@linaro.org>


  Commit: f73e485285bc2da944a08e1dd20a30df93e23f25
      
https://github.com/qemu/qemu/commit/f73e485285bc2da944a08e1dd20a30df93e23f25
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M tests/docker/docker.py

  Log Message:
  -----------
  docker.py: fix fetching of FROM layers

This worked on a system that was already bootstrapped because the
stage 2 images already existed even if they wouldn't be used. What we
should have pulled down was the FROM line containers first because
building on gitlab doesn't have the advantage of using our build
system to build the pre-requisite bits.

We still pull the image we want to build just in case we can use the
cached data.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200713200415.26214-4-alex.bennee@linaro.org>


  Commit: 6f60a240f60122fe2df402402311bf425f34e553
      
https://github.com/qemu/qemu/commit/6f60a240f60122fe2df402402311bf425f34e553
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml

  Log Message:
  -----------
  gitlab-ci/containers: Add missing wildcard where we should look for changes

The tests/docker/* wildcard seems to only match the files that are directly
in the tests/docker folder - but changes to the files in the directory
tests/docker/dockerfiles are currently ignored. Seems like we need a
separate entry to match the files in that folder. With this wildcard added,
the stages now get re-run successfully when something in the dockerfiles
has been changed.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200713182235.30379-1-thuth@redhat.com>


  Commit: 8cdf91243f7515f424b78d5469d64c34ee534783
      
https://github.com/qemu/qemu/commit/8cdf91243f7515f424b78d5469d64c34ee534783
  Author: LIU Zhiwei <zhiwei_liu@c-sky.com>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M fpu/softfloat-specialize.inc.c

  Log Message:
  -----------
  fpu/softfloat: fix up float16 nan recognition

Signed-off-by: LIU Zhiwei <zhiwei_liu@c-sky.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200712234521.3972-2-zhiwei_liu@c-sky.com>
Message-Id: <20200713200415.26214-5-alex.bennee@linaro.org>


  Commit: 777dddc501fa31bc9afff6de5e55dbf799e1703b
      
https://github.com/qemu/qemu/commit/777dddc501fa31bc9afff6de5e55dbf799e1703b
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M configure
    M tests/plugin/Makefile

  Log Message:
  -----------
  tests/plugins: don't unconditionally add -Wpsabi

Not all compilers support the -Wpsabi (clang-9 in my case). To handle
this gracefully we pare back the shared build machinery so the
Makefile is relatively "standalone". We still take advantage of
config-host.mak as configure has done a bunch of probing for us but
that is it.

Fixes: bac8d222a
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200713200415.26214-6-alex.bennee@linaro.org>


  Commit: 2f3a57ee47df970d19fa5b324d44aab857d43517
      
https://github.com/qemu/qemu/commit/2f3a57ee47df970d19fa5b324d44aab857d43517
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M accel/tcg/cputlb.c
    M include/hw/core/cpu.h
    M include/qemu/typedefs.h

  Log Message:
  -----------
  cputlb: ensure we save the IOTLB data in case of reset

Any write to a device might cause a re-arrangement of memory
triggering a TLB flush and potential re-size of the TLB invalidating
previous entries. This would cause users of qemu_plugin_get_hwaddr()
to see the warning:

  invalid use of qemu_plugin_get_hwaddr

because of the failed tlb_lookup which should always succeed. To
prevent this we save the IOTLB data in case it is later needed by a
plugin doing a lookup.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200713200415.26214-7-alex.bennee@linaro.org>


  Commit: 406b53c9ca669b8551d4cde27f2cde03135d0d1d
      
https://github.com/qemu/qemu/commit/406b53c9ca669b8551d4cde27f2cde03135d0d1d
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M tests/plugin/bb.c

  Log Message:
  -----------
  plugins: expand the bb plugin to be thread safe and track per-cpu

While there isn't any easy way to make the inline counts thread safe
we can ensure the callback based ones are. While we are at it we can
reduce introduce a new option ("idle") to dump a report of the current
bb and insn count each time a vCPU enters the idle state.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Robert Foley <robert.foley@linaro.org>
Cc: Dave Bort <dbort@dbort.com>

Message-Id: <20200713200415.26214-8-alex.bennee@linaro.org>


  Commit: 0571d280d057b851e3bb3ea7c350b86c950aea6e
      
https://github.com/qemu/qemu/commit/0571d280d057b851e3bb3ea7c350b86c950aea6e
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis.yml: skip ppc64abi32-linux-user with plugins

We actually see failures on threadcount running without plugins:

  retry.py -n 1000 -c -- \
    ./ppc64abi32-linux-user/qemu-ppc64abi32 \
    ./tests/tcg/ppc64abi32-linux-user/threadcount

which reports:

  0: 978 times (97.80%), avg time 0.270 (0.01 varience/0.08 deviation)
  -6: 21 times (2.10%), avg time 0.336 (0.01 varience/0.12 deviation)
  -11: 1 times (0.10%), avg time 0.502 (0.00 varience/0.00 deviation)
  Ran command 1000 times, 978 passes

But when running with plugins we hit the failure a lot more often:

  0: 91 times (91.00%), avg time 0.302 (0.04 varience/0.19 deviation)
  -11: 9 times (9.00%), avg time 0.558 (0.01 varience/0.11 deviation)
  Ran command 100 times, 91 passes

The crash occurs in guest code which is the same in both pass and fail
cases. However we see various messages reported on the console about
corrupted memory lists which seems to imply the guest memory allocation
is corrupted. This lines up with the seg fault being in the guest
__libc_free function. So we think this is a guest bug which is
exacerbated by various modes of translation. If anyone has access to
real hardware to soak test the test case we could prove this properly.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200714175516.5475-1-alex.bennee@linaro.org>


  Commit: dfcade7cefb433f8cf46788b771a085a625286d8
      
https://github.com/qemu/qemu/commit/dfcade7cefb433f8cf46788b771a085a625286d8
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M .gitlab-ci.d/containers.yml
    M .travis.yml
    M accel/tcg/cputlb.c
    M configure
    M docs/devel/multi-thread-tcg.rst
    M fpu/softfloat-specialize.inc.c
    M include/hw/core/cpu.h
    M include/qemu/typedefs.h
    M tests/docker/docker.py
    M tests/docker/dockerfiles/ubuntu2004.docker
    M tests/plugin/Makefile
    M tests/plugin/bb.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-misc-for-rc0-150720-3' into staging

Final fixes for 5.1-rc0

  - minor documentation nit
  - docker.py bootstrap fixes
  - tweak containers.yml wildcards
  - fix float16 nan detection
  - conditional use of -Wpsabi
  - fix missing iotlb data for plugins
  - proper locking for helper based bb count
  - drop ppc64abi32 from the plugin check-tcg test

# gpg: Signature made Wed 15 Jul 2020 11:59:08 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-misc-for-rc0-150720-3:
  .travis.yml: skip ppc64abi32-linux-user with plugins
  plugins: expand the bb plugin to be thread safe and track per-cpu
  cputlb: ensure we save the IOTLB data in case of reset
  tests/plugins: don't unconditionally add -Wpsabi
  fpu/softfloat: fix up float16 nan recognition
  gitlab-ci/containers: Add missing wildcard where we should look for changes
  docker.py: fix fetching of FROM layers
  tests/docker: Remove the libssh workaround from the ubuntu 20.04 image
  docs/devel: fix grammar in multi-thread-tcg

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 8746309137ba470d1b2e8f5ce86ac228625db940
      
https://github.com/qemu/qemu/commit/8746309137ba470d1b2e8f5ce86ac228625db940
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for v5.1.0-rc0 release

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/f1d594866904...8746309137ba