[Qemu-commits] [qemu/qemu] 4f50d4: ossaudio: fix out of bounds write

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4f50d4a48e0caa1aad591f3ca437502e33b8699d
      
https://github.com/qemu/qemu/commit/4f50d4a48e0caa1aad591f3ca437502e33b8699d
  Author: Volker Rümelin <vr_qemu@t-online.de>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M audio/ossaudio.c

  Log Message:
  -----------
  ossaudio: fix out of bounds write

In function oss_read() a read error currently does not exit the
read loop. With no data to read the variable pos will quickly
underflow and a subsequent successful read overwrites memory
outside the buffer. This patch adds the missing break statement
to the error path of the function.

To reproduce start qemu with -audiodev oss,id=audio0 and in the
guest start audio recording. After some time this will trigger
an exception.

Fixes: 3ba4066d08 "ossaudio: port to the new audio backend api"

Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20200707180836.5435-1-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 480324ec8d76582fa1c367cc9a0fdb653d4ea96e
      
https://github.com/qemu/qemu/commit/480324ec8d76582fa1c367cc9a0fdb653d4ea96e
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M docs/qdev-device-use.txt

  Log Message:
  -----------
  docs/qdev-device-use: Clean up the sentences related to -usbdevice

Most of the -usbdevice paramaters have been removed already. Update
the doc accordingly.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-id: 20200710065520.24784-1-thuth@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 185951817dede3dfe4eb1c4c6d262607bee605ef
      
https://github.com/qemu/qemu/commit/185951817dede3dfe4eb1c4c6d262607bee605ef
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  ui: fix vc_chr_write call in text_console_do_init

In case the string doesn't fit into the buffer snprintf returns the size
it would need, so len can be larger than the buffer.  Fix this by simply
using g_strdup_printf() instead of a static buffer.

Reported-by: Wenxiang Qian <leonwxqian@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20200701181801.27935-1-kraxel@redhat.com


  Commit: 631009e775a91018a62e2670b4473e99916f858f
      
https://github.com/qemu/qemu/commit/631009e775a91018a62e2670b4473e99916f858f
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M hw/usb/host-libusb.c

  Log Message:
  -----------
  usb: fix usb-host build on windows.

Seems the new API is not available on windows.
Update #ifdefs accordingly.

Fixes: 9f815e83e983 ("usb: add hostdevice property to usb-host")
Reported-by: Howard Spoelstra <hsp.cat7@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
Message-id: 20200624134510.9381-1-kraxel@redhat.com


  Commit: 20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46
      
https://github.com/qemu/qemu/commit/20c1df5476e1e9b5d3f5b94f9f3ce01d21f14c46
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-07-13 (Mon, 13 Jul 2020)

  Changed paths:
    M audio/ossaudio.c
    M docs/qdev-device-use.txt
    M hw/usb/host-libusb.c
    M ui/console.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/fixes-20200713-pull-request' into staging

bugfixes for audio, usb, ui and docs.

# gpg: Signature made Mon 13 Jul 2020 15:10:35 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/fixes-20200713-pull-request:
  usb: fix usb-host build on windows.
  ui: fix vc_chr_write call in text_console_do_init
  docs/qdev-device-use: Clean up the sentences related to -usbdevice
  ossaudio: fix out of bounds write

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/5c65b1f135ff...20c1df5476e1