qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 2fd51b: decodetree: Tidy error_with_file


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 2fd51b: decodetree: Tidy error_with_file
Date: Thu, 11 Jun 2020 05:15:33 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2fd51b19c9ee73b0a1f07dcebd753a00f4fa4b26
      
https://github.com/qemu/qemu/commit/2fd51b19c9ee73b0a1f07dcebd753a00f4fa4b26
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Tidy error_with_file

Use proper varargs to print the arguments.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 040145c4f8dad9391031203315b5ae4bae8dde1a
      
https://github.com/qemu/qemu/commit/040145c4f8dad9391031203315b5ae4bae8dde1a
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Rename MultiPattern to IncMultiPattern

Name the current node for "inclusive" multi-pattern, in
preparation for adding a node for "exclusive" multi-pattern.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: df63044d02bf79241257bafe282d966c86933b68
      
https://github.com/qemu/qemu/commit/df63044d02bf79241257bafe282d966c86933b68
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Split out MultiPattern from IncMultiPattern

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: b44b3449a08818f0eb25b93faaf535e9c9a85e50
      
https://github.com/qemu/qemu/commit/b44b3449a08818f0eb25b93faaf535e9c9a85e50
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py
    R tests/decode/err_pattern_group_nest1.decode
    A tests/decode/succ_pattern_group_nest2.decode

  Log Message:
  -----------
  decodetree: Allow group covering the entire insn space

This is an edge case for sure, but the logic that disallowed
this case was faulty.  Further, a few fixes scattered about
can allow this to work.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 08561fc1283568d9892033f98651010a18d8f108
      
https://github.com/qemu/qemu/commit/08561fc1283568d9892033f98651010a18d8f108
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Move semantic propagation into classes

Create ExcMultiPattern to hold an set of non-overlapping patterns.
The body of build_tree, prop_format become member functions on this
class.  Add minimal member functions to Pattern and MultiPattern
to allow recusion through the tree.

Move the bulk of build_incmulti_pattern to prop_masks and prop_width
in MultiPattern, since we will need this for both kinds of containers.
Only perform prop_width for variablewidth.

Remove global patterns variable, and pass down container object into
parse_file from main.

No functional change in all of this.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 067e8b0f45d650ced89a638577b85443f3333480
      
https://github.com/qemu/qemu/commit/067e8b0f45d650ced89a638577b85443f3333480
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M scripts/decodetree.py

  Log Message:
  -----------
  decodetree: Implement non-overlapping groups

Intended to be nested within overlapping groups.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: 33c0f25bfd7af2848d078afe2876dcb0d5a1c6d3
      
https://github.com/qemu/qemu/commit/33c0f25bfd7af2848d078afe2876dcb0d5a1c6d3
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    A tests/decode/err_pattern_group_nest1.decode
    A tests/decode/err_pattern_group_nest2.decode
    A tests/decode/err_pattern_group_nest3.decode
    A tests/decode/succ_pattern_group_nest3.decode

  Log Message:
  -----------
  tests/decode: Test non-overlapping groups

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: fe079aa13d6f77f9d7323b58ab24448e73ae6a93
      
https://github.com/qemu/qemu/commit/fe079aa13d6f77f9d7323b58ab24448e73ae6a93
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M scripts/decodetree.py
    A tests/decode/succ_pattern_group_nest4.decode

  Log Message:
  -----------
  decodetree: Drop check for less than 2 patterns in a group

While it makes little sense for the end product to have a group
containing only a single pattern, avoiding this case within an
incremental patch set is troublesome.

Because this is expected to be a transient condition, do not
bother "optimizing" this case, e.g. by folding away the group.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: d6084fba47bb9aef79775c1102d4b647eb58c365
      
https://github.com/qemu/qemu/commit/d6084fba47bb9aef79775c1102d4b647eb58c365
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M target/arm/t32.decode

  Log Message:
  -----------
  target/arm: Use a non-overlapping group for misc control

The miscellaneous control instructions are mutually exclusive
within the t32 decode sub-group.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


  Commit: c291aca63d654c35e9e0e3c1312be23a3e529e6b
      
https://github.com/qemu/qemu/commit/c291aca63d654c35e9e0e3c1312be23a3e529e6b
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-06-11 (Thu, 11 Jun 2020)

  Changed paths:
    M scripts/decodetree.py
    M target/arm/t32.decode
    M tests/decode/err_pattern_group_nest1.decode
    A tests/decode/err_pattern_group_nest2.decode
    A tests/decode/err_pattern_group_nest3.decode
    A tests/decode/succ_pattern_group_nest2.decode
    A tests/decode/succ_pattern_group_nest3.decode
    A tests/decode/succ_pattern_group_nest4.decode

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-dt-20200609' into staging

Add non-overlapping groups

# gpg: Signature made Tue 09 Jun 2020 17:22:17 BST
# gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
# gpg:                issuer "richard.henderson@linaro.org"
# gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" 
[full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-dt-20200609:
  target/arm: Use a non-overlapping group for misc control
  decodetree: Drop check for less than 2 patterns in a group
  tests/decode: Test non-overlapping groups
  decodetree: Implement non-overlapping groups
  decodetree: Move semantic propagation into classes
  decodetree: Allow group covering the entire insn space
  decodetree: Split out MultiPattern from IncMultiPattern
  decodetree: Rename MultiPattern to IncMultiPattern
  decodetree: Tidy error_with_file

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/9e7f1469b999...c291aca63d65



reply via email to

[Prev in Thread] Current Thread [Next in Thread]