qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a98610: ati-vga: check mm_index before recurs


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a98610: ati-vga: check mm_index before recursive call (CVE...
Date: Fri, 05 Jun 2020 08:45:30 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a98610c429d52db0937c1e48659428929835c455
      
https://github.com/qemu/qemu/commit/a98610c429d52db0937c1e48659428929835c455
  Author: Prasad J Pandit <pjp@fedoraproject.org>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M hw/display/ati.c

  Log Message:
  -----------
  ati-vga: check mm_index before recursive call (CVE-2020-13800)

While accessing VGA registers via ati_mm_read/write routines,
a guest may set 's->regs.mm_index' such that it leads to infinite
recursion. Check mm_index value to avoid such recursion. Log an
error message for wrong values.

Reported-by: Ren Ding <rding@gatech.edu>
Reported-by: Hanqing Zhao <hanqing@gatech.edu>
Reported-by: Yi Ren <c4tren@gmail.com>
Message-id: 20200604090830.33885-1-ppandit@redhat.com
Suggested-by: BALATON Zoltan <balaton@eik.bme.hu>
Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: ae3887e6f08c0031b669d4613987ee51df8f1769
      
https://github.com/qemu/qemu/commit/ae3887e6f08c0031b669d4613987ee51df8f1769
  Author: Philippe Mathieu-Daudé <f4bug@amsat.org>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  hw/display/cirrus_vga: Fix code mis-indentation

While replacing fprintf() by qemu_log_mask() in commit
2b55f4d3504, we incorrectly used a 'tab = 4 spaces'
alignment, leading to misindented new code. Fix now.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200529165436.23573-1-f4bug@amsat.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>


  Commit: 5d2f557b47dfbf8f23277a5bdd8473d4607c681a
      
https://github.com/qemu/qemu/commit/5d2f557b47dfbf8f23277a5bdd8473d4607c681a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M hw/display/ati.c
    M hw/display/cirrus_vga.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200605-pull-request' 
into staging

vga: ati security fix, cirrus cleanup.

# gpg: Signature made Fri 05 Jun 2020 12:27:13 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/vga-20200605-pull-request:
  hw/display/cirrus_vga: Fix code mis-indentation
  ati-vga: check mm_index before recursive call (CVE-2020-13800)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b489f015fbe2...5d2f557b47df



reply via email to

[Prev in Thread] Current Thread [Next in Thread]