[Qemu-commits] [qemu/qemu] 3df437: configure: add alternate binary for genisoimage

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3df437c737984069fbc12fd0d2e0f2f2c5ba5d4c
      
https://github.com/qemu/qemu/commit/3df437c737984069fbc12fd0d2e0f2f2c5ba5d4c
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: add alternate binary for genisoimage

Not all distros ship genisoimage which is a Debian fork from the
original cdrtools. As the options are pretty much the same support it
as a fallback binary.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Message-Id: <20200519132259.405-2-robert.foley@linaro.org>


  Commit: 92fecad3d3ed3cbfd0a6b4408bb80920de803dca
      
https://github.com/qemu/qemu/commit/92fecad3d3ed3cbfd0a6b4408bb80920de803dca
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/vm/Makefile.include
    M tests/vm/basevm.py

  Log Message:
  -----------
  tests/vm: pass --genisoimage to basevm script

If we have an alternative to genisoimage we really need to tell the
script about it as well so it can use it. It will still default to
genisoimage in case it is run outside our build machinery.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Robert Foley <robert.foley@linaro.org>
Message-Id: <20200519132259.405-3-robert.foley@linaro.org>


  Commit: 6f83cf88f02a98e857b6cadd4b4e27401b901bba
      
https://github.com/qemu/qemu/commit/6f83cf88f02a98e857b6cadd4b4e27401b901bba
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis.yml: Use clang++ in the Clang tests

Our configure script does not look for clang++ automatically, so we
should use --cxx=clang++ to make sure that we test our C++ code with
Clang, too. And while we're at it, also use --host-cc=clang here
to avoid that we use the normal "cc" as host C compiler.

Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200518083316.25065-1-thuth@redhat.com>
Message-Id: <20200520140541.30256-4-alex.bennee@linaro.org>


  Commit: be9bc1b73a12f1ebfb2ce2f9edfacc5d1304561a
      
https://github.com/qemu/qemu/commit/be9bc1b73a12f1ebfb2ce2f9edfacc5d1304561a
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/tcg/aarch64/Makefile.softmmu-target

  Log Message:
  -----------
  tests/tcg: fix invocation of the memory record/replay tests

I'm not sure when this broke but we should use EXTRA_RUNS for
"virtual" tests which are not generated from the binary names.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Message-Id: <20200520140541.30256-5-alex.bennee@linaro.org>


  Commit: 91fa8b64cbef14855dc3bd24702416313dea6481
      
https://github.com/qemu/qemu/commit/91fa8b64cbef14855dc3bd24702416313dea6481
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/fp: enable extf80_le_quite tests

These have been fixed now so we no longer need a special version of
the le_quiet rule to skip the test.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200520140541.30256-6-alex.bennee@linaro.org>


  Commit: 8281a157c5d01c08e1d684bf7a28c3e2bebf1a96
      
https://github.com/qemu/qemu/commit/8281a157c5d01c08e1d684bf7a28c3e2bebf1a96
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/Makefile.include

  Log Message:
  -----------
  tests/fp: split and audit the conversion tests

Split the float conversion tests into separate groups and audit the
tests to check what is still broken. I was able to enable a bunch of
tests that had been missed before:

  all the float to float conversions
  ui32_to_extF80
  ui64_to_extF80
  extF80_to_ui32
  extF80_to_ui32_r_minMag
  extF80_to_ui64
  extF80_to_ui64_r_minMag

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200520140541.30256-7-alex.bennee@linaro.org>


  Commit: 8ec6f3315118ef75d37e9433dc8faa8383130fb6
      
https://github.com/qemu/qemu/commit/8ec6f3315118ef75d37e9433dc8faa8383130fb6
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/tcg/multiarch/gdbstub/sha1.py

  Log Message:
  -----------
  tests/tcg: better detect confused gdb which can't connect

While we may gamely give the right information it can still confuse
the wide range of GDBs out there. For example ppc64abi32-linux-user
reports:

  warning: Selected architecture powerpc:common is not compatible with reported 
target architecture powerpc:common64
  warning: Architecture rejected target-supplied description

but still connects. Add a test for a 0 pc and exit early if that is
the case. This may actually be a bug we need to fix?

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200520140541.30256-8-alex.bennee@linaro.org>


  Commit: 086f269cf4eb0d759d7f716dcd239e6d310bb955
      
https://github.com/qemu/qemu/commit/086f269cf4eb0d759d7f716dcd239e6d310bb955
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/docker/Makefile.include
    A tests/docker/dockerfiles/debian11.docker

  Log Message:
  -----------
  tests/docker: add debian11 base image

We won't use this for building QEMU but we do need newer GCC's and
binutils for building some of our test cases.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200520140541.30256-10-alex.bennee@linaro.org>


  Commit: c729a99d27018b8d619544b18926b234b010b733
      
https://github.com/qemu/qemu/commit/c729a99d27018b8d619544b18926b234b010b733
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/docker/Makefile.include
    A tests/docker/dockerfiles/debian-arm64-test-cross.docker
    M tests/tcg/configure.sh

  Log Message:
  -----------
  tests/docker: use a gcc-10 based image for arm64 tests

As we enable newer features that we want to test on arm64 targets we
need newer compilers. Split off a new debian-arm64-test-cross image
which we can use to build these new tests.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200520140541.30256-11-alex.bennee@linaro.org>


  Commit: 716386e397fabbbf9915d49f8bc79673fd2831bb
      
https://github.com/qemu/qemu/commit/716386e397fabbbf9915d49f8bc79673fd2831bb
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M cpus-common.c

  Log Message:
  -----------
  cpus-common: ensure auto-assigned cpu_indexes don't clash

Basing the cpu_index on the number of currently allocated vCPUs fails
when vCPUs aren't removed in a LIFO manner. This is especially true
when we are allocating a cpu_index for each guest thread in
linux-user where there is no ordering constraint on their allocation
and de-allocation.

[I've dropped the assert which is there to guard against out-of-order
removal as this should probably be caught higher up the stack. Maybe
we could just ifdef CONFIG_SOFTTMU it?]

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Igor Mammedow <imammedo@redhat.com>
Cc: Nikolay Igotti <igotti@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20200520140541.30256-13-alex.bennee@linaro.org>


  Commit: 1f81ce90e31ef338ee53a0cea02344237bc470cc
      
https://github.com/qemu/qemu/commit/1f81ce90e31ef338ee53a0cea02344237bc470cc
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: properly "unrealize" vCPU object

We shouldn't be messing around with the CPU list in linux-user save
for the very special case of do_fork(). When threads end we need to
properly follow QOM object lifetime handling and allow the eventual
cpu_common_unrealizefn to both remove the CPU and ensure any clean-up
actions are taken place, for example calling plugin exit hooks.

There is still a race condition to avoid so use the linux-user
specific clone_lock instead of the cpu_list_lock to avoid it.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Cc: Nikolay Igotti <igotti@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel P. Berrange <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200520140541.30256-14-alex.bennee@linaro.org>


  Commit: 919bfbf5d6569b63a374332292cf3d2355a6d6c3
      
https://github.com/qemu/qemu/commit/919bfbf5d6569b63a374332292cf3d2355a6d6c3
  Author: Alex Bennée <alex.bennee@linaro.org>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M tests/tcg/multiarch/Makefile.target
    A tests/tcg/multiarch/threadcount.c

  Log Message:
  -----------
  tests/tcg: add new threadcount test

Based on the original testcase by Nikolay Igotti.

Message-ID: <CAEme+7GLKg_dNsHizzTKDymX9HyD+Ph2iZ=WKhOw2XG+zhViXg@mail.gmail.com>
Signed-off-by: Nikolay Igotti <igotti@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20200520140541.30256-15-alex.bennee@linaro.org>


  Commit: c86274bc2e34295764fb44c2aef3cf29623f9b4b
      
https://github.com/qemu/qemu/commit/c86274bc2e34295764fb44c2aef3cf29623f9b4b
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M .travis.yml
    M configure
    M cpus-common.c
    M linux-user/syscall.c
    M tests/Makefile.include
    M tests/docker/Makefile.include
    A tests/docker/dockerfiles/debian-arm64-test-cross.docker
    A tests/docker/dockerfiles/debian11.docker
    M tests/tcg/aarch64/Makefile.softmmu-target
    M tests/tcg/configure.sh
    M tests/tcg/multiarch/Makefile.target
    M tests/tcg/multiarch/gdbstub/sha1.py
    A tests/tcg/multiarch/threadcount.c
    M tests/vm/Makefile.include
    M tests/vm/basevm.py

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-testing-tcg-plugins-270520-1' into staging

Testing and one plugin fix:

  - support alternates for genisoimage to test/vm
  - add clang++ to clang tests
  - fix record/replay smoke test
  - enable more softfloat tests
  - better detection of hung gdb
  - upgrade aarch64 tcg test x-compile to gcc-10
  - fix plugin cpu_index clash vs threads

# gpg: Signature made Wed 27 May 2020 14:29:20 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) 
<alex.bennee@linaro.org>" [full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-testing-tcg-plugins-270520-1:
  tests/tcg: add new threadcount test
  linux-user: properly "unrealize" vCPU object
  cpus-common: ensure auto-assigned cpu_indexes don't clash
  tests/docker: use a gcc-10 based image for arm64 tests
  tests/docker: add debian11 base image
  tests/tcg: better detect confused gdb which can't connect
  tests/fp: split and audit the conversion tests
  tests/fp: enable extf80_le_quite tests
  tests/tcg: fix invocation of the memory record/replay tests
  travis.yml: Use clang++ in the Clang tests
  tests/vm: pass --genisoimage to basevm script
  configure: add alternate binary for genisoimage

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/b8bee16e94df...c86274bc2e34